From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E65B29B8FE for ; Fri, 6 Feb 2026 08:18:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770365901; cv=none; b=Wmlk+1LuvmD5L49/eEIyoS6iBh1Z9CV3Zotlzm+fHHKlyNCOoz7dfQoXeNb+c94cT8WA6sLWclHaoVndJXIDQ5ckKLcJqDkM+wl6PGnG9AMHOvClv717Kuh1uUPpjbiXyrCoOj6M11YOPU6gtDl7+oNbkqAKc87k27e9rc+rLyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770365901; c=relaxed/simple; bh=E9Je2RiCNi6N4lUYFc/4uUlQPtV42kSF5db8iOikCwo=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=eVcmfQ6AQZsCTwrxcKJdbSng0pKzm6p7N41VymSymLU9tsjkPlb83yRB5xJpyYqasVf3/uLgnELWt6YpRlG7BFz2ALmWpRb6+8mwjuQsEdgHPvDyPYJwWtFGgg+WmjKxu4JcyHJhMh86DdIqAvXlb3wItP50M97cEVitCgaUjl4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=vIP5OAA3; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="vIP5OAA3" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id EEA9C1A2C48; Fri, 6 Feb 2026 08:18:12 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id BC0AC60729; Fri, 6 Feb 2026 08:18:12 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 08656119D051A; Fri, 6 Feb 2026 09:18:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770365891; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=AxpqQFxfhLZTXkaSuFljytHXexdHWwvNyD5mMDCRNAE=; b=vIP5OAA30W+criFOKid1I9J/V5CfmKGcZ2/+M7Gi5giVop11T4ssqQhWqedQlwoVlTtXt9 tCzDdgLku7NPn24r+Vwj4RHGW4e0QyNdn56Lv1IdzsQIBreUGRgMiozuErCoBUnHUqvCSA D4VP9Txor72S/Z2CmInvyBwLprMgGHse7VRRrn18BwBedlrBCZj1gidtBg8iW9jBXnGPRD rfI5J0fdsIwEK0FTmq0fE2PvzHleRfNnrKvwnlzh9IixgivdBJo/WYpgxmK/wFQ9M3WBbI oj8SSR0+WIGg0CRDvU8Rwf87PdKDX2xhS6wlWMxd0N84mSw2+lPOJ3zE7bF1xw== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 06 Feb 2026 09:18:07 +0100 Message-Id: Subject: Re: [PATCH] drm/bridge: waveshare-dsi: Register and attach our DSI device at probe Cc: "Andrzej Hajda" , "David Airlie" , "Jernej Skrabec" , "Jonas Karlman" , "Laurent Pinchart" , "Maarten Lankhorst" , "Maxime Ripard" , "Neil Armstrong" , "Robert Foss" , "Simona Vetter" , "Thomas Zimmermann" , , To: "Marek Vasut" , From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260112234726.226092-1-marek.vasut+renesas@mailbox.org> In-Reply-To: <20260112234726.226092-1-marek.vasut+renesas@mailbox.org> X-Last-TLS-Session-Version: TLSv1.3 Hello Marek, On Tue Jan 13, 2026 at 12:47 AM CET, Marek Vasut wrote: > In order to avoid any probe ordering issue, the best practice is to move > the secondary MIPI-DSI device registration and attachment to the > MIPI-DSI host at probe time. > > Signed-off-by: Marek Vasut Hadn't seen this patch initially, but it caught my attention now. > Note that this is similar to e.g. commit > 6ef7ee48765f ("drm/bridge: sn65dsi83: Register and attach our DSI device = at probe") > and pretty much what every other DSI-to-DPI bridge does. Digression: Looking at 6ef7ee48765f, I now realize it has removed one obstacle to the DRM bridge hotplug which I'm working to achieve. For the interested, there would be one more issue in addition to those I discussed in [0] without that commit. [0] https://lore.kernel.org/lkml/DE2LCFM56Z2Y.2V9NIXP26QOM2@bootlin.com/ Back to your patch, I don't have the hardware but LGTM and I'm not aware of any issues it might cause. Still it would be good if you could describe what goes wrong with current code. Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com