From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C5BB14E2F2 for ; Sun, 8 Feb 2026 02:33:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770518026; cv=none; b=hBVmSCFCtFqVnHKXm+VpIF8PQ0PQsCsGhCvO3x9wJcdY4ImvceTHz/xsR9KGa8vSll1b3UiRcsnC/QLh3OYZiNGDA8dpBlQ1vKd3Laj/c0rSf9th2QU/kapB7LRhLuHQx5PkQUz/Pm+5wIQRnk+66A41rwcHWAdUOgoVdyz3Bvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770518026; c=relaxed/simple; bh=gqP6mR3MRqOJWf5RN+8fPJ7+RDCZ2ZpAdHqDGQRiVcc=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=ZKMv5lDBbmoYwM/hvuv0yf29BU3h1Vsrk6fllNE4n+dC9B6Ja+87OxIldYQRUIDkosJw1PBJ79qLKRVaPyLWh/oCvvPqnxkISFPq+rHC1+pP2nvKJiq/unnswZq5F26TzyI1MLfosULb96p6F36cOv7C3c4oSZmBwVnTE53jSOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ljyhwjkr; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ljyhwjkr" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-794e0e933ccso19871167b3.1 for ; Sat, 07 Feb 2026 18:33:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770518025; x=1771122825; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gqP6mR3MRqOJWf5RN+8fPJ7+RDCZ2ZpAdHqDGQRiVcc=; b=LjyhwjkrZzlfto1Nt9g+Q9wjdJtpDcnwE9ajugSGEMl1VRyCwQ/Yd/AL2Qc2E0epU7 XInD2cR5aIYljm+5PuTWS2egvG0gYTdPcSToj0SKUgJ/r0XFd+8zrNddjgSL5C6uCXat 4yVDSEpc1F9Z74ypiQHvvfsRuTr/ea+E3BZGFZkaJ/SymEiXLUuELi91KZ8oQQoj+0ZC QkxKbT943Os+2FE38BsU1DbFu3oF2Qjq9Ns8FH0eef9B83tvZW82TMNKlt5HJo7ScRZL t+AGpd5p8J3iPcEnPTLFWbkMocFuTmI8Pxwz9uTg2qyW0PiLX3Cc1d9f/dI/3LkG2FnV +2UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770518025; x=1771122825; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gqP6mR3MRqOJWf5RN+8fPJ7+RDCZ2ZpAdHqDGQRiVcc=; b=s7dvh4L2+2WxpABufnekN5FvlDlB5avYtvpwW+bNj5aTT3d91J8cYPVdZ3JznqJgek fkf/QKyOtiA1Cn2AmJalESqB5sy+GMSTge5YO0x29Fm1ZTSdgGZ1vhbZy92B2wkxnVER FcFiQVThx5Yvw6xzoyJ3YtQdaSKpiPwDBihKjRpQIOrCpjS4QlkCKSYIpOJPXdKwTZS9 nSvLXOe1TlV12ogM0LfetWE7N+S1eVaUduvh8e+V34NvUIG8mTWmZZynunLxCPouCrkL 62SxIdXtT5kkmlHDvPQlA24eJkAH6OQSxpjIQtNaKySUd9MoB0NBk2mogq5+zIp+7nU/ HdhQ== X-Forwarded-Encrypted: i=1; AJvYcCXPUcZzvbFUwhTAIZw4e9PTMzBAJQGUtZZ7xAqTsqcOlIaBzbonQuCuOwvmFAnttsjPgkZykWm2DEVGoiE=@vger.kernel.org X-Gm-Message-State: AOJu0YzW9cGDHMuGMbGzh1r4dmXc+QbzRsb9Y85lwPwb8IW586QNM2Rm vfwmmOCIWmLWXy+Tc/SbdwkCwrllOBy5ZfsfsX1X8qIMB102ke7q9FhP X-Gm-Gg: AZuq6aJ6NRPLnZiHZ4Oyog+2cTrIai5M4ZK1a6YITQGbOG720NHk+CQt0zkwIImBMkA qOAvhpQqvsNJEZXDICYZgrlhhkjEjnhU7LfnmZdwiyqqtdjG+wvwRfYtuxDnzNAbtF8iu2+qhG+ hqH+e717XwAPzb5KBxt1XeUqCBATxu5posEO9m3N/lhYapdvK4kfJ2/pQirWUZtRlSzGcpBC4Hv 8b6jAOwRoIVHwBJaqlpNlSe+Ita2/o8ctpLULSI9wEE2hgigv4Sf53sRmLZGANQHThPihKC+OB9 LvyovY/KLfudcU7Pxxr7sw5RLex6h2h0CelmMIm1EAfpWHmoYg2dC8vZY3Td9hI75hf0h+PZ/St WAp4QAjAHkMuYcXv5MU/l21P1K+nXCO0A8NB5CLsyUTYMilBasUqszGJDB+lw3VVe58GJGSohwf NDWI4T9CvNN37IdEHtplyeI1R383ExUdvmx8hOlMax8M7xCMydtqIuZ3ZrlpmaoHDDa7dcWHCiA tAORiOvGKKusf/xORLdVWqMPuH1lWnMBjxBmMCzpiNQHMQ= X-Received: by 2002:a05:690c:388:b0:794:c63f:c590 with SMTP id 00721157ae682-7952aaa8582mr66989217b3.23.1770518025588; Sat, 07 Feb 2026 18:33:45 -0800 (PST) Received: from localhost ([170.199.240.145]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7952a0693f3sm58737277b3.19.2026.02.07.18.33.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Feb 2026 18:33:45 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 07 Feb 2026 20:33:44 -0600 Message-Id: Cc: , Subject: Re: [PATCH] staging: vme_user: reorder NULL check after kzalloc in fake_crcsr_init From: "Ethan Tidmore" To: "Artem Lytkin" , "Greg Kroah-Hartman" X-Mailer: aerc 0.21.0 References: <20260207215502.1961-1-iprintercanon@gmail.com> In-Reply-To: <20260207215502.1961-1-iprintercanon@gmail.com> On Sat Feb 7, 2026 at 3:55 PM CST, Artem Lytkin wrote: > Move the NULL check for bridge->crcsr_kernel before its use in > fake_ptr_to_pci(). While fake_ptr_to_pci() is a simple cast that > handles NULL safely, using a value before validating it is a bad > pattern that static analyzers flag and could become a real issue > if fake_ptr_to_pci() changes in the future. > > Signed-off-by: Artem Lytkin LGTM. Next time, in your subject line, it's standard practice to end function names with () to make it clear you're talking about a function. Reviewed-by: Ethan Tidmore Thanks, ET