From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f47.google.com (mail-yx1-f47.google.com [74.125.224.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8B9B2AD0C for ; Mon, 9 Feb 2026 22:38:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770676706; cv=none; b=jwjP4ycEpMd6z3D/stHXNXamGIejv2/I+wyC8elrbajO89xIQZDwSfMTRAX14snrUfGtFq7ArDq8TqY4KrkEZwuBAEYhGs4FfKB44phcxz9B214BPHTt+awoQDfrZiVcGLrz/pDHsr6AzZlR4yZMo53g7qKRTMNdrEJUu2yFB0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770676706; c=relaxed/simple; bh=+1F8FnL8CSpeYwsWHRcAkwnqlL/SDejneXcwMoqm+MA=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=uvg8Jx/D0uarJrljb96SNyfNCP/ZBKhKy7iMd3i8pe+vN93cMc6slT/WYKe8hWfCqcaByKhpz3pkEPW88ntiPQnqHSlNJAPLqdz7KUTShVFiiWUbZ+lemFWqNR+cCg3Mmtns03E/iPPcQR3vLUG6MeucYEjuh/OXlJAlRyZ2gsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dKKryOic; arc=none smtp.client-ip=74.125.224.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dKKryOic" Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-64ad79dfb7cso284307d50.2 for ; Mon, 09 Feb 2026 14:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770676705; x=1771281505; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ylGPgnUxLH7s6xZuSjA/UAp1Het5Y0hOy+2+tVkQq1E=; b=dKKryOicfpAAgDikiA9/PtH4/zA6y9uYtXeb+wC6dsdhL0CYZMxW9wjlde8sPGehQB KebgctocbOIJLs2LEGDGh6JQvHoBEQ1gWR/2xFAliPSf4VahRMgE4zFATiqgUwiBh1KB yblTBDGceUWTvnPuVusfq2s0OOtlUWIUQgYMzxnH9TKVP+LCeaU+Dw+CIffv6D7d6W/x ULBWJphIC2Olwknc0kjHZj7EbI4Uj7GeyF4l66Tk1C1XKraujbJCRqbb234NCKZG9kgW 5Hjq1/vdTro64/EfSraxogL/4NVoe7Izv4WlkOslvD0sIVKGl+A3sqQO+RUAglAAGsC5 QJ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770676705; x=1771281505; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ylGPgnUxLH7s6xZuSjA/UAp1Het5Y0hOy+2+tVkQq1E=; b=ByoCSq3+ls+u1SuqJKK+cqVGhOJ3LU0eUtfgrq02VSoQb5HHj4R/QJw7QQ540ZOzRj P4Q8IwPsHWr2jP/uptszniZqjnWfEG86gejImbSEVg0KMeFEdveRmArhfJGNdYuo55cp cQl11zikytOIwpyqtfXJvkGNCoe0qPQKaT8wM+Sda6N8xKNsqZlFBlPmdxjfvz/x5UVs s+R2SbzD+Zq1+yHjIA7Q/0TkSIjqAfFIESbXAl8wJhbWJcUSQBk8eJhBIkfKiTKhZiNW mYF6Q5Z77YYN8ATKJR2Kt4C8Zr5hOnIPOmfpxz6V8GVSQywXlQA/pdGjy8ZsHJXXsq0G 4MeQ== X-Forwarded-Encrypted: i=1; AJvYcCWozYzcUW8HL7quA+7h/ocyjaDsKUDZFhGPqeCUGh+2lvmMnovR675a3+grjOhwh9wn5pBAy2zleG7wPj8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8wZVu1KkGWTIq2cayU08Qn4hV1Aq9cJflq4f1oU4N24LeukSg 0cW7OPnsKkuhIN2OIOh0/AP5Ycba/Y8aiKcIEIAlDk4mEvJR8Kbtkc5IUCb+k3PPnzY= X-Gm-Gg: AZuq6aLRmgcpVz9C570ufZNh1sW/dLL0InGPYN49L80rNJNi1X9VolqRCuMybEYv7Hb 9f7JMsY2mFaOO7/WGrJ828Sf83mD3oqM1oFPGZhJz+BIERT1Gj0TVemNstKijknTKCduRux3GRA Tramtt8hwdvzvJLcutpWKPqwyYYQhmGq32k3jAY6MVTXEERof8BumJXTn8nv07OP/LQZrsB0A+L jGzrT8+nlgAQba4bQdRxz61PQrfjI4n7YSn3RwL5cy8dG51ii7vzFMG9LPprCf2d0LnWujUFsME o+lfvWPZP5UnNnnYhU2pYU1JoQI3JH0E6SZPuJvNkPHBtJo4Zat73qWGQD+cHK42bjbd1Wq1jNo vPcpcuae+NOWF9Oyu59vQiftyhwkx5IyXJiussSTwGCuv90bBP7Ygb+KRCcXfjfSPLQ1M2q+tmo B3syMP48bcZ/NoC562u/GY6nv5VsRDfsXvaiLkJmhyf+Mh2FcnUXQwCvRQiJY7KwTsxI0naVH5M 1/2GOCjAenDoHGDGiXx X-Received: by 2002:a05:690e:2067:b0:644:60d9:8648 with SMTP id 956f58d0204a3-649f21bf408mr8255301d50.87.1770676704762; Mon, 09 Feb 2026 14:38:24 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64adc34f7easm6426581d50.20.2026.02.09.14.38.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Feb 2026 14:38:24 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 09 Feb 2026 16:38:09 -0600 Message-Id: Cc: , Subject: Re: [PATCH] staging: rtl8723bs: improve comment placement and readability From: "Ethan Tidmore" To: "Matthew Marsico" , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260208225648.11207-1-mattmarsico1@gmail.com> In-Reply-To: <20260208225648.11207-1-mattmarsico1@gmail.com> On Sun Feb 8, 2026 at 4:56 PM CST, Matthew Marsico wrote: > Move trailing comments onto their own line, preceding > the referenced code, and rework them to improve > readability. No functional change. > > Signed-off-by: Matthew Marsico > --- > drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/sta= ging/rtl8723bs/core/rtw_ioctl_set.c > index 587a87fbffeb..fa3b4be11ab2 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c > +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c > @@ -174,7 +174,9 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, stru= ct ndis_802_11_ssid *ssid) > set_fwstate(pmlmepriv, WIFI_ADHOC_STATE); > } > } else { > - goto release_mlme_lock;/* it means driver is in WIFI_ADHOC_MASTER_S= TATE, we needn't create bss again. */ > + /* Driver is already in WIFI_ADHOC_MASTER_STATE, */ > + /* do not create BSS again. */ The linux kernel coding style wants multiple line comments to look like this: /* * Driver is already in WIFI_ADHOC_MASTER_STATE, * do not create BSS again. */ Please consult Documentation/process/coding-style.rst under Commenting to get more examples. > + goto release_mlme_lock; > } > } else { > rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_JOINBSS, 1); > @@ -310,7 +312,9 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter = *padapter, > =20 > if ((*pold_state =3D=3D Ndis802_11Infrastructure) || (*pold_state =3D= =3D Ndis802_11IBSS)) { > if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) > - rtw_indicate_disconnect(padapter); /* will clr Linked_state; before = this function, we must have checked whether issue dis-assoc_cmd or not */ > + /* Will clear Linked_state */ > + /* Disassociation has already been handled above */ > + rtw_indicate_disconnect(padapter); > } > =20 > *pold_state =3D networktype; Thanks, ET