From: "Michael Walle" <mwalle@kernel.org>
To: "Eliav Farber" <farbere@amazon.com>, <tudor.ambarus@linaro.org>,
<pratyush@kernel.org>, <miquel.raynal@bootlin.com>,
<richard@nod.at>, <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] mtd: spi-nor: winbond: Fix protection handling and enable dual/quad reads
Date: Tue, 10 Feb 2026 08:37:00 +0100 [thread overview]
Message-ID: <DGB3YMAGZPPF.3OZ1TGVVNJ5TI@kernel.org> (raw)
In-Reply-To: <20260208061919.30498-1-farbere@amazon.com>
[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]
On Sun Feb 8, 2026 at 7:19 AM CET, Eliav Farber wrote:
> This series fixes block protection handling for the following Winbond
> SPI-NOR devices:
> - w25q256jwm
> - w25q256jw
> - w25q64jvm
>
> The devices do not correctly describe their Status Register layout and
> protection capabilities (locking flags, TB bit, BP bit configuration).
> As a result, the spi-nor core rejects protection requests and locking
> operations fail with -EINVAL, e.g.:
>
> flash_lock -l /dev/mtd29
> flash_lock: error!: could not lock device: /dev/mtd29
> error 22 (Invalid argument)
>
> Update the device flags to match the actual hardware behavior so that
> locking and unlocking regions work correctly.
>
> Additionally, enable Dual and Quad read support for w25q64jvm when SFDP
> is not used.
Do you really have devices without SFDP tables?
>
> All changes were validated using flash_lock on the affected devices.
Great thanks!
Could you also please dump the SFDP tables from all these devices,
see [1].
Thanks,
-michael
[1] https://docs.kernel.org/driver-api/mtd/spi-nor.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]
prev parent reply other threads:[~2026-02-10 7:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 6:19 Eliav Farber
2026-02-08 6:19 ` [PATCH 1/4] mtd: spi-nor: winbond: Fix locking support for w25q256jwm Eliav Farber
2026-02-10 7:38 ` Michael Walle
2026-02-08 6:19 ` [PATCH 2/4] mtd: spi-nor: winbond: Fix locking support for w25q256jw Eliav Farber
2026-02-10 7:39 ` Michael Walle
2026-02-08 6:19 ` [PATCH 3/4] mtd: spi-nor: winbond: Fix locking support for w25q64jvm Eliav Farber
2026-02-10 7:40 ` Michael Walle
2026-02-08 6:19 ` [PATCH 4/4] mtd: spi-nor: winbond: Enable Dual and Quad " Eliav Farber
2026-02-10 7:48 ` Michael Walle
2026-02-09 10:51 ` [PATCH 0/4] mtd: spi-nor: winbond: Fix protection handling and enable dual/quad reads Miquel Raynal
2026-02-10 7:37 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGB3YMAGZPPF.3OZ1TGVVNJ5TI@kernel.org \
--to=mwalle@kernel.org \
--cc=farbere@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®