From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95A0E2C027A for ; Tue, 10 Feb 2026 07:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770709170; cv=none; b=iW7AmS70v6U/ny4gOc3Q5QLXXJbhwgZMSpOc8e4RW4zoNZjqRq5GZZnSJraaS2TV/66rE5nuZoZh9cd16heTSJpwUtcI9XnC1T5pAUJNGp6mAhsy30IdQ9/PcB7aeeliYjEulaCavqJdCyao1c/QcRayZELg1L7FOni/5bjhRRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770709170; c=relaxed/simple; bh=z093pnh67AfbpYd+5vpxkY6GK2njPW/AKX08iLs8yqA=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To: References:In-Reply-To; b=KpBUCrNexkzp6aPYPxW56kzAbKZBhCHVYsyTbMLztFhPns3Snf6+hZmiLLcpiVQGgw+Lmf8wchXfGhDgeccjBYntHIBYJgDMQkZdXxcc5xi2g0IA55jCiZFzBHwU0Rewh3ehXIgH89EJxdBJUdtaRsKHvmoebHOa6lnC+en4TaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BhhQvkaB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BhhQvkaB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6B66C116C6; Tue, 10 Feb 2026 07:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770709170; bh=z093pnh67AfbpYd+5vpxkY6GK2njPW/AKX08iLs8yqA=; h=Date:Subject:From:To:References:In-Reply-To:From; b=BhhQvkaBuQpi6XrhZ+YxbozOKNlYY0JrmGP9tUMzthseWcjCFtNf8SI92LVpqbe14 M6hroyq1iflKRpGomhR8RpdvaHMIOGXwoVVp85ed6CsY3BxDfaDY1NYti0WK72WEQN nUt++xBXGB/02dKYLj/AKUv3d/DPiiYK5NfJ22I+FqikR5YkAGJgltC1Z+z9KHLIjs 3+vsVrskCNBzd1GNBhgkaVxdYYpu5IUHEoDkxHdvkOKuCFZ0X3vQxhkZD3Z0Oesvnk m6FFr21t4NOs035YIMXH9V+mAzHmxI2v/92iRurA8EctIDXeHBn9iPZ/pBQl8uiOSK YW1YPnl7uC1nA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=328e4e3fda3be62569361b6e87eedf66813880e36d88c012b54c06fdb6ed; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Tue, 10 Feb 2026 08:39:26 +0100 Message-Id: Subject: Re: [PATCH 2/4] mtd: spi-nor: winbond: Fix locking support for w25q256jw From: "Michael Walle" To: "Eliav Farber" , , , , , , , X-Mailer: aerc 0.20.0 References: <20260208061919.30498-1-farbere@amazon.com> <20260208061919.30498-3-farbere@amazon.com> In-Reply-To: <20260208061919.30498-3-farbere@amazon.com> --328e4e3fda3be62569361b6e87eedf66813880e36d88c012b54c06fdb6ed Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Sun Feb 8, 2026 at 7:19 AM CET, Eliav Farber wrote: > The Winbond w25q256jw device: > - Supports lock/unlock via SR. > - Has Top/Bottom (TB) protect bit. > - Uses Status Register bit 6 as the Top/Bottom (TB) protect bit. > - Supports four Block Protect (BP) bits. > > Update the flash parameters by enabling SPI_NOR_HAS_LOCK, SPI_NOR_HAS_TB, > SPI_NOR_TB_SR_BIT6 and SPI_NOR_4BIT_BP. Without these flags, the locking > configuration is incorrect. > > Reference: > https://www.winbond.com/hq/support/documentation/levelOne.jsp?__locale=3D= en&DocNo=3DDA00-W25Q256JW.1 > > Signed-off-by: Eliav Farber > --- > drivers/mtd/spi-nor/winbond.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.= c > index 55f1209936d5..6d325da121b4 100644 > --- a/drivers/mtd/spi-nor/winbond.c > +++ b/drivers/mtd/spi-nor/winbond.c > @@ -274,6 +274,7 @@ static const struct flash_info winbond_nor_parts[] = =3D { > .id =3D SNOR_ID(0xef, 0x60, 0x19), > .name =3D "w25q256jw", > .size =3D SZ_32M, > + .flags =3D SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 | SP= I_NOR_4BIT_BP, > .no_sfdp_flags =3D SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, > }, { > .id =3D SNOR_ID(0xef, 0x60, 0x20), Reviewed-by: Michael Walle -michael --328e4e3fda3be62569361b6e87eedf66813880e36d88c012b54c06fdb6ed Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCaYrgrhIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/jw3gF/X5Eh/fDiPFqPcl3dDXHUNrJob6Uhoern dl6BlgR9K+kjWXItYIKNZfJYHf69fY2NAX9RIHQzJRgTP1Q3UlYW5tQvl+p+klko wH24NinJEtwS3WkuFX00qU7OBLld0mSdg/0= =KoNL -----END PGP SIGNATURE----- --328e4e3fda3be62569361b6e87eedf66813880e36d88c012b54c06fdb6ed--