From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E42132C926 for ; Tue, 10 Feb 2026 07:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770709245; cv=none; b=n9vMBWWB6310mt2TfyttoT2p6qJcOZxyFBsH5i9xkZiwO6XKCI41XS2/E1HuLRJZ/4IEK1WSWIsthnwtUFSUFl3LF5yBavvf7JpcJUnBoaqd0hzikGUJywN5F4rfapY8U00Y9CcJ0MRM979OpFUGZz9HUxyonoYp12//CtmItnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770709245; c=relaxed/simple; bh=HUpvyTdnSxp/WMVK280ifaOqx4p9QfSA2RIUO2yQrmQ=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To: References:In-Reply-To; b=sePswWj4ZFOT2RGHr5KeHcH9BfgUMSSrJbos0ObxfxxLcdyaYG9GfqkiMzXHm6UUFKX7NpZvybHEhEU8DTGDWUAJoPj60was+j8w2e307S7a3c9WDVWJjl0C2iFPeyKNCSuJusW3cMHF9O8eU+L6rPVMETz/DtmjwZJ5GJa/5hk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uR4vc9UG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uR4vc9UG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7053FC19424; Tue, 10 Feb 2026 07:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770709244; bh=HUpvyTdnSxp/WMVK280ifaOqx4p9QfSA2RIUO2yQrmQ=; h=Date:Subject:From:To:References:In-Reply-To:From; b=uR4vc9UGh0NN4zdzGw4O4F+OLasdNaNosYgLCv5UuEjoFFQMwCrc+52XvblvMaZ4Q wQ/DPIb64F21av3oMWojg+ycOxg2lPF/1TIEYfN26WUb70B9Mrt05qmEDcNORBv7XD Rd/cL1UCdEHRgQLQrn0Af0zufotljf4V1dwMpANE0yD8oWk54f/DPq9gQeTLH1VJYD cYc34T7aYrpV1prumvW3tG6iLsPJOSnPejtGSnpVQbigEEAyIJJzSKkHwVJMduQwEf y4Sk8iMV2jwvymBhFUMWJZqwk4gkOh/ouLL86awPv8tYc6tfx8YkCZvZY0DE9DgJcT sFmtTkurEOm6g== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=85f2de07f6ff37745cc69fae6dfba0a2d6b1524ab31452ece5ade311a22a; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Tue, 10 Feb 2026 08:40:41 +0100 Message-Id: Subject: Re: [PATCH 3/4] mtd: spi-nor: winbond: Fix locking support for w25q64jvm From: "Michael Walle" To: "Eliav Farber" , , , , , , , X-Mailer: aerc 0.20.0 References: <20260208061919.30498-1-farbere@amazon.com> <20260208061919.30498-4-farbere@amazon.com> In-Reply-To: <20260208061919.30498-4-farbere@amazon.com> --85f2de07f6ff37745cc69fae6dfba0a2d6b1524ab31452ece5ade311a22a Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Sun Feb 8, 2026 at 7:19 AM CET, Eliav Farber wrote: > The Winbond w25q64jvm supports block protection through the Status > Register (SR) and provides a Top/Bottom (TB) protection bit. > > Enable SPI_NOR_HAS_LOCK and SPI_NOR_HAS_TB for this device to > properly describe its locking capabilities. > > The device uses Status Register bit 5 as the TB bit and supports only > three Block Protect (BP) bits. Therefore, do not set SPI_NOR_TB_SR_BIT6 > or SPI_NOR_4BIT_BP. > > Reference: > https://www.winbond.com/hq/support/documentation/levelOne.jsp?__locale=3D= en&DocNo=3DDA00-W25Q64JV.1 > > Signed-off-by: Eliav Farber > --- > drivers/mtd/spi-nor/winbond.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.= c > index 6d325da121b4..eaa547d36aad 100644 > --- a/drivers/mtd/spi-nor/winbond.c > +++ b/drivers/mtd/spi-nor/winbond.c > @@ -296,6 +296,7 @@ static const struct flash_info winbond_nor_parts[] = =3D { > .id =3D SNOR_ID(0xef, 0x70, 0x17), > .name =3D "w25q64jvm", > .size =3D SZ_8M, > + .flags =3D SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB, > .no_sfdp_flags =3D SECT_4K, > }, { > .id =3D SNOR_ID(0xef, 0x70, 0x18), Reviewed-by: Michael Walle -michael --85f2de07f6ff37745cc69fae6dfba0a2d6b1524ab31452ece5ade311a22a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCaYrg+RIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/i5aAGAiXjguK3xcf/C1Vi9v7FFB2CppROAyZzS gmkKeqkuN0JP09s4Y9Tzkne6mjooJxfrAYCxJ1cXx+gLUhaPntSfspNtv4V2CwJX CWAOz3wjCFiPZbDSF9LiCj0x2ZG3pnz2Nwk= =uAGn -----END PGP SIGNATURE----- --85f2de07f6ff37745cc69fae6dfba0a2d6b1524ab31452ece5ade311a22a--