From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3355625B1DA for ; Tue, 10 Feb 2026 07:48:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770709691; cv=none; b=nCLxAYYQQEa41UuMLfTS4lZbf00FOvVD4c5qPfnaqGMJeW6Xc7KOvywqyP515JhDlJWFSwCkB8SfuYx+0p06+B4bsPraqrO74BbtRBwQI2BVouZpaiuDzzf+K+yPRNLobi6p/0mZ745mXISq4e1IRDzjMl7pa+muW40yvrwFbeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770709691; c=relaxed/simple; bh=MXFPlJA6Qs9kB2Uy1oaEijVuyB+24NhaEuXmK56DqaI=; h=Mime-Version:Content-Type:Date:Message-Id:To:Subject:From: References:In-Reply-To; b=PFZh7cv1Fl+pJ4YWSFuMDdDElYP7rr8lxXhLJJ7sKPPOUwxzkw76cE/5/10pAx9OMEL7SeaxwtNomKw1HQcCxyRJA5eKBu1BiBX1PC/3kilT4AnZ5+CXFo9IvYL+BnEFrUJfBFP2zxZTB00JKB6xDXkhhdjDQH/SQNctlHgHqgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fBnYeDQN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fBnYeDQN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A7CDC116C6; Tue, 10 Feb 2026 07:48:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770709690; bh=MXFPlJA6Qs9kB2Uy1oaEijVuyB+24NhaEuXmK56DqaI=; h=Date:To:Subject:From:References:In-Reply-To:From; b=fBnYeDQNizst4nR0+9Oc63RxuwS+AfzsSV/uzB+TP+Nlp5KqSeD+HEWCAfZddsLUg IGFN7rpf8mCEOmtEv0Uf20f14q4TgFedp22MLBL8d79zMKMxKTUd9qeKr9ZYd8V9v4 tdM4oeQBtDEnYhya+nNdtl+QV4dkGKBW4eYd1a0kakJFRgQ2glXNv0i+fSZuURKcoI /N3lv1rrilyjlMGdehpsz087BLTKv94ZFrJ7o1bRN8ZALse8+mKxXwhibdwmzo9yMb EPycBDv6cfJBq0bUFIVUVghYuHrgZ2vTihERqE2ZG/wyiiKkNeEiYp2vM/oOa206wA MtUuk8V+SRAxw== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=3c8ded4c71382c56aaba51042a08ce113f5634ca0c90ad45bf1a96a83628; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Tue, 10 Feb 2026 08:48:06 +0100 Message-Id: To: "Eliav Farber" , , , , , , , Subject: Re: [PATCH 4/4] mtd: spi-nor: winbond: Enable Dual and Quad support for w25q64jvm From: "Michael Walle" X-Mailer: aerc 0.20.0 References: <20260208061919.30498-1-farbere@amazon.com> <20260208061919.30498-5-farbere@amazon.com> In-Reply-To: <20260208061919.30498-5-farbere@amazon.com> --3c8ded4c71382c56aaba51042a08ce113f5634ca0c90ad45bf1a96a83628 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Sun Feb 8, 2026 at 7:19 AM CET, Eliav Farber wrote: > The w25q64jvm supports Dual and Quad SPI operations. > > Enable these capabilities by adding SPI_NOR_DUAL_READ and > SPI_NOR_QUAD_READ to no_sfdp_flags. Let me guess, you have a flash that actually has SFDP but it's not parsed because the core (due to legacy reasons) skips it because neither DUAL_READ nor QUAD_READ is set. See also [1]. I'd prefer to always try to parse SFDP instead of adding these legacy flags. -michael [1] https://lore.kernel.org/linux-mtd/DD10GE4EOCD7.CPTN7198QFUV@kernel.org/ > > Reference: > https://www.winbond.com/hq/support/documentation/levelOne.jsp?__locale=3D= en&DocNo=3DDA00-W25Q64JV.1 > > Signed-off-by: Eliav Farber > --- > drivers/mtd/spi-nor/winbond.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.= c > index eaa547d36aad..cb35ec6f110e 100644 > --- a/drivers/mtd/spi-nor/winbond.c > +++ b/drivers/mtd/spi-nor/winbond.c > @@ -297,7 +297,7 @@ static const struct flash_info winbond_nor_parts[] = =3D { > .name =3D "w25q64jvm", > .size =3D SZ_8M, > .flags =3D SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB, > - .no_sfdp_flags =3D SECT_4K, > + .no_sfdp_flags =3D SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, > }, { > .id =3D SNOR_ID(0xef, 0x70, 0x18), > .name =3D "w25q128jv", --3c8ded4c71382c56aaba51042a08ce113f5634ca0c90ad45bf1a96a83628 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCaYrithIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/iJvwGAxfNw/Cb2P4VES0ONLfAqu8+DZOALtwj5 Msbyab1Mtwj1X4tnVw255AvW0b0TJEi1AXkBpQQ0T4lOHTOZhF13zwxO7M88xbOa VcKVwYXd/mgBMg5XElSxBoyQCuponQaz9+s= =LxE4 -----END PGP SIGNATURE----- --3c8ded4c71382c56aaba51042a08ce113f5634ca0c90ad45bf1a96a83628--