From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6835F19F137 for ; Tue, 10 Feb 2026 18:33:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770748383; cv=none; b=tOqxvAjZOlZ+ntXDtZt+TitI1RNJ2uonl9DXhUnkPlRk3SEEY1hu6y0+xxkmQj6SiNw8fsY6CdMe1W+dF3iGrkG0/bC5TrxWvrQCPnW3FlYjY7aHZMGuLZ2ClzLpM8xi3L0x2SHqZ0shUQULHimgDYulwsgOj9Nxkz9/CLXJ45M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770748383; c=relaxed/simple; bh=ONEMFp7vcnI6sDYdo6E4jx7tPeTNLnFlhMv9UO5UFXo=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=Ha0ATzq3ghy8QlFOiwy2O8YqzNWZhB+xaF/nlEL7WDWZsXKElqTLnXRLilrGWfcuq66DXW3CE1XX8GISaRTUUUSdMZ0CLlrvkiNm3EFF6UFC9wCGpEfMFvxg2Wz+QBgnglh07oj5LyVKyMV6k5gQ10FSnb0IAmAsrsBJdqHrRkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KgqxtCsk; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KgqxtCsk" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-7963b25e0ffso27250497b3.0 for ; Tue, 10 Feb 2026 10:33:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770748381; x=1771353181; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zH8sv4KedO9YXud5xUzg6TOIFuBuqcMpb+6s2Wz1GSs=; b=KgqxtCskRw0JnnHoj1eOEc3QWuQSA+mcc0dafHEqA/nFuSYEifeuo+di3Hf+myndG0 Vzwb3gfgMGNej8CKjDtmPQlEM+ACKB2TlfNUiMrkHMc5JUlXpnNIe1m1PQzV3hbNAza7 qYRE0G1uqZLY8MfDI04YQIuUC/9IddazunIDG3V3BYYtyJ0kdr81WN7hhydCPXxqfX0Z wkjTTm1z9WNh8lXSBi/d5/1PJ6JkdGVe7OqvMGt92c4E2PFvL1GwHA3X/EKfIg3tv+Ys Geonchj/RlGsJ3ZC7yb2a2Zwp4ShI6ybByMbd1OqvqA6L7FmEkbdar17ZsrAE5aOlNLl lOVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770748381; x=1771353181; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zH8sv4KedO9YXud5xUzg6TOIFuBuqcMpb+6s2Wz1GSs=; b=bgmBLeWJTVceez92Mf7x23PqPF1QhHg3TYz1/AwTO5xDIk8MtMPGoYWSEGWynraVmb vK86eV4Ve0t5X1Y8//mJcxDYkf9qp224hKVTLTcBwYzdaq1BgYr3eHnbiuppmj62jUYu N1tHfsUSls8MIpR5nUW4H4VGkhmcmAuj3AYREnEfbf+mz0K2N5+LrXX0Dus82nWrd49K 5SaXTyMobR2Ak5usy0xsVonuiaoJ3tt/n/aO8UYzQnQjJUPfPBOSgG31ettvT0tfieJV viugYYcwKDJCOIViDJsX+vNK6cPRR1CBB7+cyKfGBuKSNkzNG1PlHUk8knv9bkAmHxSo WSKQ== X-Forwarded-Encrypted: i=1; AJvYcCXDVr74kLxI9zXZvu6xrYyB95RH6FKvNjZud7r9OxiNF/f8F47zr3EqYZcd3SRfjLRdJ+DXMXx69cOQrjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzFuBRG2tl36OOfLJHvXIN8CQEa5g8Ybm/ANGvbWPGPacfhsSmx 4LO1OWaIdq5pKnzWejSWgDpjLUmvm58QoZWQi40JYxX109l8r2Y0e1mDcWa7jcuWG1E= X-Gm-Gg: AZuq6aKgZLPdFLvDzP9k/H6V08B5Kuf0nGaRBRWRqi3/gV4wnv2p4Te71Z5XAfS295h P6UxqJwZo/zKxXV4UrFci37AX5N3Y2XufIq6aEP+Y/yoRqvxt4IkH1M+fiMgi4UC0/ypV0lzuii jdMDN4k929XCoGdkKTwXB/QHYF68q/6hgypY4iWxib+dyV9eFet5JvMb+FaPp/v69zN/RxEHDk+ jAEkzpC2eXZNcmBFQymxxw3bgLP0LM6sqFsdjB4kJACtgnDMWMN4AY3Wim1XjWnwZXzFz56FKvV KEZBXk+dbj7PJddB+pHL0v65TKac2RvD2VC8aimmGvLxIPLB3Ln3VxAfdtarSI4LinQBHiuKQki bqkp459aynau8cfpZjbldWMQVhd5DrawICqRcU1v7IRqB37tMPlQRKbJicJgv8Vpgh5oPG/794R ZQ5XvLb/3O4r0mo4+C+1YvUOzsmk8ABATlOl8ZWx8Cjxu9ckFBkPFqgbO/d+jIXD+DO4UJyXQnQ gY5kdG6FXUMQoGY4KkujfUrP7X+TneI X-Received: by 2002:a05:690c:60c1:b0:796:5a14:87c1 with SMTP id 00721157ae682-7965f062128mr23854397b3.44.1770748381311; Tue, 10 Feb 2026 10:33:01 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7965f5f6e4asm21795987b3.18.2026.02.10.10.33.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 10:33:00 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Feb 2026 12:32:44 -0600 Message-Id: Cc: , Subject: Re: [PATCH v2] staging: rtl8723bs: remove shadowed variable in sdio_halinit From: "Ethan Tidmore" To: "Haroen Tmimi" , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260210170457.50720-1-tmimiharoen@gmail.com> In-Reply-To: <20260210170457.50720-1-tmimiharoen@gmail.com> On Tue Feb 10, 2026 at 11:04 AM CST, Haroen Tmimi wrote: > The variable 'bMacPwrCtrlOn' was redeclared in the function > CardEnable, shadowing a variable of the same name declared at the > top of the function (line 21). > > Remove the redundant 'u8' type declaration to use the existing outer > variable and resolve a -Wshadow warning. > > Signed-off-by: Haroen Tmimi > --- > Changes in v2: > Removed incorrect blank line after the opening brace that was left > behind when removing the Adapter variable. > > drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 1 - > drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/sta= ging/rtl8723bs/hal/HalPhyRf_8723B.c > index f712d0345b99..0f915589b518 100644 > --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c > +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c > @@ -208,7 +208,6 @@ void ODM_TxPwrTrackSetPwr_8723B( > } > =20 > if (Method =3D=3D TXAGC) { > - > pDM_Odm->Remnant_OFDMSwingIdx[RFPath] =3D pDM_Odm->Absolute_OFDMSwingI= dx[RFPath]; > =20 > pDM_Odm->Modify_TxAGC_Flag_PathA =3D true; It looks like you accidently left your previous diff in this patch. Thanks, ET