From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 231622DAFDD for ; Tue, 10 Feb 2026 18:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770748751; cv=none; b=nsUgOFxq3p7xsbDvRcnvuDozJ/Fy8rNVNhsSVEqL61W9KldDu0CmXMYMK63HHu+9jSYPjGS1npGmYnau54kzLqzpSQYMf/YuL39dZNwlOrWSxHES1zmyd/5GTxVO706xdK1HoIdetAxSO6MLZ5CbmdSUhh0+sdRQDQH2uJl/avU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770748751; c=relaxed/simple; bh=NhChq0mbuSDRx8lv6OsA8KYmeRrq1h5IY9GCMo98X/k=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=XKDg0kbsM7H6Q23b853BAxyb0pXOKCi/103898+DAqO8de2fWSK85n+iAF5hfBGbwe0plxDFh3YQLU0r5uVozGygSa0J2vcMP5+Eb28a88v6maKRVPlSMlzM6B95UMnXuoAJC9grZ1n0xwpFefLeYpcHP8pj1REsxQ0qm/wEFUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GRJ0Q7N8; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GRJ0Q7N8" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-794f701a3e6so56062497b3.2 for ; Tue, 10 Feb 2026 10:39:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770748749; x=1771353549; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FxhVtlHqLQVjAT+2NlUYl/ca4V1OJPEEmLd1oGMJyM8=; b=GRJ0Q7N8ALUXHpr3hiAvu5K0QH63D3xIRQnh9iBkjZtiA4Ejf+c/fJd/91GhS6Yd82 fr0UJaXCIWHGDntkITZ3yKOqo92zRGcUVFx9L/p09IrqlMvIMsISeLK5ZueUcnyasIwO hn7vVuOkvlyVBexlJhtWDxMw8Pqv6cl9r2DiA+Ni9oB/dREtVyLCvtdfCeL7capb6sP1 +yuOvWTaiMZ+sb64+pr0v5jqczQ/Kz3ey6AmFQ9tTlxWOGbmSctXVr5PXeXRS98mgXxA hwrrhvExXtly0DYrw3m/S8679pheExotOfkREUg93de81ffeSSaL2iz8KNVUNpqWbYk+ BUBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770748749; x=1771353549; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FxhVtlHqLQVjAT+2NlUYl/ca4V1OJPEEmLd1oGMJyM8=; b=pHa7oqBqGHe/kbsMRJBfU4iltM5I+l+e0EjVm2d94GDsNF/HcPkC8cas/a+7l4RroZ CLtkhVutynagdP85lGMZfBb8qLFmd+k57qvZXJxjQQGSwoMhM60SAL2KZnER+KERWgDB 8fwvshdrr2GvQbhTdYPfxIQgpSXQycd3WRhz50L6zKJebh89jDJ/ejobK1EipFLL5D9x QnS0mvO3ofPc9FZ5ZQIyXShpBAPK+BktjGhS2Vy1IFF5CYqSYa6Re7kTruui4OAHVPiY KvrewuiAzXR3HZFMzaqm0qb4pAa5x+xij7vBa95/L7nB+V6c3w/Nbib8+TTnc8jFWe5n P/Mw== X-Forwarded-Encrypted: i=1; AJvYcCUPd8v/+rxwUhJ1+C7Sj4md0ka155Oy25xVFKFrM+rFL4wbEylmW1h6IoxVPWQiXCNeR0so5koDOGZMuDs=@vger.kernel.org X-Gm-Message-State: AOJu0YwkOxrqIPh4jjyxXsyCi1ZCq+hNi0QBHK2TIhQ0SdEHH9jwSDKz d0V8xPgAVReHXyjh02eKHUytTgo3ZyK7RdSNo6zf7ap3bfZnAO0Q2Opt X-Gm-Gg: AZuq6aJdr0OabuxkGHkhLWMmHE9d8K7O8TXZU5XmouuToiiyw5oO6vIvNpm1EEm8dNG tNjooRK2qG7yIdU1ln0mrkJujT+m6TIun50Cqt1t9QqSnHfo7J/3JZvTCjr5LOS/tuvAReTC2iC jK98vKOZAHrvNYJRVvIgbMHHoLWaCKvjRnWdPniXyoekQsKPOClcJBCYsjZdfJsdFlM1I5HZmW1 aMd1/DEv9fc0hQq6NEcjWEEE8iFOtQeIFijbSSibVcdsOnIpkw/sDmEIanHAv3rCO5tFB8c/tTw yOoxlFIKa7pkTh0aEx554sNyY+tt9F90vj/GXV307U9ZbtjxTrQjhd3knTBOshGTfVnnv/C4ftd ZRGelDgywyj/B8LL+bvHcTmliLvJJwCrRBSEZubAeIOkuMVcg8EiKH89G6iWZX9c9F4bn1EyWg5 Iu8zxmQPnaaI3Pucd+VAZUVPZP+bD4W4+rQTo7f8IFR1ggEB+Kp56fw6JRASi0g8CCx1FC5FDCN rlUUOHBUhZnWQbOUQs318PRKdmQtM3J X-Received: by 2002:a05:690c:fc7:b0:796:3981:fd6e with SMTP id 00721157ae682-7963982096cmr80565947b3.10.1770748749129; Tue, 10 Feb 2026 10:39:09 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7952a28a62bsm125287887b3.51.2026.02.10.10.39.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 10:39:08 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Feb 2026 12:38:51 -0600 Message-Id: Cc: , Subject: Re: [PATCH v2] staging: rtl8723bs: remove redundant 'Adapter' variable in HalPhyRf_8723B From: "Ethan Tidmore" To: "Haroen Tmimi" , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260210171433.52164-1-tmimiharoen@gmail.com> In-Reply-To: <20260210171433.52164-1-tmimiharoen@gmail.com> On Tue Feb 10, 2026 at 11:14 AM CST, Haroen Tmimi wrote: > The variable Adapter was declared and initialized locally in > an if-statement, but it shadowed a variable of the same name and > value declared in the function scope (line 169). > > Removing the inner declaration allows the code to use the existing > outer variable, resolving a -Wshadow warning. > > Signed-off-by: Haroen Tmimi > --- > Changes in v2:=20 > Removed the white space in line 211, which caused a coding style warning > (reported by Greg K-H). > drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/sta= ging/rtl8723bs/hal/HalPhyRf_8723B.c > index f712d0345b99..0f915589b518 100644 > --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c > +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c > @@ -208,7 +208,6 @@ void ODM_TxPwrTrackSetPwr_8723B( > } > =20 > if (Method =3D=3D TXAGC) { > - > pDM_Odm->Remnant_OFDMSwingIdx[RFPath] =3D pDM_Odm->Absolute_OFDMSwingI= dx[RFPath]; > =20 > pDM_Odm->Modify_TxAGC_Flag_PathA =3D true; I don't see the Adapter variable here?=20 I believe you meant to use "git commit --amend" but, just made the v2 its own patch without the previous diff. Thanks, ET