From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80D6C24E4A1 for ; Tue, 10 Feb 2026 22:46:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770763604; cv=none; b=r/z7MScBzuY9BH3k/koPSNv4Q5qJ7dnpOPqas0OPWsZd/dkByCmgYiZoSl63TeculpJA4hR95kVi8wwSMCiPaeBm7vQsZN8bcr8V7MVal4aREOTrwb+cxSYyRve5/P7CK/XWMGJUgGrOZoZvkxcBukoizjZGqJWVP5bNL+0J3vQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770763604; c=relaxed/simple; bh=2O2dga4RnJAEvrkKJpllsfgDpZEKVIIpJHpqwcphQcQ=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=l2Zx46afUdtDCAlG/XB0yAAByXbmQMWK3+5PCNbxqelCja52mFtiX1PI/9pWVZ+65xAqYoK3d6K5Dj1IrD0Agr/VTzLMlgUNbYUAZm8YBuCJZxSTwnceplMnOxU9qahZI9ZO2ucqrJNMTLyitPvdHCkw4f2vwxXukW8XYHfvnAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OJIOYedT; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OJIOYedT" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-790992528f6so14603447b3.1 for ; Tue, 10 Feb 2026 14:46:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770763602; x=1771368402; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2O2dga4RnJAEvrkKJpllsfgDpZEKVIIpJHpqwcphQcQ=; b=OJIOYedTGpl6iCBvyiikIPozIPzxPAa73zDAkqb6HPrIUzMNmrRclUotqC2B0/OUOk Bi4/Mi8amCm0Dc4XFbrmT4Jrb1wbeigb6KDS6m1PGEOMJJLUhhJbGb7n4AGkIjRYpHD+ 5Dqp1iOWJfDLqYOSvS6wztTyPj5J4ts2ZGOH4ZoPb6Z8L2q0BXhaXQ+rM0J46975NwGj hgCb0drpC3QYSwsSnHW5W/nNKtKgBIYaQucGhAErEmxjQUvHbtMH+BHNu+1BKohpzIjT qtAxfildWSmsjQJeTxlGmbttOdZgUNwKkdD0/Uo/G6XCgzHxI/e48N2q3qeFfu1uahPA Rzsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770763602; x=1771368402; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2O2dga4RnJAEvrkKJpllsfgDpZEKVIIpJHpqwcphQcQ=; b=pAn6bos0oQEsh/lPTHuRO+ZbLgbYj1ZVEBhlTBjcX2BdWYh5s5q/vX5u7FLFqacsC5 lzRIWoaAtWkjlKzkTM2vY0BOamobUaK/b8d/RlY9leD9nK5z+tUXxMGb8ut/Oj42gzDu dRgwAVx2leewjtKsDh52YMJqgZJdgVwdAx5jLg8wDFD2npo5kAHE3jor1cJhY4+BWGt/ txpgBdhDwvUlS6GxUZivaMBSGwOkJWBUhoX8Sv4oY49N9dspS/tTT96FjpGkutRaolfr bcCHIWBzb5WQRWjvWSILiDvyBTXwZsfiyTtWd++0UH5d1jqCI1AGdfqM23V06jkdShAZ Dv2g== X-Forwarded-Encrypted: i=1; AJvYcCXC0kQGTfbVoKeLuWIh94eEWltXah2PuD+OaIlZK17Cr6KQGNWFNAEyY8pznVK71eP2FY4qAFPv+o1u9ws=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5tXSZkfl1Gb4LwGWpvBqdHOjolVOqPEBAr6DiIqTAbekrcCR1 TqvpUlwtmqniBR6xfUYUuvTEov5E1KMBRhHeQBdvIwL5ljmFxR0CEeLb X-Gm-Gg: AZuq6aLaCokCgD6aQtdIhI1QgMAVEWCz4szu8sYy96FTzEZ0O4X8T2qiKg1jedJ/9wH AL8SkMQVzyiP5c+yjihnHIpcLOezmcqw73rLud2s5+3wjn0rpmn0RDaqHlOBNpdxV1nEwHqzc/G JHsY22PlQSwPlrshLtJ8oFk4ANNIXGidI33dIlB/flNh3t0FQtfDBsIZgYyDH4nYYXGUVHm87J9 chZfx8mkWmYmGvFoID1mieNupxKlFGoHFO+68Rv9H+llNBUIyCSIKJOJE+Lw4jfTeqKVjYDaZ3H 7+1eWD0CMRN7OsV7P+SZ1+zSaxdPdZmyNaongUyntjOFHz2hvKZfiGwUy5dGbttZBy5ofrtcuv+ hJuPkjWDQ4Tv3XYlyhTKjWRR3sT0aIQv8fdFCcsdUG7gc+aalnfIHGz652zqHyRgJ2UozCcfMb2 aTfm/x6lOtEzoK1ZfRuPAWJSOWKa8CvXE9qFWujSENEAj1YWQeDLEJjOTsnKOhBd1iziTwBXmlW nWsXMjfpuAoKaV+0cNDMey4D5mfS9S+ X-Received: by 2002:a05:690c:4d02:b0:796:6c1e:c07 with SMTP id 00721157ae682-7966c1e0e60mr30327b3.10.1770763602450; Tue, 10 Feb 2026 14:46:42 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c16e7b0sm197737b3.4.2026.02.10.14.46.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 14:46:42 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Feb 2026 16:46:25 -0600 Message-Id: Cc: , Subject: Re: [PATCH v3] staging: rtl8723bs: remove redundant 'Adapter' variable in HalPhyRf_8723B From: "Ethan Tidmore" To: "Haroen Tmimi" , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260210185044.53754-1-tmimiharoen@gmail.com> In-Reply-To: <20260210185044.53754-1-tmimiharoen@gmail.com> On Tue Feb 10, 2026 at 12:50 PM CST, Haroen Tmimi wrote: > The variable Adapter was declared and initialized locally in > an if-statement, but it shadowed a variable of the same name and > value declared in the function scope (line 169). > > Removing the inner declaration allows the code to use the existing > outer variable, resolving a -Wshadow warning. > > Signed-off-by: Haroen Tmimi > --- LGTM. Reviewed-by: Ethan Tidmore Thanks, ET