From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C0092D7D59 for ; Fri, 13 Feb 2026 11:10:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770981028; cv=none; b=mzilllze25sBx4TBKrv5tcnFmi/90S/3turfdfWcz+qyWCCUe4Ii4Q/acSlgrXzDEqjpSS3tnl6ZVWp1iJynGdneOtKWzJtcZ8H8mobPF/dfnRlBczTLb7g4TLf5m4tRro8+CyRtCps3s2dhh10RkHM+mlxCJhzsDloWvp59VxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770981028; c=relaxed/simple; bh=0DDA0V33GHT+gg6ofRckPcj0FyO749qYLHX9HZbHrsI=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=cFuivbRXv+1hddiUEbH3ht4WPQq5V38mCglp9+gGAdRgkWIc08/7qnlsPsMUZ7ds+LYEmgbSi4t/AVFzIYug72LQi/H5GWjRVRNxmfdLsN7672Xyz6FbRIG8ZYVBE01G3uTUtpQkawKWdnvH2gYdkNA4Y8/F1Xz2p/YQPN9bWFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=epa5bPLI; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="epa5bPLI" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-352ccc61658so389508a91.0 for ; Fri, 13 Feb 2026 03:10:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770981027; x=1771585827; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=w74rlsrGWmZvKYDg3c0K+Nm4AVBNsTz1ccTbV4Qizs8=; b=epa5bPLIb/JiMwoSRYJbDXPcnPbDWp7ltg/N3Oq1ZFyouuY4/j2kFoNv+l1CeVSDUW DGWqLSFJaxbft3VHm9TmZ0yzgXGt5HRGWamjvuzhLNb5SP5pTdRr4QKprWQ+sIlpMoV6 WDdcR7wMWiYAHUBKMOxoMRl75o4tGX89N2sTkRr6LZrgIkavdgEGYtY/OnB/TgESYpkT A9HzfRlTn7/7aEbB0McOgDbSwaTKbkztwZn7no0uRwJp/b4kfLCiWG6yTWp/wT++k1fl lfAeez2cgEeXmjioOyQWQjj2LfQYV2jC/MytCZ4LHHDiuz079K48TuhFk6n8oz5lOQxx nnMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770981027; x=1771585827; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=w74rlsrGWmZvKYDg3c0K+Nm4AVBNsTz1ccTbV4Qizs8=; b=uzsy09hno37Ejyc8zKT1cIt15/aJNDieVmK06n6bFSZtw1P/xrboEtaTQwzgQNFajf 6quT6kYpP7AjWZrT80ouia8AyQSYueeQvD8rjp4Ru58G1UeYT3aLdOCLUW8LKus263/W aRQR0xyylulL2DBdDUvuSgdAv3CU+43BLAlSHc21//IDxopxx3cKNcctLcCseQNRPgQA ujO2cltVsjo28kmbNuJWyBx0XFICie6P/xIhaS4LwWoGEhwN2Th78GQPgLxiFKabTaKk fGz96crykWeBA3VSDyjTEvXZDeYG8D1ZZ91zuX+QL0up+3+pegCm1drLndaF3zFQHJo7 vhUA== X-Forwarded-Encrypted: i=1; AJvYcCVP3PzvDhmDhrL+fVAacHISvu8OlBgamxjExhX/L4cNEZapX8wM19fGqTRnon2/2PuAY55cRkQppj9Wm8Y=@vger.kernel.org X-Gm-Message-State: AOJu0YykgnS4tONrzZENKdFZKhdHg3lN0yEnynpyP2FZ7wRqt/ByPtWS FYc2UO4ULMHSwpd/NhGoUt77znw0+J/1H5wSO7cTb1IgVdnuy7BIlDb8 X-Gm-Gg: AZuq6aJr8YS9c94u3IDhssNmdFniXuFDpSY2XsLxiN4uxBrXbmgHdsfxMOxvgkfMWIw YCm+N05m/MSGD1Ez8p9afMzkCRKY7WZ6c11djztl2/CrFz5Hd4D9U1n82icf/uC1juukkOGgNdu gILyfqM4Enmhpj7x75jdV8Jo+HfOEaErRw+BbOL4AN5AOcyt27jHEW4knCP4mUN/d3gTQL0hdZ8 dVDWJQnZVAmyUThnW/nY9Qh+qtFB5zxQqBgan/m0E0TlIKYwNdUwJaj07WANkbdMDM1pu2j7917 PMtpyG27/exG763664Mq7HC6Oda+OAs7qaXTI6YyE08wiNn6RYaDgLFEL2VTsdmyGFQAsfnIw76 rqkkCI3xxeuSGXdgVoYcQH6AUCZqMUVLA+q/UhcqWGRJK1m9arEX7WsOG0gqRnA4VgU/oM2ExRU gOO2fZU2/DiN/dcTg8oHHidWiKHJ1V+BHG80soI0hneUoWvlWEcnGkHo22mrHPpcq5cK0EHw== X-Received: by 2002:a17:90b:5810:b0:353:356c:6821 with SMTP id 98e67ed59e1d1-356aaa76375mr1617239a91.8.1770981026696; Fri, 13 Feb 2026 03:10:26 -0800 (PST) Received: from localhost ([2405:201:3017:184:52f5:ed80:f874:1efc]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6a62c48sm2202195b3a.29.2026.02.13.03.10.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Feb 2026 03:10:26 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Feb 2026 16:40:19 +0530 Message-Id: Cc: , , Subject: Re: [PATCH v3] statmount: Fix the null-ptr-deref in do_statmount() From: "Bhavik Sachdev" To: "Qing Wang" , "Alexander Viro" , "Christian Brauner" , "Jan Kara" , "Pavel Tikhomirov" , "Bhavik Sachdev" , "Andrei Vagin" X-Mailer: aerc 0.21.0 References: <20260213103006.2472569-1-wangqing7171@gmail.com> In-Reply-To: <20260213103006.2472569-1-wangqing7171@gmail.com> On Fri Feb 13, 2026 at 4:00 PM IST, Qing Wang wrote: > If the mount is internal, it's mnt_ns will be MNT_NS_INTERNAL, which is > defined as ERR_PTR(-EINVAL). So, in the do_statmount(), need to check ns > of mount by IS_ERR() and return. > > Fixes: 0e5032237ee5 ("statmount: accept fd as a parameter") > Reported-by: syzbot+9e03a9535ea65f687a44@syzkaller.appspotmail.com > Closes: https://lore.kernel.org/all/698e287a.a70a0220.2c38d7.009e.GAE@goo= gle.com/ > Signed-off-by: Qing Wang > --- > fs/namespace.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/namespace.c b/fs/namespace.c > index a67cbe42746d..90700df65f0d 100644 > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -5678,6 +5678,8 @@ static int do_statmount(struct kstatmount *s, u64 m= nt_id, u64 mnt_ns_id, > =20 > s->mnt =3D mnt_file->f_path.mnt; > ns =3D real_mount(s->mnt)->mnt_ns; > + if (IS_ERR(ns)) > + return PTR_ERR(ns); > if (!ns) > /* > * We can't set mount point and mnt_ns_id since we don't have a Looks good to me. Reviewed-by: Bhavik Sachdev