From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A21F63CB for ; Sat, 14 Feb 2026 19:25:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771097125; cv=none; b=ORAH8j8RTd3kNcLsmSuruuxoptaeIwzqOEolIZ2GdEstrO1LuYq0PY5KX1eBhDA4ljkc+ZLyiIz7Qc2vUXyVLnatpoyEy2/5bZm3s07CnRmRVOmADSus+lOyN3Kz344K5bs54xpwCGYDkCKWFgTgz84hBL4Bh5vmeI782xdkrOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771097125; c=relaxed/simple; bh=sjBmtYgoNm2L/egRL+9KTyUHzNMn9Pvq3RGushi4848=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=DQa6Wo1z3YQDFOss1PVAGANZZSUfY28m+WoRLKHPCLQpQylku7qVOQhWRHYUYkX0mfn69lzlIcqmBK66ABCmnP9odcCJWWvjA1YpjPBcLfD487mn7y9xYuUkbKRBlnQvAV0rAaLiSI+5fup5cje/sf9AWO7tQ+b4zkGEq9vcECg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NecvcYei; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NecvcYei" Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-7964fb9ae3dso20212387b3.0 for ; Sat, 14 Feb 2026 11:25:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771097123; x=1771701923; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sjBmtYgoNm2L/egRL+9KTyUHzNMn9Pvq3RGushi4848=; b=NecvcYeiWbwbdMtgH575khy0llKMnh4albeDm503ydMITLMUl+t0n3AQa1QDEN2VQz /lAqGWh5TA2w/Wta7cJlEntYJpPayAccHQy5FmJoNiATrEqVG/bb3fTT9kmT9oruswHb QgHptCuKb1G0CroBlHu5MM6gzm5N8wDFbEJDZYqj3OMbE6ioAjj6ybgSP+jOdB+3dIDT mW+If09G8w0ndeE9CBsjZGW+8LDw+krRtTe5cf9WDrb0RyVN+AyTH9tUPtsh2JSdF7hB 1ehe8mYJ+EKhbKXJGeGyu2MT7hrrO3iQXb8/1pPRJMwEyZYoR5guxjeJt18D+AMZjUKN 07CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771097123; x=1771701923; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sjBmtYgoNm2L/egRL+9KTyUHzNMn9Pvq3RGushi4848=; b=YORazvssBFzT17lbCmqh4ihRBNzrx5Smnq5f4tXgO2a87p8Aee9e/zkM1t6I932YUh 9tyXs7I4P0V5oHiWQ1bjh2ZD3CoNCI9CBhnYmYqZYgTjvD+1UJ9xjFQ76bdPYJGdzKTV hZYLtFiJWW36r+EhH+E4y/eegpJfHpBT1Af/X5eTqYYgNPLkOv0bvdpcLGl0+x60pm7F 7NuriuAH9jlHQhUtYy6UPLeRxphPJsMavmpHeE8qUmf/pk+x/hW/PjhEgiMFiXXOK9MY 2d7ZdIEezx+/Ee7S5d3GKL2kQlBSrakWwr1gYvVy/1Tb3POdDFku4BsyI0LyDYSpBVR2 f0wQ== X-Forwarded-Encrypted: i=1; AJvYcCWUKq2ygqecRhkWT3Xmd5z4hrrBJ+kWGKCRHG9jTo8z20H784IiG6uiGmOwGd6vjOMoSxVIH4qaWKtDQVU=@vger.kernel.org X-Gm-Message-State: AOJu0YzGENQldrpx0FpQm75iSkdAhOL/hmSNJWBY3qBIYof3NyJm38ZU REXLf1gd/0Oz2dQScBDgs/g/pVzNLRr8a8G+oZTzju1AKM3gpzL+SArD X-Gm-Gg: AZuq6aKg04TI8FTqCEjFVHNflDMpqkZ78IGOjKkDZLt2lc8sM8kObM6aEbyB69T8aY6 00MIRihJizKvkzX4D5EC87LdkxlFA+S4ooSVU3BJzBGlhZA9qZddHbuOh+gzA+togySXGtnnXoX QLGrqL8DYGM4i8gfFYvyJwLS5QYO3F7l+iVwxe4qvaFt1jE/HAufgeDGvP2C+8hcBKMvgiXbMly k3BL9VF+2ZaPGp+U1AmR8QEBAoe7ruzeLfjOd17+ojCoHDFcLHHn9k8Cp87rSnDbf4u9OWFjnos O27ufE4r8taYZ35DNAcEmZqFCCzLegKeXd7fQwn9gbTY17cPDWTD9GouORXhVOkvHHNA0+jARXP 4agG+hc1oaeMY+MzQhxgwiJ7JSZxH9VOAGcYgP+5zEo4aa5jZSii61IlENNcy0OVChVHVvMpILH YDZceqeSZiIw5161Pszgx4NseNZ5nLavS3jW4Qt4AorZW/nZ23mdUcNTvrToFnvvZnxJBtUqeyn xH3G8KIwc+S78DTxMbenHneokjLo5uXseMGWw/Upze0tbOjF5O3+IRnLlpy2A== X-Received: by 2002:a05:690c:c50e:b0:797:ab82:7521 with SMTP id 00721157ae682-797ab82791fmr28435937b3.34.1771097123191; Sat, 14 Feb 2026 11:25:23 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c18a935sm81141787b3.12.2026.02.14.11.25.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Feb 2026 11:25:23 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 14 Feb 2026 13:25:07 -0600 Message-Id: Cc: "Andy Shevchenko" , , Subject: Re: [PATCH] iio: light: gp2ap020a00f: Correct return type to int From: "Ethan Tidmore" To: "Jonathan Cameron" , "Ethan Tidmore" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260211004819.854169-1-ethantidmore06@gmail.com> <20260214190829.018b057e@jic23-huawei> In-Reply-To: <20260214190829.018b057e@jic23-huawei> On Sat Feb 14, 2026 at 1:08 PM CST, Jonathan Cameron wrote: > On Tue, 10 Feb 2026 18:48:19 -0600 > Ethan Tidmore wrote: ... > Did you find a path via which it can actually return an error? char > and dir are tightly constrained inputs. > > I think the error return is probably just defensive coding against future= bugs > and compiler warning supression. Yes you're right. I was just correcting a signness warning from smatch and just added the extra checks. > > If so it's still a good thing to clean up but Fixes tag and backports > probably not appropriate. > > And best of all, once it's not a fix we can use some guard() > magic to make these functions and your new checks cleaner. > guard() usage would be a precursor patch with this one on top to minimize > churn. I'll send a series adding these checks and using guard() and will drop the Fixes: tag. Thanks,=20 ET