From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f42.google.com (mail-yx1-f42.google.com [74.125.224.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B263D1D88D7 for ; Tue, 17 Feb 2026 09:03:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771318987; cv=none; b=RB8whnM6+hrn78a/cMIMAmG9xzziCyvNSozzdYIJfvjOsM5MraoFVNgEHpL0v3FryrWU3qffLFsmIFm/Lx+sYyR+4qULHWt1J3fUqo0wPE/M8aPOD8ddEWdfnHA6G88HV3JygL+eepKNx2rNgmWmvy05f4Ur7jEW0vta+lOUTv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771318987; c=relaxed/simple; bh=MfcsSgPWRchgu0Fe44oDchYog/AV4PJhKU9vvH05Npw=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=QCWoaaYRB8oFQrQLu/0ijxtmFUzTpmCpa5D9PAm4MbDIp9NRslUgH8ZY4970S775i9v/ZHZZlEgumgiGImpCtHGrWN00XfiduQtj67p/xirIIUZdYslAQy+gbQSpcZM3qgd25XjyHsJAvxRqW8rlNFMPie18fZ17K0mixTnlNoo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=npAik1nH; arc=none smtp.client-ip=74.125.224.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="npAik1nH" Received: by mail-yx1-f42.google.com with SMTP id 956f58d0204a3-64ad62a294bso3801502d50.1 for ; Tue, 17 Feb 2026 01:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771318986; x=1771923786; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jjF0dk5KMmp/3IOMF9v7+zo8gHgtNcDNHXPYWCCd6nc=; b=npAik1nHmcm7p4YjCGnCVsYqbGqzRL+OwGL9KVgLsByJWvAlw56TdLXl/hVFV5FFzG tiU0gC5d4koOzupp6QSulLyGgNl/pu7VJSRXV5flYHTe0iIDi9yoYqveNF5qjOmPr4IH Ist66XOqFec4CXdBacZx5RrB4eckVYx6ec+sAVoOdjXToK/6bypaJoFKstvi6f/MIy9h qxPLGgYw1ZE94yhdtRkn2RR1Pmjy1ckMnz8MZ9Lw6ktHfmuhc5qklDmGaX5EavbwkAOs 1t80jikO2hoingKPOm7g2IFLGIU/6CbxsJZ2yK6a7yXrQHTqgu2aeo6JUW8E2KTNfI1G GcVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771318986; x=1771923786; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jjF0dk5KMmp/3IOMF9v7+zo8gHgtNcDNHXPYWCCd6nc=; b=iyDIGtaFlP/mB2F/Poa05JPQu3CzdMD+3LBDQ+1h6c/f6LPaXIGwMHKdMgHnCHZHDF ivqFND1xYs84xeurtfuDyrYqs0KusOGHLn2kyfET4yyGiJ2I1DYjP1Kn962IZ/PavgnU 8Vvqyy4hMG7qKGowpwoclDExM3xp7P5ugSEgjlABVwQBhPUEOc21oprunoOb+/Nv8UtW PpYmvN4tGaNVHdWt02k2ffipwCoropVm9lKju/3+Wbi1Jeh7qxx/Etr/qRNW5YNDAxBE fSECg7++DCr0fEJGOG1LFxWLybk3mpQnT710pCjZK6aNcbDdzR53kle8HhsDOb02UE45 A0cQ== X-Forwarded-Encrypted: i=1; AJvYcCVFVUp2AKvmMWDmSN8k71eIFD5P6hrZc2Ki/SDnRI7LjGA5fWRHWomeNyWNy2X1DGjXf58bR4PbtDzLiWE=@vger.kernel.org X-Gm-Message-State: AOJu0YxB4glsOYia8nc8yKSCynzU0xrZUenJF2gCLcZ1Textl7av78Jn dqhfHfDkgwTiiYR9Q/EcPh3Qfy+kBo1CaZipPruWp1fYwiQ/0/f28prI X-Gm-Gg: AZuq6aJAnSczDgEOGTlC3Vv5LpR1RFovNaSW8o6+ms2IQPROJGq6CRKkg4cLsuZYEYJ 8BdvNNlfPvGPY0+rjTdEU0UZvbsvgGtIsXJNbm96P/AGYVCiNxQnPiXqOsiuItixfy28bwyHbqU RWg5ClGeBrTk/hEEBGvmKUCSW4BE6S6/F1ILOCsODGmpy3dG+Lgm3KU/If75Trcd5QmMLpT+baD w6kAvJRgFPJTk7u1V5bxd1cFm2fKioitOBPkBlegdEXkqDB8pXqRl1/HoEM4FIsdRxB9LNrhrE5 qF53MA3nFH+EEJTeUCgw0HyheYzr2FP56bN11G8ZpH1v8DbcU2gK+UyHOf67CmF6eoQLESWPjqv a2kH/0FOUgq1u9eiho4Db8F5aNTv4LxACpmXTns63wVlVQhO2RI//3Ak9smRDz6rfK03RCUQrPU nM2RxOecvbJRvUtqY7EtdxNT15FlrQqmbyLk2ZJ3a6HmzDop8XgLxJSDhjdd2EtgWNHbcnUJvEB mG5jRYlMEhizezLye7zeh3BbZ3LnIZ83Y9cqG56Tlt00klssqE= X-Received: by 2002:a05:690e:23db:b0:64a:f80a:cfeb with SMTP id 956f58d0204a3-64c21b7047bmr6703455d50.76.1771318985740; Tue, 17 Feb 2026 01:03:05 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64c22f89f75sm4564383d50.11.2026.02.17.01.03.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 01:03:05 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 17 Feb 2026 03:02:48 -0600 Message-Id: Cc: , , , , , Subject: Re: [PATCH v3 1/2] iio: light: gp2ap020a00f: simplify locking with guard() From: "Ethan Tidmore" To: "Andy Shevchenko" , "Ethan Tidmore" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260216005317.11763-1-ethantidmore06@gmail.com> <20260216005317.11763-2-ethantidmore06@gmail.com> In-Reply-To: On Tue Feb 17, 2026 at 2:37 AM CST, Andy Shevchenko wrote: > On Mon, Feb 16, 2026 at 03:04:55PM -0600, Ethan Tidmore wrote: >> On Mon Feb 16, 2026 at 1:08 AM CST, Andy Shevchenko wrote: >> > On Sun, Feb 15, 2026 at 06:53:16PM -0600, Ethan Tidmore wrote: > > ... > >> >> int i, err =3D 0; >> > >> > Would you need the err assignment now? >>=20 >> I'm not familiar with iio_for_each_active_channel() but, if there's a >> chance it could run zero times, then it'd run into if (err) with err >> not being initialized? > > Have you read my other comments? I also mentioned to replace > > err =3D -ENOMEM; > > with > > return -ENOMEM; Sorry about that, when you asked about the assignment, I thought you meant the initialization (err =3D 0) vs just declaring it (int err), rather than= =20 realizing the variable itself is redundant. Will send v4 shortly. Thanks, ET