From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C5E133FE2A for ; Wed, 18 Feb 2026 16:51:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771433520; cv=none; b=N+jFC725sACKENj4nP1gc6Kd4xLdCT+h57sOLmnJFheg419AE81b7OZVzIJhenMPXwV4Z3kypTwOTM/9mI7vBQYRb3CWBMgboDFvblVV8mA+JZXR3i0GcuiGiqtWZbeM84tpfaiZ8hVEvqYcw85ENkOrRIosD+kqrSd8tf8BVyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771433520; c=relaxed/simple; bh=0wfh6o/9oM0zW5ixJ6BV+OPXNxdRC+EFukmsaB6zDFc=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=LmiSt5H//oq/zDugsYWDY9E8Iq6/adDlYzihk2PRr6pXmHMnL+M8QMczOPSeC6JfNwS9P6dFe9raRqvPTfylHXvhLmXjzwU1SN5IsXejjkNdCIg6N07qvC8s+K1Lh6Vzdxlgl5RWSRnlVy6KgOQVjqkw6z7Bh7HSIs5oV3lfgkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=DzZ+cb7s; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="DzZ+cb7s" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 97F261A0434; Wed, 18 Feb 2026 16:51:57 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 5A7155FA23; Wed, 18 Feb 2026 16:51:57 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9052110368B3F; Wed, 18 Feb 2026 17:51:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1771433516; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=q3kKvAtMKyYPFeQYbrwGbLVSY2eZXFval087qSi5JsQ=; b=DzZ+cb7swCI8SLIPEuwHkNsoozJZU54YAOTo3h5yFmhWMepNkAu/9bs48NBM727ltQSzbm SxrVMRCPFZ0ZHymllEQ+w+ffCTtXXzQrML3jbEtYr5bRqBbNvTbakAq0Uc3lF3tVlII5Bx MdUStzhv5BSRnw7KVrQ8kJk0Ptf93J4mHf3nhTwMOioZYtKrMVZS9ByooyIvdYhtMevJHo aal+svhAcY9ADm7jhKroJVxm8wTbSr691w6n6PfS8+OuFGuM6yfiaL33Sv4w28ZRgzu1L9 sce7auUd+y2hX83PzR8gC9NSWUOnoAkN1yd+qKkn1CDymjnSROfn0n4EwdCasQ== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 18 Feb 2026 17:51:51 +0100 Message-Id: Cc: "Nicolas Frattaroli" , "Liam Girdwood" , "Mark Brown" , "Jaroslav Kysela" , "Takashi Iwai" , "Heiko Stuebner" , , , , , , To: "Detlev Casanova" , From: "Luca Ceresoli" Subject: Re: [REGRESSION] Re: [PATCH v1] ASoC: rockchip: i2s_tdm: Re-add the set_sysclk callback X-Mailer: aerc 0.20.1 References: <20250117163102.65807-1-detlev.casanova@collabora.com> <34f61d25-607c-4967-bc67-3c7517c7fe14@collabora.com> In-Reply-To: <34f61d25-607c-4967-bc67-3c7517c7fe14@collabora.com> X-Last-TLS-Session-Version: TLSv1.3 Hello Detlev, On Wed Feb 18, 2026 at 5:01 PM CET, Detlev Casanova wrote: > Hi Lucas, sorry for breaking support on your board. > I'm also surprised that you were not added in CC of the original patch. > > Can you try to keep the patch and apply the attached one instead ? Thanks for the quick feedback. About your patch: --- a/sound/soc/rockchip/rockchip_i2s_tdm.c +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c @@ -665,6 +665,12 @@ static int rockchip_i2s_tdm_hw_params(struct snd_pcm_s= ubstream *substream, mclk_rate =3D i2s_tdm->mclk_rx_freq; } + /* If the dai/component driver didn't call set_sysclk(), simply + * use the freq from the params. + */ The comment is slightly incorrect: set_sysclk() was called in my case, but only for playback, not for capture. You can reword accordingly. + if (!mclk_rate) + mclk_rate =3D DEFAULT_MCLK_FS * params_rate(params); With this, and DEFAULT_MCLK_FS defined to 256, arecord is working again. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com