From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEE3C33120A for ; Fri, 20 Feb 2026 11:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771587100; cv=none; b=m9ndPFyDa/0xIvc2hgKTX3qi/MitADrTJuxVjoT9hrEemdZc85QmDWVckJhpCpYmi3pfDyUG2iWYbTDmEesWpmEzbxLBplWcqgGV51yJBlWg0Wd4g6zJD9xwsWXxx/UWfmq+Yg2ZejpCaq4a8ztvdH+BdOqorCBj9b+hzMUeK/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771587100; c=relaxed/simple; bh=dL95nES1PvUKDwOE/SzRBysmIFe+L8zYNyzvl+l8sDc=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=EopmXWDZg8ntju/7MMuHxqb+fRK/xBeoX8tnTozTkuielx9tkYehw42WTQNSZpRBLJfJ0QKCTPfD23PgwDYrOqXfA8plLYozTni8GFJoIh5oZTRDYmwaRj4uet9v2vAHUHSXaCHth7ESNUQZ9Z3scg1MKlFmLD+xfbMkV32d/so= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=4NHgTx+s; arc=none smtp.client-ip=209.85.218.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="4NHgTx+s" Received: by mail-ej1-f68.google.com with SMTP id a640c23a62f3a-b88593aa4dcso279904266b.3 for ; Fri, 20 Feb 2026 03:31:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1771587097; x=1772191897; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EGfuKGhv7t9katQ89dFkhDx2tsJCNlvP9HCnVuHq6Y8=; b=4NHgTx+s20DfwneSZjvrzDD9fpZEe4W9UVaWa3uDZd2yk7x5f4ZTJ2hrX1qyF0rwc3 mE2i9g1k4aAN62huoSVqZQQ0r+G0luFFPtWcpI3zpUy3sCk0XoB9SbVEEucFQx1a3eRc Dz6UavddF+3GheXjgWPgfRWV2pfEF15PH6fVPFZMIJD8GSdjbbe0T0QISnMvY2UcFX9H 8wwW35tTTD4Lla+gGXF8YhCQikEEAYZBtyHNLPko8J1VOThanka0vu46lcMm9DLdrou3 YThe8BJzfkBGvXdHdirakJDZ+hY3fmjrKml4+DGyFks7S5wc1vZyjSbr6c5Pz0jZAUil qQlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771587097; x=1772191897; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EGfuKGhv7t9katQ89dFkhDx2tsJCNlvP9HCnVuHq6Y8=; b=q5GMFiYa2osE66HhVxyzXc5lsyJ6u8usCvsv2ZilZcvzMKihLampdD2mjehPJkYHHO NNbop6OA5KHJFGJ/FiFxn7rnMNjO6HgghyATe0roN9Q/mas537N43VHr9FmpjYeGoXIA 1tauiFhD6GTnZ/ptbG2Uw2GugyYrMMoWFQtw6sN4r30E2c2aHitdaU0xPieI6Vx+VKdL u1o0xQTTDfP3ogcNPcEX7YCsawOf8UelvyFZokek6d90Degn3OgsY/8QsbG5TfYz5TvE hcTDqnDBi+J2ie/OPPKjmn+lRx3FXy2Wl2xjNRBF1oQ8N1ZgjDvBCs1JOkIU2h/ZPYM0 C47Q== X-Forwarded-Encrypted: i=1; AJvYcCWAPRohmbPAvxGNMxXHwgStgWYHOIuwT7jxnr+MuRnY875J9zrfJkhmYUftLgribzALNOqckIDctPehsr0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0ZVbTOryV0vRYOOA0814x6Bsns2MeGVn1Lmxmb9ifaEYTjXHb OEJzvl6CBtH+IIaF1bzniClXK2+wZT7UOJ2bpoFFa118EDrGQhqywH0vLayqjH0lFfw= X-Gm-Gg: AZuq6aKOsQEgnh0O4UicMoIw89WyMLB1s6UtqkJtOeqL9F2xpvCA56qHTEGK3uy4xXl ifHMUFQtWdECKGhhj3oix5VSsHk0BaBKXHb732Bkb0HWCGbGmUupoI7pfUB8QmzPgBPiWPtdFPc uKpuPXRabR1kOomumXkQY/etBJiIX4SzXvljrZxTvk6hgVFwJWa+1q4t/FEPWoK/IOIe/kh6kpJ WIktLWKOIEUzxW+UdqZxF5k/9VK8y/TtjKG9RQvPUj7B1q6AtFD+aEzIwxco96LVBniDnpwyG2M R7h4tAcue7a3rnoHhc+BKDnREn6b8rH+tFKsx8i8XBGoE88bnVCGxxopPuSk741agl9Pvduqsh7 akOr8+cJnNZW+SQYxrPZfogM90mO80bXAwNiXPv2lcVUyHtz53iULvYVsH5wqx4ayYIosWg7cFQ I4gR8vit12eJrUTvdMV8tWI/8/S4G3Mz9uRmoECPTnXJlKjA+ekTTc0LKhFZ0e3x+F+bTJ X-Received: by 2002:a17:907:728c:b0:b8e:8874:8384 with SMTP id a640c23a62f3a-b9072e1eb1cmr91962966b.4.1771587096917; Fri, 20 Feb 2026 03:31:36 -0800 (PST) Received: from localhost (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc766531asm666569166b.50.2026.02.20.03.31.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Feb 2026 03:31:36 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 20 Feb 2026 12:31:36 +0100 Message-Id: To: "Andy Shevchenko" , "Luca Weiss" Cc: "Jonathan Cameron" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , "Rafael J. Wysocki" , "Daniel Lezcano" , "Zhang Rui" , "Lukasz Luba" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Laxman Dewangan" , "Bjorn Andersson" , "Konrad Dybcio" , "Hans de Goede" , "Jens Reidel" , "Casey Connolly" , <~postmarketos/upstreaming@lists.sr.ht>, , , , , , Subject: Re: [PATCH v2 3/5] thermal/drivers/generic-adc: Allow probe without TZ registration From: "Luca Weiss" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260220-bat-temp-adc-v2-0-fe34ed4ea851@fairphone.com> <20260220-bat-temp-adc-v2-3-fe34ed4ea851@fairphone.com> In-Reply-To: On Fri Feb 20, 2026 at 11:50 AM CET, Andy Shevchenko wrote: > On Fri, Feb 20, 2026 at 10:19:07AM +0100, Luca Weiss wrote: >> If the devicetree node is not referenced in a zone under /thermal-zones, >> devm_thermal_of_zone_register will fail with -ENODEV. > > devm_thermal_of_zone_register() Ack > >> Since the driver is now also registering as an IIO device[0], allow the >> probe to continue without the thermal zone. > > Isn't it dangerous? Why? The idea is that generic-adc-thermal is the middleman to convert from one IIO input to one IIO output, and is purely informational, so that user space can get some temperature value to display somewhere. How thermal management will be hooked up in the future to charger drivers is a bit out of scope here I'd say. There's not even any cooling support in the power supply core anymore, that was ripped out a while ago if I'm not mistaken. > >> We also can't use gadc_thermal_get_temp anymore because we haven't > > gadc_thermal_get_temp() Ack > >> necessarily initialized tz_dev. > >> [0] commit 3762f5851ac5 ("thermal/drivers/thermal-generic-adc: Add tempe= rature sensor channel") > > You can make it a Link tag: > > Link: https://git.kernel.org/torvalds/c/3762f5851ac5 [0] Ack > >> Signed-off-by: Luca Weiss > > ... > >> if (IS_ERR(gti->tz_dev)) { >> ret =3D PTR_ERR(gti->tz_dev); >> - if (ret !=3D -EPROBE_DEFER) >> - dev_err(dev, >> - "Thermal zone sensor register failed: %d\n", >> - ret); >> - return ret; >> - } >> + if (ret =3D=3D -EPROBE_DEFER) >> + return ret; > > I believe it's better to return all possible errors. If you see the > similarities with regulator APIs, then use an explicit check for -ENODEV. Sure, will update this. Regards Luca > >> - devm_thermal_add_hwmon_sysfs(dev, gti->tz_dev); >> + dev_info(dev, "Thermal zone sensor register failed: %d\n", >> + ret); >> + } else { >> + devm_thermal_add_hwmon_sysfs(dev, gti->tz_dev); >> + }