From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f53.google.com (mail-yx1-f53.google.com [74.125.224.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55F4A2192F9 for ; Sat, 21 Feb 2026 18:45:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771699519; cv=none; b=gg41LSsX3Cw/yfcpUqrPvURwMGWt+ZbYs/wgs86WinQtRSUuUnj6E5eEabGSQ7JVhLvRvJl8xLcV3GXiaxYh2D+xm6SWB3lIRctmhzxo/eTS49WEw2SNDU8u/krUDaYKcZ2tRXDoYxEni56itbqCpcglrFwE9Nt0sPpa+imJ90Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771699519; c=relaxed/simple; bh=qRPMy3Oymb8z6om13m/l6bzS2mXVu8gCGIK0f9mb+Zs=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=CPwzvEHz3xW0w5syN4s9VSfpmfwlfKo+vv2ncWhh+Pxeh16v2/2enn1mVfSlqtHoBVUPeLxpgeBtpA3ASZvLH6335nmpMOf++ckWMDaoEiwi9wrpcvUotiMzZwx8o5Dbj6MO2u6ZCQsGaiw8uuTwdaPk68g4dkY4yjphkXBoyy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TMCYP00p; arc=none smtp.client-ip=74.125.224.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TMCYP00p" Received: by mail-yx1-f53.google.com with SMTP id 956f58d0204a3-649e456e8a2so2550377d50.0 for ; Sat, 21 Feb 2026 10:45:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771699517; x=1772304317; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qRPMy3Oymb8z6om13m/l6bzS2mXVu8gCGIK0f9mb+Zs=; b=TMCYP00pNjOVaztMZddK3vJLPhxZHayB2tzZRuH1YAwL2aTP44bjdgvUTAc0iFJHX9 PpvDzLgiZfId84/quap3FibdzK2qBK9iDIuy+d545WVaWubCAunkzmdhF46m11C8Zlzj 1G4mnH9r2vo2YyobHytTAQkbzNlze4twiLKXT3Vt4pA7AUbi6UwE8dK8KxctjVPThnRt D9Jkqo/9eLtYgBuCP3LtwfTwtMjHrrmXajT3KvQWnpAoq96mVDhLT9VKIrTtIT0t82yq 1v7SJGq/4zPM8j6CV1qfSEv5wBebWMWxnMSUnCc8s1t3UYMRdtRjySQUQ5vA2iCwUY6r SsYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771699517; x=1772304317; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qRPMy3Oymb8z6om13m/l6bzS2mXVu8gCGIK0f9mb+Zs=; b=LigS3TulmwUUVTc6Nn4ii7BrD0VLISNEOzUtA8IFltWnf6hAZQOWFzOBK1iEaAcJvq jqTi777j3vDIMGD04mLtm1uhr/PiO79w9UvxyswEjDiGv5mluxWicwwca1i3SK0CBzEB pt+uv16N1Qn0G0lCNnWNbOVeBPR9VU8duyhWXWkbHw3PnaOES6kituVnnSz4mRhZ/Jht TPilIDH7QpaCOasIaKu3n4MZK3jQxriXF0aLVQu5fClWN0OVq6TwNpvL6s/JCzzXjwIA e3ZuIrEUR10M31pmX1s3OfQ48VCe29Wpf+Nz7Zj1n8LWidXQRx8bTuZZJgBKQwEG/qh1 0d2g== X-Gm-Message-State: AOJu0YwEvX4d6xvTfDDtEhQ5M+DBMKotbBu1j8APCrf0nnBvjGaJW5bw aPNUFQJmwkb+/IdJzlh8YZj/4Bbzj8+kJxFsbS4g7Cthh6z5dwqUFrIl X-Gm-Gg: AZuq6aJ/0Ca1+A2PsBIjemezXUUQYK8fibmF5+MMHLRHLDPTst+wT5pacMu3ZEFxINQ g2YjKMEszudC+lVMGcLZG2nbVhJr+b52NNp4daYa15H9CNrrbL1yOAss3v68JYBHDM97c6jhUA/ Ag67ZpGvWePIKO0gTvwMg4k603SN7f+lxxLpIXdO5GCxXX2GgUKSYgIBq6HnJIVygOJXj4wB5id mHuG8eruspL5ExWXEuwocneJ/OFx20BMtIzKiPxO4hz0oXqLAiDOrZJJG1trSSnjEQLg7BhWjIb 2Gl4P5a6vpbWQraMpCtAEqY41WmhuLWR3QYWRTgyg9/pcx15CwYvVdOk4+CNREhOsq2FpzVZzsK USKr2ntWgfjPY7EgKX3m1H8thaMVNDqrGNfBghANeP+RzUDmGhCJmbBpzulVtPN7LgPMsuXX9Xa k0tuGfMwQ3/CNxoAu44Vz5KHtiZe45AC6jgDRw04HHZI+IgvXc/yevB7DPGGQOrshNZoaFz5/zY PaBBK6vlzj5udfYbWBIU6SJs81XMC/H X-Received: by 2002:a05:690e:d1:b0:64a:e7e0:a70c with SMTP id 956f58d0204a3-64c78f66569mr2674110d50.65.1771699517255; Sat, 21 Feb 2026 10:45:17 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64c7a35dd56sm1253754d50.15.2026.02.21.10.45.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Feb 2026 10:45:17 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 21 Feb 2026 12:44:58 -0600 Message-Id: From: "Ethan Tidmore" To: "Giorgi Tchankvetadze" , , Cc: Subject: Re: [PATCH] staging: rtl8723bs: remove redundant NULL check on premainder_ie X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260221124732.327156-2-giorgitchankvetadze1997@gmail.com> In-Reply-To: <20260221124732.327156-2-giorgitchankvetadze1997@gmail.com> On Sat Feb 21, 2026 at 6:47 AM CST, Giorgi Tchankvetadze wrote: > premainder_ie is computed as pwps_ie + wps_ielen, where pwps_ie is > already validated non-NULL earlier in the function. Pointer arithmetic > on a non-NULL pointer can never yield NULL, making this check always > true and misleading. Replace with a simple check on remainder_ielen. > > Signed-off-by: Giorgi Tchankvetadze > --- LGTM. Reviewed-by: Ethan Tidmore Thanks, ET