From: "Gary Guo" <gary@garyguo.net>
To: "Andreas Hindborg" <a.hindborg@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] rust: impl_flags: add convenience functions
Date: Fri, 27 Feb 2026 14:20:46 +0000 [thread overview]
Message-ID: <DGPT710WN25X.1B9P21BE6X8P4@garyguo.net> (raw)
In-Reply-To: <20260215-impl-flags-additions-v1-0-6538c8fb841c@kernel.org>
On Sun Feb 15, 2026 at 8:22 PM GMT, Andreas Hindborg wrote:
> Add a few convenience functions that makes it easier to work with the
> `impl_flags` module and C APIs.
I am not sure that we want to encourage direct manipulation of the underlying
bits. Adding these impls would add a surface of misuse.
Best,
Gary
>
> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
> ---
> Andreas Hindborg (2):
> rust: impl_flags: add conversion functions
> rust: impl_flags: add bitwise operations with the underlying type
>
> rust/kernel/impl_flags.rs | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
> ---
> base-commit: e9ec05addd1a067fc7cb218f20ecdc1b1b0898c0
> change-id: 20260215-impl-flags-additions-0340ffcba5b9
> prerequisite-change-id: 20250304-feat-add-bitmask-macro-6424b1c317e2:v8
> prerequisite-patch-id: 05dfcf648017dee65c356604e4f99959e76ff64d
> prerequisite-change-id: 20260212-impl-flags-inner-c61974b27b18:v1
> prerequisite-patch-id: edebc37750dccd8d19db0b8fbd5f69f9877675a2
>
> Best regards,
prev parent reply other threads:[~2026-02-27 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 20:22 Andreas Hindborg
2026-02-15 20:22 ` [PATCH 1/2] rust: impl_flags: add conversion functions Andreas Hindborg
2026-02-15 20:53 ` Miguel Ojeda
2026-05-12 8:05 ` Andreas Hindborg
2026-02-15 20:22 ` [PATCH 2/2] rust: impl_flags: add bitwise operations with the underlying type Andreas Hindborg
2026-02-27 14:20 ` Gary Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGPT710WN25X.1B9P21BE6X8P4@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®