From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 017AD39B493 for ; Fri, 27 Feb 2026 21:01:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772226082; cv=none; b=HCAM7xS+/NVfYHDpwdfgduGCZLcWciDtAbIaiKQmRY5avtv5LMP7Y9C/CEhbVEFLN9PQGUhkVlxHwN0pbwZHn1Zi+JAcFr/015XM40xmOJMipAyMx9CQR7JXAGBUIS9mqSWczAlkW5D6tRlw8JTBUQLIgoM+C7w5OYZKmC7y54U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772226082; c=relaxed/simple; bh=vdDqUyivuV8XLjk+WDs27cGBDt1Lek9IwEgcJHBHyno=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=u+NYx7SaSBrl2HrknWUANc1tPvZB3FobnSTvmvvzWRMHbhA6k59fSoRsXd5axArmPyO8BFa/xqhFbgDRUXgTbcu+2octYiyzcml34Ot/tKvzsc4tyaUKkyjsaxNpnG4H0xNo2n41199S3GJn/hRpT+TkgCNNCKIoJqdMDI3616g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JnBS5893; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JnBS5893" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-79860421382so23768907b3.0 for ; Fri, 27 Feb 2026 13:01:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772226080; x=1772830880; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=y0bOhyb0fW1G7j5i9rV4AgL3SS1nvIR3OgIOFnRzk6I=; b=JnBS5893xbdMY5dSRRfPKkd/2MT7iolptMM6NCm6pkv0jLBJYeLiVbPHHUld+lMiaC X/TQfB5CSc9qO5Hw1unENa4JwROqAoDhzT01l0BPMu3jpNFmdeQzrSBnUAXd8TEzVIPr pKDsb0YWr8qIQ8OIHuoY7kJih6XojEsZF/jR/2oVs62fPecO6RqdHtHwfMyUmmyT5ryo 4KocVuHDs4nrtZX3CB45gU3Eh761WtoDPFsncQgnura62IIDPf7wDbHsv+Ijhw/9EtzA fys2Aw3PTuv96W4eGzVRaz2d8QLOy55Znmwf7MXmZ6co3+ujQjqDQlD/ykRz/v/vT1VD EGMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772226080; x=1772830880; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=y0bOhyb0fW1G7j5i9rV4AgL3SS1nvIR3OgIOFnRzk6I=; b=waWnbiHY+XADgKlOWpf6Prp7oVL6zGPAC/RMWfQX+P8D3U2PMsbxeCw6I6lrWYv4DD QW7hwyMBYfT+y5+5YOgqN+0NPX0xOit2WSXSiYdhmXdNndECJxJojSL8N/sGFElXu2Mu NZMggbFeMWtcuSGqNJ6/D5tR5q1QISvR92q5xKq7WU8eM8x06tOT46F1rQPiKgqVc25S 3KKdpR2/mMsrtqtilsHhx9hYjqs2h2KarkVG4nknz51N9bm5hSubCwj67RQtGUap4Z6f M1ODUlhSONM32T9xw7VD4w5k2bwVjWXwy1258XN+NkOae8zDcqo6Q1Ri/O1QpPkGTk1S Y23A== X-Forwarded-Encrypted: i=1; AJvYcCVr5k3/iMR1RIJ+34TEEsj2QyHjiGp4zKBc6Ztg/IM87u8ov9GnF17qRmPLG2iakuDlMMDGMS21z3NvQMU=@vger.kernel.org X-Gm-Message-State: AOJu0YyuyceVXrlY3oVFiDPA+l9IBsv4RYT9fHPKjxRuQY2eaY83DlVs hPPb069nJhNknVxnZhzneoTg0pfvkPjjETofOyWg25Cj+e6py2l107BC X-Gm-Gg: ATEYQzwmiIp2mDSyyi4nes9RoaPXhQq1E/uPFbtARPvYn9cguR8o3fO+XJW+vQq0T3o 4xjYTzt15GgN4g8HT++cTCLJROuofbXYCY1mYwu6bt43c+4Ef/ekR0FWWnFjT3g1nKgwMGEZL4u ixcf5L5iSSwXY5tcB6ib8lIHTRb8Vl4semxRtcfnm7NKqXG2ZMIaTMcpa720YPt+yEOCrh04d6l Gx1u7XguW+yzAzmCrbkfNkbyswI79D+4V6KlUjdRwJIO5bXm7qKPEMWYN5Z0AyYtG1jBy9IXLUw p5JRMdC5LfmGpdh56agdc8vo7Y2zUDk9wkEwMPqDaGZIvfgkzn1dML+ORbqHzZQ1hTv8Vpxg/dd +53PesZYgiSVj9sgdT9pmNAIx7pZ1UlY+7V+8h6M3RbdhvRY41sjGS3DumBucW1O575/X9pDOg7 P9PCP6aUMG7yh4eXFj+QGIqLn5iuV3eI/+fT+vYidRJNfDG9ak1A3i2oPSQxU5PjAEPBLIgDA/X 594LBXokox3KpS2ZQ+lapUo1/oe0RnY X-Received: by 2002:a05:690c:6610:b0:798:6d23:17d3 with SMTP id 00721157ae682-7988564c5e3mr38210777b3.61.1772226079804; Fri, 27 Feb 2026 13:01:19 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876c47f82sm25399807b3.36.2026.02.27.13.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Feb 2026 13:01:19 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Feb 2026 15:01:01 -0600 Message-Id: Cc: , , Subject: Re: [PATCH] pinctrl: pinctrl-pic32: Fix resource leaks From: "Ethan Tidmore" To: "Linus Walleij" , "Ethan Tidmore" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260224202846.2437400-1-ethantidmore06@gmail.com> In-Reply-To: On Thu Feb 26, 2026 at 4:37 PM CST, Linus Walleij wrote: ... > Can't you just use devm_clk_get_enabled() and let devres do this? I thought about that but wasn't sure because I saw: ret =3D gpiochip_add_data(&bank->gpio_chip, bank); Later in the function and knew that you're not really suppose to mix manual resource allocation and devres. Thanks, ET