From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22636309F19 for ; Tue, 3 Mar 2026 13:46:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772545598; cv=none; b=nKicCtaXsxfvF0kztubLuESvn4HaE2pmbL3RaE8F2E+/DvSzc9CVe/eHtakawybz3y2ljF4uxdvI4G+6CEXCQgHzJj+wNxmLEaX5AGO/V3Zj2f0bmZBmfixzCPA2lTmrUNo39VhtFPHAv5VHL991UGcBSTaGC2zMjN61O0+ocdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772545598; c=relaxed/simple; bh=tziw53490D9dLBPgoajUHk6E3hNYGEt7eHXmICjRHUw=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=bJWHjABUMh8F32fKPrR96OYmJtIoKJlfwuc+8dqjTbpbO7IJP065NxnykY2WYcMFgzho/n+gWz8LWZU2A9KqwbZwLBKImsspQDcIaSQVKBH5snXoh7DhWwG77InEWaDFCbfTnNoc1QmDahtdzS0Gqpgbc1dToR8LG3qp4VitMGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=J4/2zGuw; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="J4/2zGuw" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id AE3C61A2357; Tue, 3 Mar 2026 13:46:35 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 822595FF87; Tue, 3 Mar 2026 13:46:35 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 70C2C103695E2; Tue, 3 Mar 2026 14:46:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1772545594; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=XDRpvBtYzC34KJ2LgpsbI01brcrkDd6rfNwNv6anEv4=; b=J4/2zGuwaWqYyv4I21zejYDFYxBN3Fgy20I5xGwVPpjl9rTCySOIPU1yAmxpx6GO2LYyWo YvuF9uPEme6AhEz0Vvi8qsfc7T5TRUg8upSniC3XxWz8DnQKwwQUrof8aF2+ZU1w3bpPbV 2nVnd1EW0elrOOUtsDxqCyrm6DpShSOORtOfYxT/MLmeYWuOPn0iHWFbAlTyHX1xVu0IIz C3DAtx3GG3LpKZE5RycUx0GGBSTf4Uyg9X9Q+Ky9LayNVrIEn6q/ZlRH++TuCsDvlFcw78 pfCLugJLBnJN1lcYW8pM5ADAEKGqzx/tA2xPrDKkIwTesFYKPtRA8kDO81dBfw== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 03 Mar 2026 14:46:31 +0100 Message-Id: Cc: "Marek Vasut" , , "David Airlie" , "Maarten Lankhorst" , "Simona Vetter" , "Thomas Zimmermann" , , To: "Maxime Ripard" , "Geert Uytterhoeven" From: "Luca Ceresoli" Subject: Re: [PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value documentation X-Mailer: aerc 0.20.1 References: <20260115024610.661624-1-marek.vasut+renesas@mailbox.org> <20260303-uppish-finicky-mustang-cd135f@houat> <20260303-delectable-just-clam-d25e08@houat> In-Reply-To: <20260303-delectable-just-clam-d25e08@houat> X-Last-TLS-Session-Version: TLSv1.3 Hello, On Tue Mar 3, 2026 at 9:39 AM CET, Maxime Ripard wrote: > On Tue, Mar 03, 2026 at 09:14:53AM +0100, Geert Uytterhoeven wrote: >> Hi Maxime, >> >> On Tue, 3 Mar 2026 at 09:07, Maxime Ripard wrote: >> > On Thu, Jan 15, 2026 at 03:45:53AM +0100, Marek Vasut wrote: >> > > Update drm_of_get_data_lanes_count_ep() return value documentation >> > > to match the drm_of_get_data_lanes_count() return value documentatio= n. >> > > The drm_of_get_data_lanes_count_ep() is only a wrapper around the >> > > drm_of_get_data_lanes_count() and therefore returns the same error >> > > codes. >> > > >> > > Fixes: fc801750b197 ("drm: of: Add drm_of_get_data_lanes_count and d= rm_of_get_data_lanes_ep") >> > > Reported-by: Geert Uytterhoeven >> > > Signed-off-by: Marek Vasut >> >> > > --- a/drivers/gpu/drm/drm_of.c >> > > +++ b/drivers/gpu/drm/drm_of.c >> > > @@ -539,8 +539,8 @@ EXPORT_SYMBOL_GPL(drm_of_get_data_lanes_count); >> > > * >> > > * Return: >> > > * * min..max - positive integer count of "data-lanes" elements >> > > - * * -EINVAL - the "data-mapping" property is unsupported >> > > - * * -ENODEV - the "data-mapping" property is missing >> > > + * * -ve - the "data-lanes" property is missing or invalid >> > >> > I have no idea what "ve" means in that context. We should rephrase or >> > pick something more obvious. >> >> "-ve" =3D negative, "+ve" =3D positive. > > Thanks! > > My point still stands though. I also stared at "-ve" cluelessly, so I vote for plain English too. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com