From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7128B27FD74 for ; Thu, 5 Mar 2026 03:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772682534; cv=none; b=DqRLcqj+syTjYC9eDAcmj4SX3iFbfe2RqHZRwiW+uCg77X4FxuNBv/vcFwaLPy00srNNw/EPlv4CtxYCqV5wtYaivYHDTkFeYDtcc+exyoFPk6BzGxB6c32PxiKly3zU9VZAQBKQQB2XZah50oAxpoNYr/+kTR4NFTKR24UnRIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772682534; c=relaxed/simple; bh=jx3lwOAjNIKx1JbYIv0BtRGFivcMlAcPGHDzLTlQtjI=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=SCgMOryzPdeX2uavFQg20bZ7oxYybpEvRLrWz+KnKsojd46r2fbg0f3saBRMdr0PZoiw0fIwQak6VAz6m1vYyW1c6X2sff2EfuYnBgiCzGIolkFMhS1qbm0MFPAo1pJFVD7y27JdA36yDpKnZE5UjTAhz9+4nuWOPq6EbrD6ulI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gjkivRK4; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gjkivRK4" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4806bf39419so62342385e9.1 for ; Wed, 04 Mar 2026 19:48:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772682532; x=1773287332; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=m/oY6Lj6y92CrkHBsRn24dqJ3yooac2+GrQjHYegtCQ=; b=gjkivRK45AnC9Igxx9p4UKj/JvRH2NABuOGwO1JRqKryKPTFUtSe3GgBRfcXfto3xz vtV9e/gYP+mfUsoxeRJHCHinrSINtxgicTgnExJLvP74okQV22U3K3HQETHR/nT7F2xc 5Wfm+Nj+DMFqTAzAY1qgRwunnQOJKwPeaJ3K60xRu5bqIEodp5P8hLfuYsoYJP98PhA/ eSxevyb6su59LR9lQtRKwH2OpTVNREfzXDo9sPI2qBbNLXITFFxEl5m+3FfMqMPiA/3C InYubynMqSHsoiDH7lti6q9DvCX0yg5VLOkvf9nLQQCI0kJhW72GVzgpwCEldzW4DwJI QX/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772682532; x=1773287332; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=m/oY6Lj6y92CrkHBsRn24dqJ3yooac2+GrQjHYegtCQ=; b=uLSunp64vfMkNuEijT6VyHzjgIfofqt/UUBY7zvkcd4Es+dIqiiOAWRNY6QFH77f1A xz1xD/ANIEuZaFP3qnTrpT07ShrCqWvFHseX8c4XngEyNCRWDn8iCYRqqMtD8sgPIA6J NjZXCKNREArq6F4qClVAUy8RdhKJAv7LcY0EYx/utW8P1ekPNFUxlquLjuvFR//2VAkB NaqIHYlkswLHDjoUlTVj9DWD8WbzE64x1BBgMRit7waPKc10cHdsOmXITKA3saFtvmIC yNpbdwgDOlTOvpAFOJ6ybMa2pDjRnr+jc4GfahZpMsoTX1IW2phqb1jDopMCeAjuZicV BxSA== X-Forwarded-Encrypted: i=1; AJvYcCUGAi/lk4y8GXsoDnCDPe2IZKigzpS5jISNB0MoS8dCa0pgQSxgr5Hr/fH0dMTVgOSFX5a0dZ8kSHdMIaM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyo9k1jv5KlOXtW7gwuXSXpXnm98bXlpsjYGFA47uwY14OZa0nX 7TFs5IZ4hO53dI+M3jEI5ALt7wyllf+Alwt8b04WwEOQo2hsyAmlUGlXMH+bJQOT8Oo= X-Gm-Gg: ATEYQzxiVCdcXhk+vyd1bTdT2KrPKGL/4hxytzvKCQrJIUwIX877lpNtWDmAdBzGO9/ Cam0BC9cP8TjCRGiMQWhQHWpZ16z1nuaOb3K5yEmoX9Qmm5BLczEZSdfwVv+/nKAgxllm6aiMAq pkBDZ+O3TjDnotDfsKTKPcpKVUiBP49Ehev4JjrSpnHB2XIpBEnKC7a/k1gOPMStE5QrtHCjvWV h7B2eD0N02BK5/UChJM2T9Z1MvYJlNEnRs/pWxSyOHNI1G7Ar11fTahR8hhy1Y5o/U7P3E7wpjn HFIlepRwzS2K1+m2xxqnjy6KnIY/4I3k1xYvbSi+2MpXzEk1Wm7vDIjyvfezJcGSHiQToJuhE4c mC6/acjAm06Ny9htNf8UnVY8xOW6pakuPAaM0GjlWjP4M8iH9GrifWHygxKAO0cRN1TAyvhq218 8EA+kuX1yzBL29oJqHvMgAQOYxFzjv7IPLyyosFFDDOFVq+++zPDtoCYmyW3ITvR9dUrCqyTsBs FQy4CcBZ+gvZ6B23Q== X-Received: by 2002:a05:600c:a08b:b0:479:13e9:3d64 with SMTP id 5b1f17b1804b1-4851eea3fd6mr10898135e9.15.1772682531768; Wed, 04 Mar 2026 19:48:51 -0800 (PST) Received: from localhost ([2a02:c7c:5e34:8000:7406:79df:b00c:2c64]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851fae02a8sm16711195e9.5.2026.03.04.19.48.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 19:48:51 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 05 Mar 2026 03:48:49 +0000 Message-Id: Cc: , , , , , , , , Subject: Re: [PATCH v2 1/7] dt-bindings: thermal: Add Google GS101 TMU From: "Alexey Klimov" To: "Tudor Ambarus" , "Rafael J. Wysocki" , "Daniel Lezcano" , "Zhang Rui" , "Lukasz Luba" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Krzysztof Kozlowski" , "Alim Akhtar" , "Bartlomiej Zolnierkiewicz" , "Kees Cook" , "Gustavo A. R. Silva" , "Peter Griffin" , =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: aerc 0.20.0 References: <20260119-acpm-tmu-v2-0-e02a834f04c6@linaro.org> <20260119-acpm-tmu-v2-1-e02a834f04c6@linaro.org> In-Reply-To: <20260119-acpm-tmu-v2-1-e02a834f04c6@linaro.org> Hi Tudor, On Mon Jan 19, 2026 at 12:08 PM GMT, Tudor Ambarus wrote: > Document the Thermal Management Unit (TMU) found on the Google GS101 SoC. > > The GS101 TMU utilizes a hybrid control model shared between the > Application Processor (AP) and the ACPM (Alive Clock and Power Manager) > firmware. > > While the TMU is a standard memory-mapped IP block, on this platform this ^^ > the AP's direct register access is restricted to the interrupt pending > (INTPEND) registers for event identification. High-level functional > tasks, such as sensor initialization, threshold programming, and > temperature reads, are delegated to the ACPM firmware. > > Signed-off-by: Tudor Ambarus > --- > .../bindings/thermal/google,gs101-tmu-top.yaml | 67 ++++++++++++++++= ++++++ > 1 file changed, 67 insertions(+) > > diff --git a/Documentation/devicetree/bindings/thermal/google,gs101-tmu-t= op.yaml b/Documentation/devicetree/bindings/thermal/google,gs101-tmu-top.ya= ml > new file mode 100644 > index 0000000000000000000000000000000000000000..b09e1ff5d89194b570810a042= c75836ca2e53950 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/google,gs101-tmu-top.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/google,gs101-tmu-top.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Google GS101 Thermal Management Unit (TMU) > + > +maintainers: > + - Tudor Ambarus > + > +description: > + The Google GS101 TMU is a thermal sensor block that supports both dire= ct > + register-level access and firmware-mediated management via the ACPM > + (Alive Clock and Power Manager) firmware. > + > + On this platform, the hardware is managed in a hybrid fashion. The > + Application Processor (AP) maintains direct memory-mapped access > + exclusively to the interrupt pending registers to identify thermal > + events. All other functional aspects - including sensor > + initialization, threshold configuration, and temperature acquisition > + - are handled by the ACPM firmware. The AP coordinates these > + operations through the ACPM IPC protocol. Is it Google TMU hardware block or Exynos/Samsung TMU block? My understanding at this point is that ACPM interface, ACPM protocols, etc appeared on Samsung SoCs before gs101 (maybe even before initial SCMI prototyping). It looks like ACPM firmware, communication via mailboxes, TMU channel, dealing with TMU behing ACPM, etc are actually a standard Samsung Exynos architectural feature, rather than a Google-specific implementation. I can't say though what was the first chipset where it was implemented. Given that this is a Samsung design that predates the gs101, would it make sense to use more generic name for this binding to reflect that it is Exynos-derived? That would save us from generalizing things later (if it happens, and I hope it happens). I was thinking that name for this schema could be smth like: samsung,acpm-tmu.yaml or samsung,exynos-acpm-tmu.yaml or whatever works. Thanks, Alexey