From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010012.outbound.protection.outlook.com [52.101.201.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D67F7E0E4; Fri, 6 Mar 2026 01:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772761820; cv=fail; b=QC3gOibWCYB2BFpgq6BAeJ52LwQVQ/95S36eUGGuSwzCkQR3udmePrMCfTWtAm+Ys6MRmGcnV2PqAjl+VpK7E9TtMGFOa1GqMyc1YXRvHOnRY0zw61MMDIlmBrQMonbjllhUVn0P6ZvU5U6CZfaMtIc738nm/pu2l1yfoaeSBw4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772761820; c=relaxed/simple; bh=t0rLJt4S4LJQaS0lWd6aiAFsmWP4cRVd1NNHcI1KaOw=; h=Content-Type:Date:Message-Id:From:To:Cc:Subject:References: In-Reply-To:MIME-Version; b=JT+v7it0r1lxnn07pfCGkUnlic1jfxiktmHyJZ1x4loHLBulGefUBQ00IRdikvQRgnef9m9u5t8zTO/S7MUZWEdI5Z8Eem9wDt+WyvPwN7X1y8seG8byEPesLqxcgwpmdJlLDYTvIhFByH6Sz+1oGJElg1c0lOSlocPSEq/DFLI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=MNtTQNyB; arc=fail smtp.client-ip=52.101.201.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="MNtTQNyB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hvCBA9n5oGQTYq0h5lVy3Sy2B5z5MnluZzPPJYNgsRrRgaYaklbZ0YqdcCL0qlVP6rbPRyW4iiSUU/WdC991Ia4anD6NLEdPSrjghn4KvQjoG74N25i6Cwyn88nlMdw5IbvTk2Ji1TJDkGPl2+Rm2LC5H2n1NFRHuDz3y7+5x9u6sw1Z+HZkemQmKaOt8medhxcJ6g0pGoDzbdQX1YidPS8gsRJjIUBYz9XKvjYkslKyvbRnt/dLBzv5W5/scrjuofBMtlb/iYu8YJh6hgcJ1uT+jDJAeGL9+3Qthr99ApUYWq8YazVTMw0Zg3uFxxkEnkt/mdIVwmxshSugfs0JGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VqLuzLLaBFt7hSKbK4c0DFUnAp3WNjiFgSJBcASVufs=; b=uyLhnJvTuEHCuw2dNoPX97EWibcPA6eJdcO8Vis7K1St7MERiEWhovnCF3Uho8o/3yMhaodpTg+7II1WAjoGSTVfqAT6oLZWu3rcES8dYjWvdaHfePPQN1TVXhY1i1AIkH9ljRteB9h+B2+zV0tYXmbDYPooTnQBu7/TE3/YDlirpCrEZ5tVP6ZPW7ZkrVHWyBHkxQLtAgxeMxnO9P3k/QFZ947jpkO9jw69n8yzFmtA0AkI5UrMbuc1cJ/0u9024L4+phHe5fceTg0PJgPKkw8MSyAkmmm00qd9bLEHuT5hGrzm2+u6THPEwOBUp2LNsG91Z2OPCTkd008ha1+8Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VqLuzLLaBFt7hSKbK4c0DFUnAp3WNjiFgSJBcASVufs=; b=MNtTQNyBQobayORZtD8c+YYycGAKHn5/dv9QnjkFJ7Lnw+ZGbDiGU7p8OVgqDmg287gimf+DsS4wjVs7sQKPh8G+2tctnLzxQ5Fg998W+jOvs6YVBcRTpCiaRgf5SvYtXpkRgwV/La+TSaXuTh3MPxtpWMiCZALqfPpJkGWhiJgGv8Ei5KU0tA2LjGCsXejgTxVvHtVlVW6PbQk4/4XiIEsCiLVyBy6J4hxIX8slPy8NzvlnlUbJpW34BgF9ka73bt0jwZN1bFBPzaAd/KbYhPiZU3ez6xqnerx4qUjLs9QKpMzwSH8OjrHl/S+vSn4zy9Rc65LWqHw+7zxM5RxSjg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by SN7PR12MB7856.namprd12.prod.outlook.com (2603:10b6:806:340::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.18; Fri, 6 Mar 2026 01:50:16 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.022; Fri, 6 Mar 2026 01:50:16 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 06 Mar 2026 10:50:12 +0900 Message-Id: From: "Eliot Courtney" To: "Alexandre Courbot" , "Danilo Krummrich" , "Alice Ryhl" , "David Airlie" , "Simona Vetter" Cc: "John Hubbard" , "Alistair Popple" , "Joel Fernandes" , "Timur Tabi" , "Edwin Peer" , "Eliot Courtney" , , , , , "dri-devel" Subject: Re: [PATCH v10 05/10] gpu: nova-core: falcon: remove unwarranted safety check in dma_load X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260301-turing_prep-v10-0-dde5ee437c60@nvidia.com> <20260301-turing_prep-v10-5-dde5ee437c60@nvidia.com> In-Reply-To: <20260301-turing_prep-v10-5-dde5ee437c60@nvidia.com> X-ClientProxiedBy: TY4P286CA0133.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:37f::16) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|SN7PR12MB7856:EE_ X-MS-Office365-Filtering-Correlation-Id: 62426a78-a2e8-4962-9aef-08de7b22b6d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: z+av3vDqucmXvWRGP7M9so4j4k0u/ecGJEzruz4bxQEPPLC3B2rBdeM+jNReHzlKo4nDJ+17nf0e9RjY38UG/gV43vJKgkbuLnFL+F+SzOGYksfMsQBquI+VTjh4zg44EKldXO3fF0q+QdG7IVRcrOKAW6Jrpsp/MKIUTy7h3/6gC7O9jQg2UfRPzjGRuoZsX9hhF5nrq7Ra66Ea2te02e8nStkgGbR4NMyDp18CANjGtRsqRkUFVwgwqTHisRrBfTTXI8mlguHMfLeaGLwYzoMwalB2NJ7iRxg0pTvc/TUPX4px2fBIUyPCBSUbCnBzePAqb/0K1pzc0Mn5qUQjfLbTXZHisII3C7V7GYl1sUV8y/2jvEJqtnwhIehCfHEamwdjTaY3deocuWjpC31g4AH3fyaGg/gFa956oFfF2VtS8qTSDJQ4jxpGZlqdZ4Pn4u/AOBmcZu8kG58bs3I5zQVtJIvcfN6rS/8LsTbu9ILZxZy6nkZIRMVN3jBKGOYZXXoRXsF/Adz8C9nF0RSFEFYRK2x2P3DrWKIuqIot36oXKa9O/QoidO4tWk2wXm08BYUIXbFTwA5v3W7tjSt9q4M3Pnn2nnBy796/bDYdgaRYn7BZgToSJwTr8WopMRciIUZFO5/hjAfsg0mjCyAu+GmkSHpWZv+K2jNxlL54gdtB/de9At+dSh/8aO4A37wdUhRtfaiEILu8HZK7ci2YO6Gdo1dWa8mCOQd6IAxyCnA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlViMEhwNEhYRGpldVlOZkdNa3lrVUFrNjZRTmp2UWtqQWd6Yk5Ldko0ckow?= =?utf-8?B?MHhWOGM0SmlWN1hEaUpqdXNQOTR1RldDSjYxVXJkQmZFdUg1ZERsdnEvdEVs?= =?utf-8?B?em5iZmN4cUpSS2FRcW5ncVNaUURPb28zYndkV3NIc3p1a1JQNStzRXRSZmJS?= =?utf-8?B?SWxocVRCaVdmYjFuTnhvVUpCYXpPaUtYUmhkbkpLY2dFRjQyN0htZWxEUzRE?= =?utf-8?B?UXZFZ1JHbTlYWGdPVlVwQzRNZ0QvMER1YW5Oci94bjZaRkVIbDdhWFQ3QzRh?= =?utf-8?B?d3FzOU5yZkwxM3dnSWl1VWdtRjl1aGVzcjBEMXc4d0pXRWp1RjMvcmg0bXd4?= =?utf-8?B?aFFNOFVTTGNkSVZnRlFhajM2U0ZaZVNlNnpmemp1eWU4aklsZXI1QnlETTR4?= =?utf-8?B?R1ptVnFFZ3h0RWdiTUc5VTI5MW5uVWxBNkYwYWdxVkhjc3dkWDByQzNHVmE0?= =?utf-8?B?WmhDQ2pCcDJqeE5XSEJ4UGZsTzFteEZYWkxJZ2NMS29saHV1bGVtaHNXSEg0?= =?utf-8?B?VGlBTGFXM054WmhvdFQvQmhYdUFoT2FXM2cwYVJYenVCaDZNdUVFZGRZaHpS?= =?utf-8?B?WW9Hd2pUQnp6ZUtOaVJabHVEMzk1dVllMU9xUzZLR2tFbXlUVUIvbWMyQmZi?= =?utf-8?B?RlU5ckpCLzBtQS9uUnlKbjVKUFg3YTlBa1BnTVlONEZaNVhhdFJZb1p4ZHhw?= =?utf-8?B?ZWp1bk55QXdLSlFSa1d3MCtRblVSZVorOXB2Vy9SSk9tRXZLMmFESzI4RGNS?= =?utf-8?B?RWs1ZWVVSlZqelA0b0VFOExVZHFaNWdzK1IyMFgwTjdQdzJqN3pTeEJTMU5v?= =?utf-8?B?ZnNLQ3hmSW1Ob2JYbE1Vc2IrKzMrVERSWWR5SG9FVVVOZjdTQkVrdmFMZERz?= =?utf-8?B?dys4WS94Y1lFNktHVUNha0VTYXNVUjVXOUtGVGkyRnpkQXc0K05FazNEMll4?= =?utf-8?B?S2ZSaE0va2RQQmdpYjExV1ZKS2tpMHFBZlRNN1VRMkpRNmE2QzdwZ0dSbFlZ?= =?utf-8?B?UVRyVFdwY3RzYzFVb3pvVFlvOFR5dmJpOS9mWmxrOXRiU21IZzMwUE5US3hm?= =?utf-8?B?dm9iakNIM1BnaGJiOTlST21kRTkrZlhTc1l2NFVaWUdmNHJXWGpEVndzalNh?= =?utf-8?B?WVNiNU9JZmRLQVBKRmRmNzFnb2RQRTVtYlJ2S3VLa3RiYlMxeloxRU56NWxQ?= =?utf-8?B?WVl6Um80RDVBL29mR0ZkRUdtTGY2V2lxNEpBTGVPcWtWcEw5REltdzdvMTdw?= =?utf-8?B?LytXNVJ6dWFvSmtsRlBOTVlPQzhaQkVRbERjdFRldU84bGZoZU5yN21DMjR3?= =?utf-8?B?VGNNL3p6Q1ZyK1dadUJTbThGVjBzRGdkdjNhWUpvUU9LSUY3bnZlQ1dQQ3ZE?= =?utf-8?B?MURPVG53aExGVzJQZTBqZDNKbzZ5SXJCTERncXZmSU5Pa0NBb2F6MFVEVlpG?= =?utf-8?B?UXJOYWNZcDh6a3ZuNWQ4dktUa3FjQWcxL291dk5XWm1VdGMwNjY4a3A0TllJ?= =?utf-8?B?VFh5bVN3emkxKzdhK3hjN2dxZmNaS2tyTFdGMTdKNnJaa0xabUZnN2I3L0NO?= =?utf-8?B?Z0tHUmxJWCtxWEkrRnJEcENGYVNvVXFseXR1ZjRUUHhsWkRTN3N1OW9CdXgx?= =?utf-8?B?R1Z0bmpQMHFySVNhSlVzOEJkOTNReFpHK2NSaWpaWXdwREJ2cXdVa2c3Slh4?= =?utf-8?B?QWQzdlZrNXp0VFdHZTNBcE93SGNMaG5Ta1VjbVVZRU9HTFE5eFlpOEJYTUxq?= =?utf-8?B?ZWJxQTZNWkw2S0NnbGFoVlNFSkVKT1hzMWp2eG1EQ2FNeDVFSytoSlRMQkdw?= =?utf-8?B?V0E2WUd3TEY5R1JnVnJ3MWVRcXZ5dURXV2pLcVpXTFlPd2w3QU5veFIzQTJU?= =?utf-8?B?RzhMcFdzSDZjV1VtVWgyYXErU0FmajA1L1FnRUZNQ0xvZTRuOHhwTlZSU3Bu?= =?utf-8?B?MjVpQnNkbkk2ekRQeHJpNkkzYnFBK3kxWGZsbXBJc2lHNE42R3ZnTlczazV5?= =?utf-8?B?cDJCZm05TjQxbUtBM0lPeFNNZUdMbjRQWEpQeit3NG5mbllsN294bDlwcVQw?= =?utf-8?B?Z0c5d2MrU0ZycEo5T21ib0NYLzVBR3ZKQTYzQ0R6dnlDRm0rbndEQjRCdG9R?= =?utf-8?B?blNsT3NIbXpCSXJNRDRiSVUrb0lUL01YNldNU3I5VXZtV2dFWWZoa0xrVVkv?= =?utf-8?B?b3VlRW5KVjNJYk53aVQyQlFVMGJ3YlpRVGVPZkNleUV4WlhlaDgzNUd0dHZk?= =?utf-8?B?SjNBSlhONGRJcHFQRkpubHkxem9saXNPYWF0NGpkVFM1b2ZRVmlXTGlQdW1O?= =?utf-8?B?bUh2cmM3YmlwTWxzQ3lvalkveSt2YXVwcWl5UE1ySXRuQ095eWQ2MVV6SlUr?= =?utf-8?Q?DdAzVckUBJqEztYxMoMb/4KYvXITa+5SEhAOrbNTcfg3t?= X-MS-Exchange-AntiSpam-MessageData-1: YLlpiIwSX8iDww== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62426a78-a2e8-4962-9aef-08de7b22b6d8 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 01:50:16.2569 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QqJ3NLLVtCzpWWlWfYKKeoEQLuQ47hRznS9MQ5s7Db7pBsrkPWSTrw2ong/2rwSohwg6v5Qya7rkaBMjGo4nAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7856 On Sun Mar 1, 2026 at 11:03 PM JST, Alexandre Courbot wrote: > This safety check was an assumption based on the firmwares we work with > - it is not based on an actual hardware limitation. Thus, remove it. > > Signed-off-by: Alexandre Courbot > --- > drivers/gpu/nova-core/falcon.rs | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/nova-core/falcon.rs b/drivers/gpu/nova-core/falc= on.rs > index 450431804e1c..c02b73b1cfe6 100644 > --- a/drivers/gpu/nova-core/falcon.rs > +++ b/drivers/gpu/nova-core/falcon.rs > @@ -527,13 +527,6 @@ fn dma_load + Falcon= DmaLoadable>( > bar: &Bar0, > fw: &F, > ) -> Result { > - // The Non-Secure section only exists on firmware used by Turing= and GA100, and > - // those platforms do not use DMA. > - if fw.imem_ns_load_params().is_some() { > - debug_assert!(false); > - return Err(EINVAL); > - } > - > // Create DMA object with firmware content as the source of the = DMA engine. > let dma_obj =3D DmaObject::from_data(dev, fw.as_slice())?; > =20 Reviewed-by: Eliot Courtney