From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A34C2BCF46 for ; Mon, 9 Mar 2026 17:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773076612; cv=none; b=p12lu6fDzgVZanb+LmGxWfyJHYNUN2rdniTHAJQp+ITjIoGL5a2dOVY9iMpKE4LHutKwypFTP3WsnFdth7S5futN/nBYJNTnP8rco9lUKAAbtq2j33DezOSx1Gg8J+uKArFJQCxtZ520yRjYUGKlGZJJeEV1HAsV0S+ayRuXqvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773076612; c=relaxed/simple; bh=98am/GX184aN/jxZILWqoYJpBgZpE8WfZH2WonIweo8=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=CJt5qXfXvDOW/ParQu9p1v5UXiL7rchj9Wch4ZWCQ+nSHfZEXqnfdbci0LZRIwgZjt2SWJjJiS9WbcbhSzar3Z0iCR92zzh6LeM0q1Lgd1EcY1B8jMbQ96cbeP/KpXGKwnzBSr/7YUc12Ehx2sGV0TaLKEMbSzB1NLdv+jfix5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com; spf=pass smtp.mailfrom=etsalapatis.com; dkim=pass (2048-bit key) header.d=etsalapatis-com.20230601.gappssmtp.com header.i=@etsalapatis-com.20230601.gappssmtp.com header.b=GZA7dTSg; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=etsalapatis-com.20230601.gappssmtp.com header.i=@etsalapatis-com.20230601.gappssmtp.com header.b="GZA7dTSg" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-8cbb6d5f780so1200930685a.1 for ; Mon, 09 Mar 2026 10:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsalapatis-com.20230601.gappssmtp.com; s=20230601; t=1773076610; x=1773681410; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HQ27IJuLI7VMJcZjmtOkWzEBuIgt/KJd26zrF5qP+ZQ=; b=GZA7dTSgKVDOTvD4PSv2Xreb65NEBU3+L+WkS5s8JU/gvHKyqZIZvSBMKggpaCQ0fO yl43SYt/bSGWebzdVcUymqrnTqhjW8utw8ndPcd03kn2blTfPB93OkOERT3bsE1jVZK2 lLRXtQA+wafa7i+xtcxEhJL55FDwNgEGEsB/B5i8rNH3oSkhsThNoBm23awjRcXR6qni d5rlNSEhWntKPDdV3xEjRsbApa1mkfx/MVv6R69Po/U/DMgEAAwBOw6wbnFv535DuDaB jlsmdcgqSofX5mD39iJnxTnr0Z6h7Eg/OS/PZN4wAdvxz5BNJZBhyjB1k3A/UHZVP6kZ 7qsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773076610; x=1773681410; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HQ27IJuLI7VMJcZjmtOkWzEBuIgt/KJd26zrF5qP+ZQ=; b=LrCcfohFeW6xP+CEp7Skd1tPgJ2rciucqECFuj/UUn889WgLg4sd352sIfnt+Zm7rZ nge9lp9CyyypDXDiBEO3MpeKfy9ve4CVaEDUdZ5bQcgTS0Ams9G53s41dABsRq/qcuEg 44L27gvP+op0OcaNa8V7CdsNlmTfNJqiCgMLebpX5HoR0c9Y1ZyP8LukM+PObdi9benc sZ720Mvbbj4zNE+Pd23goUmqZ1B6f5XMfORZOFR2M872hkr9gbfHA0ueJeEo5q+G/tnE 18fGXtQx7kHz9P59a3aA7ChumchzBqpmFVK6DouJxkbauJjNMW/e+sFo+WE78/bvtlxo CgLw== X-Forwarded-Encrypted: i=1; AJvYcCUFlFH6v+oCmYJA0PnVlrRoGuyvA7Y0D8CMgJEK8+xu8g8g2+wRZUMCdxHVfeEGb/mjKoQ0HWlQJ9ZbPo4=@vger.kernel.org X-Gm-Message-State: AOJu0YywD/rPux0KfJFMKy207YUTJu2n+jabi3lKWsRgvezrgtk+ksHd qICam3ElOt2TySxBWL9z6WXOnrovrT0nOdvdM2U5eO/xdo5H8116JA3pfgYiiq6hMzU= X-Gm-Gg: ATEYQzw01/OjrdDdzqp1Z25hSf9PvgOfd4SPcAiaGkB14mobsvnSqb1rHKPrspNqrhW lC9b8ZyhbCOMDoubMwY+bKbHd/ODUuII/Ly9eUEA3aZjt70fS3quAQwbqajHiT/NfHLsWxVcaBh UcrVTohzCaKy63F7lNNDyxYah1k/jnsHgNZ/Pk700IVronmWbo3jkH4SW2QzHV3Z0/NSshMMoBu 1cnWenRg48kgpe9rXSEfCwDwim3fSmXEyTc585bJXi/8GNHBf78Q7RYnzDkSteig9WNXGLy6a1Z Ge/js/XcbsVEBwdtdwQaqlslWB2iHusxxluNzrHEf6fUDf8jD/XRAb6gAHO5OCDcdbalJ6Jiecd GyL75RlSu6Nb8FT/IFvkPbMvZKSUIiAhkdmju5pWGIZMUkLRTUrBHzQHD18FvR4fyIYcAHxlLsH DyCl1GcawfismjfKz2AVDnE9s= X-Received: by 2002:a05:620a:4543:b0:8cb:71d4:d0fb with SMTP id af79cd13be357-8cd6d48496emr1467710885a.36.1773076610179; Mon, 09 Mar 2026 10:16:50 -0700 (PDT) Received: from localhost ([140.174.219.137]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cd8576db0esm301300685a.47.2026.03.09.10.16.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2026 10:16:49 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 09 Mar 2026 13:16:45 -0400 Message-Id: Cc: , , Subject: Re: [PATCH 07/15] sched_ext: Wrap deferred_reenq_local_node into a struct From: "Emil Tsalapatis" To: "Tejun Heo" , , X-Mailer: aerc 0.20.1 References: <20260306190623.1076074-1-tj@kernel.org> <20260306190623.1076074-8-tj@kernel.org> In-Reply-To: <20260306190623.1076074-8-tj@kernel.org> On Fri Mar 6, 2026 at 2:06 PM EST, Tejun Heo wrote: > Wrap the deferred_reenq_local_node list_head into struct > scx_deferred_reenq_local. More fields will be added and this allows using= a > shorthand pointer to access them. > > No functional change. > > Signed-off-by: Tejun Heo Reviewed-by: Emil Tsalapatis > --- > kernel/sched/ext.c | 22 +++++++++++++--------- > kernel/sched/ext_internal.h | 6 +++++- > 2 files changed, 18 insertions(+), 10 deletions(-) > > diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c > index ffccaf04e34d..80d1e6ccc326 100644 > --- a/kernel/sched/ext.c > +++ b/kernel/sched/ext.c > @@ -3648,15 +3648,19 @@ static void process_deferred_reenq_locals(struct = rq *rq) > struct scx_sched *sch; > =20 > scoped_guard (raw_spinlock, &rq->scx.deferred_reenq_lock) { > - struct scx_sched_pcpu *sch_pcpu =3D > + struct scx_deferred_reenq_local *drl =3D > list_first_entry_or_null(&rq->scx.deferred_reenq_locals, > - struct scx_sched_pcpu, > - deferred_reenq_local_node); > - if (!sch_pcpu) > + struct scx_deferred_reenq_local, > + node); > + struct scx_sched_pcpu *sch_pcpu; > + > + if (!drl) > return; > =20 > + sch_pcpu =3D container_of(drl, struct scx_sched_pcpu, > + deferred_reenq_local); > sch =3D sch_pcpu->sch; > - list_del_init(&sch_pcpu->deferred_reenq_local_node); > + list_del_init(&drl->node); > } > =20 > reenq_local(sch, rq); > @@ -4200,7 +4204,7 @@ static void scx_sched_free_rcu_work(struct work_str= uct *work) > for_each_possible_cpu(cpu) { > struct scx_sched_pcpu *pcpu =3D per_cpu_ptr(sch->pcpu, cpu); > =20 > - WARN_ON_ONCE(!list_empty(&pcpu->deferred_reenq_local_node)); > + WARN_ON_ONCE(!list_empty(&pcpu->deferred_reenq_local.node)); > } > =20 > free_percpu(sch->pcpu); > @@ -5813,7 +5817,7 @@ static struct scx_sched *scx_alloc_and_add_sched(st= ruct sched_ext_ops *ops, > struct scx_sched_pcpu *pcpu =3D per_cpu_ptr(sch->pcpu, cpu); > =20 > pcpu->sch =3D sch; > - INIT_LIST_HEAD(&pcpu->deferred_reenq_local_node); > + INIT_LIST_HEAD(&pcpu->deferred_reenq_local.node); > } > =20 > sch->helper =3D kthread_run_worker(0, "sched_ext_helper"); > @@ -8391,8 +8395,8 @@ __bpf_kfunc void scx_bpf_reenqueue_local___v2(const= struct bpf_prog_aux *aux) > scoped_guard (raw_spinlock, &rq->scx.deferred_reenq_lock) { > struct scx_sched_pcpu *pcpu =3D this_cpu_ptr(sch->pcpu); > =20 > - if (list_empty(&pcpu->deferred_reenq_local_node)) > - list_move_tail(&pcpu->deferred_reenq_local_node, > + if (list_empty(&pcpu->deferred_reenq_local.node)) > + list_move_tail(&pcpu->deferred_reenq_local.node, > &rq->scx.deferred_reenq_locals); > } > =20 > diff --git a/kernel/sched/ext_internal.h b/kernel/sched/ext_internal.h > index 80d40a9c5ad9..1a8d61097cab 100644 > --- a/kernel/sched/ext_internal.h > +++ b/kernel/sched/ext_internal.h > @@ -954,6 +954,10 @@ struct scx_dsp_ctx { > struct scx_dsp_buf_ent buf[]; > }; > =20 > +struct scx_deferred_reenq_local { > + struct list_head node; > +}; > + > struct scx_sched_pcpu { > struct scx_sched *sch; > u64 flags; /* protected by rq lock */ > @@ -965,7 +969,7 @@ struct scx_sched_pcpu { > */ > struct scx_event_stats event_stats; > =20 > - struct list_head deferred_reenq_local_node; > + struct scx_deferred_reenq_local deferred_reenq_local; > struct scx_dispatch_q bypass_dsq; > #ifdef CONFIG_EXT_SUB_SCHED > u32 bypass_host_seq;