mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ricardo B. Marlière" <rbm@suse.com>
To: "Steven Rostedt" <rostedt@goodmis.org>,
	"Ricardo B. Marlière" <rbm@suse.com>
Cc: "John Hawley" <warthog9@eaglescrag.net>,
	"Andrea Righi" <arighi@nvidia.com>,
	"Marcos Paulo de Souza" <mpdesouza@suse.com>,
	"Matthieu Baerts" <matttbe@kernel.org>,
	"Fernando Fernandez Mancera" <fmancera@suse.de>,
	"Pedro Falcato" <pfalcato@suse.de>,
	<linux-kernel@vger.kernel.org>,
	"Steven Rostedt" <srostedt@redhat.com>
Subject: Re: [PATCH 7/9] ktest: Add PRE_KTEST_DIE for PRE_KTEST failures
Date: Tue, 10 Mar 2026 07:25:06 -0300	[thread overview]
Message-ID: <DGZ12KUWE234.3C5AOGRCKNUTR@suse.com> (raw)
In-Reply-To: <20260309110040.2bf3dffc@gandalf.local.home>

On Mon Mar 9, 2026 at 12:00 PM -03, Steven Rostedt wrote:
> On Sat, 07 Mar 2026 19:08:02 -0300
> Ricardo B. Marlière <rbm@suse.com> wrote:
>
>> PRE_KTEST runs before the first test, but its return status is currently
>> ignored. A failing setup hook can leave the rest of the run executing in a
>> partially initialized environment.
>> 
>> Add PRE_KTEST_DIE so PRE_KTEST can fail the run in the same way
>> PRE_BUILD_DIE and PRE_TEST_DIE already can. Keep the default behavior
>> unchanged when the new option is not set.
>
> Thank you for keeping the previous behavior. My PRE_KTEST usually apply
> patches that don't always apply, and yes, I depend on it "not dying" on
> failure. Which is probably why that was the way it worked, as the reason I
> created that option was to apply patches before testing.

I figured this behavior had to be there for a reason :)

Thanks for reviewing/testing btw !

>
> -- Steve


  reply	other threads:[~2026-03-10 10:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07 22:07 [PATCH 0/9] tools/testing/ktest: Fixes and a new --dry-run Ricardo B. Marlière
2026-03-07 22:07 ` [PATCH 1/9] ktest: Avoid undef warning when WARNINGS_FILE is unset Ricardo B. Marlière
2026-03-07 22:07 ` [PATCH 2/9] ktest: Resolve LOG_FILE in test option context Ricardo B. Marlière
2026-03-07 22:07 ` [PATCH 3/9] ktest: Treat undefined self-reference as empty Ricardo B. Marlière
2026-03-09 14:40   ` Steven Rostedt
2026-03-07 22:07 ` [PATCH 4/9] ktest: Honor empty per-test option overrides Ricardo B. Marlière
2026-03-07 22:08 ` [PATCH 5/9] ktest: Run commands through list-form shell open Ricardo B. Marlière
2026-03-07 22:08 ` [PATCH 6/9] ktest: Stop dropping console output during power-cycle reboot Ricardo B. Marlière
2026-03-07 22:08 ` [PATCH 7/9] ktest: Add PRE_KTEST_DIE for PRE_KTEST failures Ricardo B. Marlière
2026-03-09 15:00   ` Steven Rostedt
2026-03-10 10:25     ` Ricardo B. Marlière [this message]
2026-03-07 22:08 ` [PATCH 8/9] ktest: Run POST_KTEST hooks on failure and cancellation Ricardo B. Marlière
2026-03-07 22:08 ` [PATCH 9/9] ktest: Add a --dry-run mode Ricardo B. Marlière
2026-03-09 14:21 ` [PATCH 0/9] tools/testing/ktest: Fixes and a new --dry-run Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGZ12KUWE234.3C5AOGRCKNUTR@suse.com \
    --to=rbm@suse.com \
    --cc=arighi@nvidia.com \
    --cc=fmancera@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mpdesouza@suse.com \
    --cc=pfalcato@suse.de \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    --cc=warthog9@eaglescrag.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome