From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4849D3E3C5D for ; Wed, 11 Mar 2026 17:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773249206; cv=none; b=NisQN5XuRb9Ds8Z4z2gJaIUR5xB3ghnZLuMgJYe8+YiVp6pU1744fOYmk+RDpZJn/XDZJtIfifFUA4v1tuvCr6k2cYWJJL/i7UgECHtj+LYMnLG0eapo1wJFUBw8CgJkveyfcTKd0raMHw23hG5u3EeWvU4PrxDbgLDy8MHD1wM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773249206; c=relaxed/simple; bh=nw3JyLY1QJamL3IGH8awHQ3UW4oc9vY5mQxZlSj0ILw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=LA/CYm7O2a1kL2x6pjMFlnwoCJ7pe05E3VCeRu7d6/jLZDTINvz7bYeIoEwxJ+n2a5LRGfhFaI4Ea5yni7JF2HNugMGSv8QWK4OoOMhq7ZNh1+MgfwcKozs8WbcFahd3mTQrRm+xFsVjHaDLcjc4R84WXbsFezW8LaL0ggiqbHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=26TD3ZLn; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="26TD3ZLn" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-485389bf0daso904445e9.0 for ; Wed, 11 Mar 2026 10:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1773249204; x=1773854004; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8EFaAv+nRnVMg5QOlGIFBQPfUPCCp1vOljk0sBeym6s=; b=26TD3ZLnjeRXW8dl4fjbtbW1hpf2w1GkK9+vOwLMIDm9LR1HUmJnSR6HiG/zgQ6AUA 8l4LsnBvLaW+10nC7dTxTXjo/B3YnDAX+eCWXWeuxe7x/jzrVPYdt1uWirVH8J+hoYou 1kae0AT25RI+aVEEihKNLlRe3EwgBKCVFqVhmgnWP7XP1RgeCWzuuH/zgX1Go6BOIpq6 sutFAX+EyB6FIcMqy3VnCVJ8LHSX6T1Td1x4+VTmSUMpzGlDIm8aG0MQkdlX4DUyQ8OW BCjFTQRJ3bDq8y5sYTWMR5gP9OAb2qxlAYUP6xlIPDGNTWOGFDePsIpHzCg42Wn0zvsT QZaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773249204; x=1773854004; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8EFaAv+nRnVMg5QOlGIFBQPfUPCCp1vOljk0sBeym6s=; b=WmnnQYypCQ0pXxbJrKFRarEAcezT0OiGRlor8A0zn6Ka9Bn9W1Cm4/ESZnMzju7C/I wHh9cLUj6qU8QqPI063jaLxlUeZUBojXryPG8mCFek4firB3uA4mgxu0iPPrr1P8MOKN K35yfdy/l1Vx88O2zJssVQC8KZmmvoLPAEM8tXTuKVe3Ph+qbNT8gFFDnC26elcQopFH aQG0jR9M+gut7c5H0Fgw3Lg76ToaeJctNdZj+t/ZNeTlUli4UsqYUn6SjecV7Wxuzbuv Dr72npIX0ueU1vBhoI5DH6AcbstRtqIs4/WVgReTxPUX3iyFRYo6dzikT9ZNl+HrhfgV emjw== X-Gm-Message-State: AOJu0Yxs+0LPdwOF4+gTU4PjW7iJMrEYuf5N6pw1xAFt/f/6Q+gx1eB9 QClhCMjJXVngNxQ9ahmfCiHCcOHl7EIV4YxSFg+9mXQqiLDcKqR6NwNIsh9DMCAFC7xcWagHdg4 jl5Q7TNAafH1RRg== X-Received: from wrms7.prod.google.com ([2002:adf:ea87:0:b0:439:e73e:6ac2]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:a010:b0:485:2c61:9457 with SMTP id 5b1f17b1804b1-4854b0e0565mr61617215e9.10.1773249203389; Wed, 11 Mar 2026 10:13:23 -0700 (PDT) Date: Wed, 11 Mar 2026 17:13:22 +0000 In-Reply-To: <04be68a0-86c8-466c-b6b7-de55074c1989@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260311-pgd_list-comment-v1-1-4ea51b41adee@google.com> <04be68a0-86c8-466c-b6b7-de55074c1989@intel.com> X-Mailer: aerc 0.21.0 Message-ID: Subject: Re: [PATCH] x86: fix location of comment about pgd_list From: Brendan Jackman To: Dave Hansen , Brendan Jackman , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , , "H. Peter Anvin" Cc: Content-Type: text/plain; charset="UTF-8" On Wed Mar 11, 2026 at 4:39 PM UTC, Dave Hansen wrote: > On 3/11/26 07:04, Brendan Jackman wrote: >> This venerable comment got detached from its context when the code moved >> in commit 394158559d4c ("x86: move all the pgd_list handling to one >> place"). Put it back next to that code. > > Shouldn't the comment about the data structure be on the *data* > *structure*, not the code? > > LIST_HEAD(pgd_list); > > ? Yep, you're right. > > But either way, I think the comment should just be chopped down to > something much smaller, maybe: > > /* > * A list of all PGD pages. Mainly used to keep shared kernel > * mapping page tables in sync. Needed because PGDs are private > * to each process. > */ Great, sounds good to me. I'll let this sit a little in case anyone has other additions/corrections then post a v2.