From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B28BA36CE19 for ; Fri, 13 Mar 2026 10:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773398423; cv=none; b=m07bEEaOusxyKPA9mDY9L0GvHdpEo0Q5CJZmAUMFTeLvRy3HKY5MljtkhH7Gmr4iemqEWvDW2Y7QIkZRfCEb2TMhesqHiZmDafzZlk/sxyPPxNsQHoeYU2kvQf4L6YCgy0tTDlFI3J0BfNFtDuVsX+QE4JKD/7kgshnX7w7L3AQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773398423; c=relaxed/simple; bh=hy2V46Yj7werNEnar5xCstGATIYnGcBGHz9kvOo8w6w=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=jAMpYQhKsRkEpowFY4ZN6XiJaJ/JHFVP+QpmcUR+DxUouQGaomS+vRH2INgAI6sVozzpYnGMm78/32qgLInXXBbXueXGbfgbOg5cZfuycxsul9Smj5uK34wo1Fcje9GAGX2I8bKzRmoHCdpfwj019zAqbMFe3ufBPyctkfRMkrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=cP6+zoD1; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="cP6+zoD1" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b9431300833so300903866b.0 for ; Fri, 13 Mar 2026 03:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1773398419; x=1774003219; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v/LSQW+rdHG/cjFYWltT+w8Nh8WDkZ/yQlRQR1OIp6g=; b=cP6+zoD1nbRidnx1IcGbF97XkDpa0NSCbeP++fOzrxof10N0nBORMvdnqme6MGl71N aYv5OoRyCuHL0RHq2PCclakimd5H0YY1Mu9Tpux8BCW/cRfLGEZ13xr128PoZJtMP4jW 1jzkJ9LQaYRsBWYUVPd3ipUq846bBKzlZi0dx80tgX2cn3J4T9VMRXLQgRcDuTcOIKwo 1m3n97EOP8lNJWhPI4QgAHM3cWZjwD5Gd0g51PeHsb6aebO+y57YYhqoYfEg0tQHFSu9 GHvKlPMUvCDRNOkZD076rZBbES0waLUTL4kexLcc2G+QCij9MAR9JH1PK0Zk17e7Dfqg 9Pww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773398419; x=1774003219; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=v/LSQW+rdHG/cjFYWltT+w8Nh8WDkZ/yQlRQR1OIp6g=; b=jWeyTzO39VbAFbDOior+vu9MGLoJvoJwoHBCO1jeMriliklx4mKC30bmxSxowl569S mMV6DSpTFqYFlLoqox85k3F8kygt8tLfrI6MYn5LawGw6zWbfxcL6awzI1tQy3opERxC 0uS8tZ0KM4MWlY7c+hdvff4snXfHK4KyuFiqOWQAu6XP/HOSt8H62sGxqXLdKv5Ca0d8 juBRuWCJ/NpiJKCtDw9OHGe0aQI+e6AJb6J8nDZMGjeSBbGlXk83C/lBOKk+zxvB1FgG uRz0lCH+qAj8d68dvDRPTQJTnUVRffS38RjDoKn2wQhXdz1fvyoqilnB09rL7lJAoSME B6EA== X-Forwarded-Encrypted: i=1; AJvYcCUERQXYA49pEWlAoIrLsiSVBDm5n07Xs5xqlrEA5ShocscgL8zIzd6U/lxd1518Z5h762aorHm5u0j9OPM=@vger.kernel.org X-Gm-Message-State: AOJu0YzX9LaG9zMojhFqXrQ6YydWQ3wCInuYAihJsyorbzOMsjxKWl0V oY3c7uRBzzxOG2ZQPiokb3EvgVIb3mT/rIwqYuoSiwqAXwJeAUizPFk0N+lMUqm254U= X-Gm-Gg: ATEYQzyUxnQaRaR4NVfm/XWXeXs9KS3NjB2nCPw7ZdUYhjABoGyN/K06AVtT8MISqv6 S0/HqaRBcOfvMTqTSXJBmwTeymeGFDnv+RrmuD1rhKR/syqbRMG0d69kZ9ylPMFKfV0kBkr7PwV qt/Ii5qvyJngHZZ/uieHzx2aDp3orG6/Rc2QggiaVvIwUsSCcMilF5AE8Z9YEr4kb6EmXRFZbIy kk/N3HMND5mE69wGqMcZYz72ByJvW/RYyvcfI/WOTyGNHfHiObc8bPoXUcwguvzGwy9j2I9Nvfg 7nz70SnnHGY7HeNO8xCLjEhEQnjh919nNEnArcVA4YyPEovK9DFAlKtEdjoKAZ+uxHzYkJWkCqb spwA7VOvqMLP2BigLLT0/haUPAjXZCQhc+z7HYVXVcmR/nZAifOnNj/eC+aISSXxdZ0vRUBK2t3 Xv8Xhej6vVYN/QpppSwWp4/zpkgSjnz6Tp92h2Gr9tOY9IIlatWt4PIms4ZG5q2Gpi7gAW X-Received: by 2002:a17:906:7db:b0:b96:fa3d:c8b3 with SMTP id a640c23a62f3a-b9764fc9c64mr125909366b.9.1773398418844; Fri, 13 Mar 2026 03:40:18 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976cba6e8bsm36432466b.6.2026.03.13.03.40.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 03:40:18 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Mar 2026 11:40:18 +0100 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , Subject: Re: [PATCH 4/5] arm64: dts: qcom: milos-fairphone-fp6: Enable Bluetooth From: "Luca Weiss" To: "Konrad Dybcio" , "Luca Weiss" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Alexander Koskovich" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260116-milos-fp6-bt-wifi-v1-0-27b4fbb77e9c@fairphone.com> <20260116-milos-fp6-bt-wifi-v1-4-27b4fbb77e9c@fairphone.com> <52fffc84-2fb5-47aa-835c-b0dd8c110d59@oss.qualcomm.com> In-Reply-To: <52fffc84-2fb5-47aa-835c-b0dd8c110d59@oss.qualcomm.com> On Wed Jan 21, 2026 at 12:52 PM CET, Konrad Dybcio wrote: > On 1/16/26 3:50 PM, Luca Weiss wrote: >> Add the nodes to describe the WCN6755 chip with its PMU and Bluetooth >> parts. >>=20 >> Thanks to Alexander Koskovich for helping with the bringup, adding >> 'clocks' to the PMU node to make Bluetooth work. >>=20 >> Signed-off-by: Luca Weiss >> --- >> arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 174 ++++++++++++++++= +++++++ >> 1 file changed, 174 insertions(+) >>=20 >> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm= 64/boot/dts/qcom/milos-fairphone-fp6.dts >> index 52895dd9e4fa..cbe1507b0aaa 100644 >> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >> @@ -24,6 +24,7 @@ / { >> =20 >> aliases { >> serial0 =3D &uart5; >> + serial1 =3D &uart11; >> }; >> =20 >> gpio-keys { >> @@ -215,6 +216,67 @@ trip1 { >> }; >> }; >> }; >> + >> + wcn6750-pmu { >> + compatible =3D "qcom,wcn6750-pmu"; /* WCN6755 */ > > I think a fallback compatible would be in order, if the data matches > exactly That'd give us these changes milos.dtsi: -+ compatible =3D "qcom,wcn6750-wifi"; ++ compatible =3D "qcom,wcn6755-wifi", "qcom,wcn6750-w= ifi"; milos-fairphone-fp6.dts: -+ compatible =3D "qcom,wcn6750-pmu"; /* WCN6755 */ ++ compatible =3D "qcom,wcn6755-pmu", "qcom,wcn6750-pmu"; -+ compatible =3D "qcom,wcn6750-bt"; /* WCN6755 */ ++ compatible =3D "qcom,wcn6755-bt", "qcom,wcn6750-bt"; Plus 3 new patches for dt-bindings, with commit message something like Document the WCN6755 WiFi using a fallback to WCN6750 since the two chips seem to be completely pin and software compatible. In fact the original downstream kernel just pretends the WCN6755 is a WCN6750. Does this sound okay? > >> + bluetooth_enable_default: bluetooth-enable-default-state { >> + pins =3D "gpio53"; >> + function =3D "gpio"; >> + output-low; >> + bias-disable; >> + }; > > Not sure if we need to drive that pin.. perhaps a pull-down would > suffice? I'll give it a shot, this pinctrl is coming from downstream but perhaps the downstream btpower.c driver is differing in behavior to the upstream PMU driver. Regards Luca > > [...] > >> + bluetooth { >> + compatible =3D "qcom,wcn6750-bt"; /* WCN6755 */ > > Likewise > > Konrad