From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Tomasz Unger" <tomasz.unger@yahoo.pl>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: <linux-media@vger.kernel.org>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: media: av7110: replace C++ comments with C style comments in sp8870.c
Date: Fri, 13 Mar 2026 15:51:04 -0500 [thread overview]
Message-ID: <DH1Y9HEL19NE.18H6NA9WQK0DY@gmail.com> (raw)
In-Reply-To: <20260313-sp8870-cleanup-v2-1-ca679e62f9b7@yahoo.pl>
On Fri Mar 13, 2026 at 11:32 AM CDT, Tomasz Unger wrote:
> Replace C++ style comments (//) with C style comments (/* */) in
> sp8870.c to conform to the kernel coding style.
>
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
...
> - // not documented but if we don't read 0x0D01 out here
> - // we don't get a correct data valid signal
> + /* not documented but if we don't read 0x0D01 out here */
> + /* we don't get a correct data valid signal */
This needs to be a multi-line comment:
/*
* not documented but if we don't read 0x0D01 out here
* we don't get a correct data valid signal
*/
Thanks,
ET
next prev parent reply other threads:[~2026-03-13 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260313-sp8870-cleanup-v2-1-ca679e62f9b7.ref@yahoo.pl>
2026-03-13 16:32 ` Tomasz Unger
2026-03-13 20:51 ` Ethan Tidmore [this message]
2026-03-16 8:24 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH1Y9HEL19NE.18H6NA9WQK0DY@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=tomasz.unger@yahoo.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®