From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE17C45BE3 for ; Sat, 14 Mar 2026 21:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773523844; cv=none; b=fuXWXH12/yYBTWfU0tpyQ/Wru47kvO/tnC1PFof9utvw1qSFaMGDMd8BZrJtnPnHY5A2BpaVnMb1KW58qEWC4flEPMtAiiPNlX3jOOlOmV5WNAj4DwuLObrVVyiB7lTRTUiUB5812tsgOLgARij3RzvXzfNbbNRvj09z/60SU0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773523844; c=relaxed/simple; bh=YBkWBM9XkFPWSbpTeYx/p+UXVJnS5tx6OmvaK9X5uVU=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=ZTX1B0xSKQ6bGZQ4tj6reh0EvQIu+QVY9sUHp7AGe6DJoN06RKqLnnPL7Qkiy8mGTlGG8lbqvsZoQXgRx8fxxQnJxA/63dTfHVEGktqQxnIL/fv6Zfi3MTM4ImRTusP9YuGpaf+TQMG7rCm06w81iPRQnK9hGiORhZ6UsBJ5XlE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JJDEojiP; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JJDEojiP" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-7986e0553bdso27988877b3.2 for ; Sat, 14 Mar 2026 14:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773523842; x=1774128642; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VgSYP6cBIfHHGOkDhK1jT8ZKSXTix+OQr6s4gZh8rt0=; b=JJDEojiP+eoHzPBit8D7EcsUxwSnXRE6eY5DbPgncEz1ZIJJAVkViFFFp05E0IwLY9 6OuzoTO1W+hbpJ5ubfhq3Elg1nJnPmk+o18L9WHN0/Jdl8PZ9uUfTL2CUPSINTbZRuYA Y+q9ud08W8yJ4Ys6WsyBQPT3jnCDq09HHWBaUfymkkDgBaMrxvqEXtYjNuOTXZmAXVz8 IvtlbrpTNcnx5IwJ85rE3ldFnGLK3iCYBMu0mAjitiIfEXL2kA9H/Avy4Q9/LIPyC7qK /LaFn1muPGAmI5xPXusWJ/jvM1WmiGwnR915Q/TDzT9jeaAld27h7s23ndg2Z3vgad8g 6rMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773523842; x=1774128642; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VgSYP6cBIfHHGOkDhK1jT8ZKSXTix+OQr6s4gZh8rt0=; b=KdLdy5P5x+AaGUzOb/NQLVIP1xD0R9a175AhliBWtdZRlbknXxEMT9BVeGlOMm02cU 9ZaaLndYcB96WnpufwXEwhFJ2jVcKevD9tni+0oFHASPxguSb1NoMhSxJAerqXza6wxg c6A3g53ZilWpitnuZHFypPCmhgVlj8dylyIWa4ntmCzkxC4EeljjpHYJS9sTPnHr+0Td u0vEHx61KjefXx9979rQzcg5ErdH9R4nh6MtRc9t17D0r5R4TVk4o0ByCwuSt6o9PsWp 7fqiSDVkAC68OaxZfai3aAatgJbyZoIJzrtJdKkbLVTv1YCKbSqZAMLVxqZkPzIVbWCG v1MQ== X-Forwarded-Encrypted: i=1; AJvYcCWDB8ju2WMM4sUaff/J8CNHglSxxiXAxhoMHsHRAbVgQF2N9eg9YHGCNX1fgbvc11TkCVyuPK5NBoaywlY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+xSln7CERZ/RSgkbQCkD80k+24GYNINsFEnceLsAsLHupDo1c AOyGUG83Hb6Jgtzi4zSAw6uzLbjsB0azvyrk5awcb0wesF1HiQU/tme0 X-Gm-Gg: ATEYQzwDmmCfg3iE6PaTXylRja3tBPwNPYvqeUSSqIvro2XjzMrzHyvsJFkFwUMKcjZ 5M+b0DEKb3PbjeswM8OTDCDWnRKSv3vO6nQsf+otMfY4OHX4CcZefXbBrwm4WAX+qpIVNFjlkvW bam4LUf9rghI7OHe0GIIM3lZ5EPAG8S+BJq07wBvyPo2fKAE8ex8pnW6FB9sQH5uBrPWBPQD6xR iaeRQqcXBOMjDwZT91AcOnixM5Y23X82ifW48yjgIB8lf+M/mP5/cwBau0u8ShMMaXtO3o+tKcO X/zBD98WiW46b1aj9GPfeNmI0NEu4bYt7BP42Qtkxh47x5tUvQHUznJ5R0IynSS2gDYlZ8HWXRQ zgU18Qiftm+OFmhjqw8HJeQVgfM4Cxymmvus9csM3WYrPiiaipZpmXhe+8sSTe9UtkFAAGqCh20 EsgUBK3mujmrs1/pFM9TNu/N2valXFaFCXhouAfGOo5fekbj0gf+BO8tw5hrp59XPvcQDoM5SmF 5HYtidP8TmyEbBCdqB1/+Jc7vxqNbbz0pzpVCgSIvI7fRuALV7aIJRorkeYTe0eG8Quvz29Kmba DQ== X-Received: by 2002:a05:690c:e3c2:b0:798:c347:ccfd with SMTP id 00721157ae682-79a1c0892cdmr87528937b3.11.1773523841866; Sat, 14 Mar 2026 14:30:41 -0700 (PDT) Received: from localhost ([2601:7c0:c37c:4c00:f174:ec69:bc86:8883]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a420386c2sm1240567b3.42.2026.03.14.14.30.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Mar 2026 14:30:41 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 14 Mar 2026 16:30:41 -0500 Message-Id: From: "Ethan Tidmore" To: "Marcos Andrade" , Cc: , Subject: Re: [PATCH] staging: rtl8723bs: Replace network magic numbers with EtherType macros X-Mailer: aerc 0.21.0 References: <20260314210426.42532-1-marcosandrade95963@gmail.com> In-Reply-To: <20260314210426.42532-1-marcosandrade95963@gmail.com> On Sat Mar 14, 2026 at 4:04 PM CDT, Marcos Andrade wrote: > Replace hardcoded magic numbers for network protocols (e.g., 0x0806 > for ARP, 0x888e for EAPOL) with their standard EtherType macro > equivalents (ETH_P_ARP, ETH_P_PAE) defined in . > > This change improves code readability and aligns the driver with > standard Linux networking definitions. > > Signed-off-by: Marcos Andrade > --- ... > +#include "linux/delay.h" > +#include "linux/if_ether.h" You always include linux api headers with <> not "". Also, header files should be included in alphabetical order: > #include #include You won't include in your v2 for reasons below. > =20 > static u8 P802_1H_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00, 0xf8 }; > @@ -128,7 +130,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, = struct adapter *padapter) > /* Tx buf allocation may fail sometimes, so sleep and retry. */ > res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ= + XMITBUF_ALIGN_SZ), true); > if (res =3D=3D _FAIL) { > - msleep(10); > + usleep_range(10000, 11000); You didn't mention this in your changelog and is an unrelated change. Please make this its own separate patch. Also, this should be changed from msleep(10) to fsleep(10 * USEC_PER_MSEC) as this is the new standard API. Thanks, ET