From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f52.google.com (mail-yx1-f52.google.com [74.125.224.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1BCF37CD23 for ; Sun, 15 Mar 2026 22:09:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773612544; cv=none; b=jbx+JDV7VOpiSTX09kRKWvuR+aL6Gmz7L4V893Kzv4hO053XlhtAdyXLL02JvD6jCNauzKEZOFaowK1EWn4Ym6Nn5V2PMeaSVpY/l/n56mhmYR8L9Ll41F7oHYz1hzGsWMH25SjB3DXqWe50MXvbQtm8pk+0TytCWismmCML6pY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773612544; c=relaxed/simple; bh=F32G5v4g0560yjQoUsa9aBcS8+2JCBJIJaqdpIteghg=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=t2GQ8eKm+41ljVBuKwgFQoU7Y0yWgVy8A9PKVthxMls+V4lwdFCclfifBnner/LtbmMuiqeIM1Dr+QZkIOqbRthbLFAF1lrdwRJcJgZacyrPNIh5M5kebGxbxaIGdtSGBtKoidfViVp/TUrV2fDD1fFp4t7m+uzSg9r3munSmu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YwVAWsdW; arc=none smtp.client-ip=74.125.224.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YwVAWsdW" Received: by mail-yx1-f52.google.com with SMTP id 956f58d0204a3-64ae2ce2fe1so3725002d50.1 for ; Sun, 15 Mar 2026 15:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773612542; x=1774217342; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vwU8AQ17POy7BFOWiGWbigjM58uExMEEnEO1I7uCiJA=; b=YwVAWsdWzB+gxJN0R0KaGDWCoF7J2cfwdRKXsu/a/b4cjK+fRm0W2ZI5jPWlyIg12I KH5ixmbuYE83H0X4TxGqoabzXJyoY6OPMOU2/yT/BfREiLCjBkr4JpcDaq4owY58bzi3 z7gG8U+Y9i0YGk4DprGaH8Ot6MlchA00QFx1g180XCCORgRbgnkNsPFht/fmO7jZ15Lw WeREfkc1OwUTAAJpKbV7PhHIIzrXvClKywM8wyGnRokLTBvHvBuzBth+5tMr2w1hyq4I qLSPI2CxnB50vRIKh8uc/rmjdePISB6eiK/AakfWpSrowXFD0XC2nd3G5uRDjqebPLIh 79BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773612542; x=1774217342; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=vwU8AQ17POy7BFOWiGWbigjM58uExMEEnEO1I7uCiJA=; b=DXbqZqBpqhyY31HqeZqs3Lxb54DEBx+yFy8Fo0viWH7UOUsJs489E5cVjXt2DA8NRu fIt0chRU9BpakF+HpJ4FXWq8mK7xqdernt566coZo4sXLe3iQ4mdETu9zXsJzseJcAho SMv5OEHpqIzp8f7QDUP8FrYIj9d5gwwTATpu1KJZFVTkoum2YlQdPbWTkYbYr0Anijmx 6yHRvJYlj+jMMYHHjL+2ZmkVEkMNayZxAP/UfqCBeJeIucqxVJxfATne/PxPwgH1TVnR zQmeiAYJqU/4XPRUkPcrjSCafoTvVA3NNb8jqfkewszSopBghXx56GvKkzD2AwGDnJMS NAFQ== X-Forwarded-Encrypted: i=1; AJvYcCXRvjxnT7iK2EBp251tzsXwOrR2jfD7HtUmmmugcr52+7rCI1q6gq8HYjIRDY1OKtD5FFKSgHeXq2XJj/c=@vger.kernel.org X-Gm-Message-State: AOJu0YwDNky5Tj1cGm6F7CP/UAfdPBj2og8L8nBthBF9Gx5STIGItImj zqwcQmZpi8j/Qttr+NeukblKOKQo4omJxixu16boE6VlATFEtxYfD9ag X-Gm-Gg: ATEYQzw7J7M/ILWaZbzHZzsP5bv+m+W6hMszq8xKj3xDMy33P5sNGh84EXP2pM+hZQa c2ZhSnuB9+x8sR5FEIwDcxKA+Td2w/nIHmEuLY3GveE2HOv4hNjJNaEPuX86H/g2ZYR9MIbf+M3 ay5OpL2I4UM8FhyguPIDMLuM+0lWwoya/oTdv8hJJqBRRWoCgPn03xEzmwmSMRNn7ECAbNCdElT Zpu++piQaUmN011oDZUZc5Gqnae4cc1EiRvKm4WI0aB729Z4LGDD9lI7ODWpKpS5ekAZ10CqAx9 vkGEJSLWEk0JojHLP+bCUj4zM7SzuRyK0Y1GplE8BrZOPTkxcN10UoBCxsWaAxnHkkfDUsMKcNh X65UuLv+sOKIS1lwD8CzapQEz6f/2Ms6KKqtEDk9cz3bBW2mTBGT5ZD+uMmauJzUphM+C84qtvB Su+h6OIe71E2hB0qssxekuf3gnIylctTewjU2YihUdVSAbCDi07717eFEBQKyrnXnQdSXJwRAB9 3rXx+WPIa5dMg+257wmThPsyyWoGsLn9a3EmTqBn6M= X-Received: by 2002:a05:690e:254b:b0:64c:f14f:8f7e with SMTP id 956f58d0204a3-64e63065d8dmr7604198d50.47.1773612541693; Sun, 15 Mar 2026 15:09:01 -0700 (PDT) Received: from localhost ([2601:7c0:c37c:4c00::5585]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64e65ba7b31sm4640385d50.20.2026.03.15.15.09.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Mar 2026 15:09:01 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 15 Mar 2026 17:08:40 -0500 Message-Id: Subject: Re: [PATCH v4 0/2] staging: rtl8723bs: Cleanups for rtw_xmit.c From: "Ethan Tidmore" To: "Marcos Andrade" , "Greg Kroah-Hartman" , "Ethan Tidmore" Cc: , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260315210550.6058-1-marcosandrade95963@gmail.com> In-Reply-To: <20260315210550.6058-1-marcosandrade95963@gmail.com> On Sun Mar 15, 2026 at 4:05 PM CDT, Marcos Andrade wrote: > This patch series cleans up rtw_xmit.c by replacing magic numbers with > proper macros and updating the sleep API, as suggested by reviewers. > > Patch 1 replaces network magic numbers with EtherType macros. > Patch 2 updates an msleep() call to the new fsleep() API. > > Changes in v4: > - Fixed commit message line wrapping in patch 2/2 to comply with=20 > the 75-column limit, as suggested by Ethan Tidmore. > Changes in v3: > - Grouped the patches into a series because patch 2 depends on the=20 > include context of patch 1. > Changes in v2: > - Changed include from "" to <> for linux/if_ether.h. > - Sorted includes alphabetically. > > Marcos Andrade (2): > staging: rtl8723bs: Replace network magic numbers with EtherType > macros > staging: rtl8723bs: Replace msleep() with fsleep() > > drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) LGTM. Reviewed-by: Ethan Tidmore Thanks, ET