From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BE895CDF1 for ; Mon, 16 Mar 2026 03:42:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773632523; cv=none; b=Vjh0vcjFGzU6z7ddqoxWPtdKDqwl9cPY+Si9rTg8V0lxGn+QDI5xWpffxx1CjLHYct/XLpddsJQRUo4G0y2CI6zxLq41QRFiEHguETRFclEXrnrUTFUmZuPpgrgz+DuTs5qj7tnshU4QsOQQKpalnFmlo+f0c/0T6QVHyvaZgpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773632523; c=relaxed/simple; bh=NPCf9pAP10mI3HaScl9LrDwoHO+s9iccF7eZHjZ7P8c=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=EyybuRcVSn4tBwgOt4xFTdeqHJM77OGDYTpTs/X5+ZoHAKmm8U9qlssylIsmSHXpwI8F22f6/4S3Cu2Uv9TdaQA8+6tslpvPUPFPnrSOOnEddNoj4ur7Lf0qk4EtHoff9qiZeAufhsJMlxyylVDUM5jioWLw5iaf9R6d/WGRYdc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cIcjI6XM; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cIcjI6XM" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-79a51edef1fso3749067b3.1 for ; Sun, 15 Mar 2026 20:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773632521; x=1774237321; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NPCf9pAP10mI3HaScl9LrDwoHO+s9iccF7eZHjZ7P8c=; b=cIcjI6XMG9m+ELwp6jbnBOMZm9kHaiJPURFiilHr5/s4ObXiuPdDQ/Cr+zyjmMwhHU hz6k/N3Iyq0YotkYVo8ylWSWdvoDImqsSIp6bzZ7qkzTWMKj01zQbvolMHjzxSW+xSkw Hq0O8JgLA9dTyFJMlRbq3bt9ZWbWPsS6yMxGJfRkpbGrTWW8af4KYasoTfCulu7NnsEB 4lraZXiWpPq2VX5dAV2KCfYjQe/AYydwRQG6cmaUOdnyVOeswxrD2yzWoQGlMNW4ASYh XqbX8A1WuRt8WHEN2muAcy+e6iLrMg0+dM5F4/j8EcChXuUJJuSNNmm3sqx+7f3b+cSU AN6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773632521; x=1774237321; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NPCf9pAP10mI3HaScl9LrDwoHO+s9iccF7eZHjZ7P8c=; b=LV8PrFzDdkojm/6vQ7L5GBGVMscCyu+Abn76in3q/75S2H5lVE57xLSSNAavfngi4+ BP0ipJRN9OachqdzU9cLKbLA3+IFdLsx7PABC0NGF8YuvElYr/9xGNSyVz897i36OxuX KBOmPjnc5/1/scEYJKp725GtL7qqRW8irjzxOtmNKx7cxK5+lMHk4LlJ8An1wOkxGtC9 B6533QgnjmIJkcOHXOJFOaEYXjzgp4SrSE767bRLyp4MDAPYM98VH1VmE6a22sRhIAUJ FNd17LfAwMjiHRpWePQ5PW64HoMKnaUc4ma3JxNRbYdLHMttJojUlgBn/JH1YixyH8N9 ElQQ== X-Forwarded-Encrypted: i=1; AJvYcCUeRxlVCyMsglbds+E7PVInm+30XbeqyBpZaJYNIoY9HPVl08xRnNectIHIe6u8h0WhwdZOjFwNBVIdB9A=@vger.kernel.org X-Gm-Message-State: AOJu0Yzt07U/bPqswf3gYyudZNjIrfUomrGZ+t/vfht1nVoqxS59yeiU Kn731/u/g8bj90c9/eNLd+YHWUbf7zS6MfLAoHQPcKZP6feJerwgGNFcviZhfh/B X-Gm-Gg: ATEYQzx//I8Qwt+1Y2ohQsEBKJxWyG3/AWBbDNQ3svPKEnWv0uEaFPxfZRJ/nDufEFS C1LDO3ZWRrnj4l6uw0JGRoq3vdHegR45eyR/Tkz/fa3XwPLEK3ddIbsugDTnbo7M7n0rV2qfCll eYqTIE4qkftWsTPGoy085G/jEFdM3DXMZ93UF08kTbP5iv0dYfXF3H3/NuRfe7WpAuqwmP1gc7x nYV3vb96XVgQYJWtx70kkKkNzQLKZQshy69tqBaJzroB4YB569pRdli3Q6xjPGSxLBUlPLb4Cjm g0/vKK59/1OSo1rCECrJCAw5UhVXqDwGmSAHDfmfQ0QxwzEOPQYMAWJK+xl2f7nET5LC/kOpc2g q2tmprtSIIyL0Hm+/CXEYUSCmAk8hFNsV24jcerkwrnCIhDpGs9E9VY0WbsiXk+3CLA7gzroGyp vp1N5R1e//TqvTyA7DF/ntxMpeRUmnmNDWusC7f9VPRyV6gk6+3rah3Rfuak9j+WfUcwHnXczgN +5BSW3xe8TPVO9J7XVDo90g0iRAQSRO+UfMVPXpuog= X-Received: by 2002:a05:690c:5312:b0:79a:3564:ee8d with SMTP id 00721157ae682-79a3564f2bdmr34997337b3.26.1773632521453; Sun, 15 Mar 2026 20:42:01 -0700 (PDT) Received: from localhost ([2601:7c0:c37c:4c00::5585]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79917f37b98sm82565617b3.49.2026.03.15.20.42.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Mar 2026 20:42:01 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 15 Mar 2026 22:41:40 -0500 Message-Id: Cc: , Subject: Re: [PATCH] staging: rtl8723bs: remove unused global efuse variables From: "Ethan Tidmore" To: "Marcos Andrade" , "Greg Kroah-Hartman" , "Ethan Tidmore" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260316023037.11437-1-marcosandrade95963@gmail.com> In-Reply-To: <20260316023037.11437-1-marcosandrade95963@gmail.com> On Sun Mar 15, 2026 at 9:30 PM CDT, Marcos Andrade wrote: > Remove several global efuse variables from rtw_efuse.c and their > corresponding extern declarations in rtw_efuse.h. > > These variables (fakeEfuseBank, BTEfuseUsedBytes, etc.) are completely > unused legacy code. The driver currently maintains the efuse state > properly within the 'efuse_hal' structure, which is encapsulated > inside 'hal_com_data'. > > The removal of this dead code cleans up the global namespace and > resolves multiple checkpatch.pl warnings regarding CamelCase naming > conventions. Verified by compilation that no functional code > references these variables. > > Signed-off-by: Marcos Andrade > --- LGTM. Reviewed-by: Ethan Tidmore Thanks, ET