From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A91E2D94B4 for ; Tue, 17 Mar 2026 15:55:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773762956; cv=none; b=cL1UKLFrzAt60G460awNCtKBeQaOJhKEchlJGDjw6C9Gn9nC6cqWCaXZdjFSw9o38cxa7B3iuLyl69h6cUemVJXcWigv3VPB1AK78nHyBIBTiZSHBMjNV8nGAx7EmzhiX/qtUygVKgvCzMebwi8Uepys/7W2/KQ7MCOdXV5PUbU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773762956; c=relaxed/simple; bh=Q1bDDOrF2wOLk30u1o/3WHRFCu3v+rlUgESHZeMeR6U=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=f08F4BUOyIvyFPCvukwXKx897oyIxvWe11h19h+bU8XSMlNtwujuotlcMC/DOMSLD/gYqRjYyUgLliGWJkqgAJu5feHcYXLZVc589SGV9KrTzkVO4maTlXVAx8F7AJF/YK+SZy3DMMGbrFdPBRcc4gYxPvHrOg5sCZuxVqHq0V8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=P86317Ey; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="P86317Ey" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-65c4152313fso8317744a12.1 for ; Tue, 17 Mar 2026 08:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1773762953; x=1774367753; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IWDB8KL3PBcEqK0ozqAtIpGnPn1jWzWERBO0Z7aA2SA=; b=P86317Ey+KXN7SOe7hU/YxnYA18iz5JZfIo5q/J0avlUftHGYGGC6jGurClMtFPuCV +0vXMvu/Y7ubBfve13oAui+D80d1az2S8J/BONtG6Bm8485fgUa82zryvRCsm1mfSuiR FUoXkphQR0v7UPVbRWr8/9w95b+xU5tHNd6S3NczOCZpFKr+aWJpxB/V7De/oHQViXKF ZobnBhzNnGSACOLmgDOtkI4O/2brNjz4FbJUlciBQ04t/33PxQ2l4r/quc0/U1+vNsv4 NkUTtoZip1dWrlLqlCbtfQRMpn3qoB/o6/zZ6v/x6KKY85oWIovaJFJCdpHZzUADzpXd qLqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773762953; x=1774367753; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IWDB8KL3PBcEqK0ozqAtIpGnPn1jWzWERBO0Z7aA2SA=; b=GbYTDf0FOUcTJnFDe0mfyOMzKlRBwvdx0YzFnM43dxfJxEYXP3Yz7szGPxwHzwgFNG 4eIQxVmdAaeB0Ss2VQYG69MpSG/GFOGy6MtQzLXPxi2VG8HInByF8tJlbzoNaFdI8lY5 f57924I6Kkr5pOaRWVnxA95q3h4QvzTLQ+hGDh0C+QehSzy2JT66zI0/z85zyXBn+lp8 YLbL4/TdRni1cp71eavgc2TzkpjtoNygMJKd3YvE3jVbdk661mBeV3LBS7+ktpzsKoJA JH9EDaGC9Hlk/XIme3ae3BJuiXtuHIdfiChxjTOVjxYlvda9QVPLt+mWdRF4AlbhYNs0 +71A== X-Forwarded-Encrypted: i=1; AJvYcCVHPTLob5ospWuwPjs7SiP24HmvF9VXug9S9fz3BwuogLVACUMUbpLa+R3vee5mWQ+0v/26eWRFrxHsH7E=@vger.kernel.org X-Gm-Message-State: AOJu0YybYyLefoKIcxp+BOZq3k1J3iEiavCxhWtWWGwfMIzCYMZNICXW yRbGLQdJuXcumLPk4jf9NSo9/kGvd+9eKj6OVHZAeyqMaU0DQaOOq4kfMAxfoG08HKw= X-Gm-Gg: ATEYQzzFnqkKHj66jzGdc5xPIrxQ0QeT8v+LuHPMLBxvifs0sWFQ/Sp/srJg1VuxbV4 DVTbfyqEu+EuCdydkzjTzdF+2HJEPWW9MfOsiYWYth1wnkO7yitGw89JvBqJ+vU68qC/l+bRv7T P29gmztnGoaTqqhcH+k8B+0OJfZgxQqm1S7YFl3cCFDdakNQC/Ud9KDfehhmpAqghesiiRN0iwI oO3Q0xVLM57iQNCnW66mLVe/FMn2FRb8MVa33bV0HpSdYal6gwT8eBr2bj9ly9uZ7PA+lQguuD6 DLMJH1OT+/rXThI+c2PppWFixhB4CMZt8gty2l9wpXLGEpcvEL1WqDJeRI01wOKgCeH4DSGffWW 5q7m/J8WkJfz71F6nMJCsS7mDRXxqoR+K5QLsDIryOTeVg7ubMq4GXVZwV+3XjJsDxYsSnPwtum kGZVdlJNoWR9WKLPJ6VTH66oR22kk7OpHsAzlpQnWvh4m3DHzsZmsPYBWFNWrHmOCAe1iz X-Received: by 2002:a17:906:209c:b0:b97:3376:7ce with SMTP id a640c23a62f3a-b9765153c1fmr602242366b.26.1773762952679; Tue, 17 Mar 2026 08:55:52 -0700 (PDT) Received: from localhost (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f13ee5c0sm15707366b.5.2026.03.17.08.55.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 08:55:52 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 17 Mar 2026 16:55:51 +0100 Message-Id: Subject: Re: [PATCH] drm/msm/dpu: don't try using 2 LMs if only one DSC is available From: "Luca Weiss" To: "Dmitry Baryshkov" , "Rob Clark" , "Dmitry Baryshkov" , "Abhinav Kumar" , "Jessica Zhang" , "Sean Paul" , "Marijn Suijten" , "David Airlie" , "Simona Vetter" Cc: , , , , "Luca Weiss" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260317-fix-3d-dsc-v1-1-88b54f62f659@oss.qualcomm.com> In-Reply-To: <20260317-fix-3d-dsc-v1-1-88b54f62f659@oss.qualcomm.com> On Tue Mar 17, 2026 at 4:30 PM CET, Dmitry Baryshkov wrote: > Current topology code will try using 2 LMs with just one DSC, which > breaks cases like SC7280 / Fairphone5. Forbid using 2 LMs split in such > a case. > > Fixes: 1ce69c265a53 ("drm/msm/dpu: move resource allocation to CRTC") > Reported-by: Luca Weiss > Closes: https://lore.kernel.org/r/DH1IKLU0YZYU.2SW4WYO7H3H4R@fairphone.co= m/ > Tested-by: Luca Weiss # qcm6490-fairphone-fp5 Thanks for fixing, Dmitry! > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/m= sm/disp/dpu1/dpu_crtc.c > index 6bf7c46379ae..96b67ea3fb4c 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -1410,7 +1410,8 @@ static struct msm_display_topology dpu_crtc_get_top= ology( > topology.num_lm =3D 2; > else if (topology.num_dsc =3D=3D 2) > topology.num_lm =3D 2; > - else if (dpu_kms->catalog->caps->has_3d_merge) > + else if (dpu_kms->catalog->caps->has_3d_merge && > + topology.num_dsc =3D=3D 0) > topology.num_lm =3D (mode->hdisplay > MAX_HDISPLAY_SPLIT) ? 2 : 1; > else > topology.num_lm =3D 1; > > --- > base-commit: 50c4a49f7292b33b454ea1a16c4f77d6965405dc > change-id: 20260317-fix-3d-dsc-4b073977ea19 > > Best regards,