mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gary Guo" <gary@garyguo.net>
To: "Benno Lossin" <lossin@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Antonio Hickey" <contact@antoniohickey.com>,
	"Janne Grunau" <j@jannau.net>,
	"Christian Schrefl" <chrisi.schrefl@gmail.com>,
	"Oleksandr Babak" <alexanderbabak@proton.me>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] rust: pin-init: properly document let binding workaround
Date: Thu, 19 Mar 2026 15:18:36 +0000	[thread overview]
Message-ID: <DH6UY7A4QHMM.3GI402M0XOZ9A@garyguo.net> (raw)
In-Reply-To: <DH6U85G4S7IZ.2JBY2FTMVSJB7@kernel.org>

On Thu Mar 19, 2026 at 2:44 PM GMT, Benno Lossin wrote:
> On Thu Mar 19, 2026 at 12:04 PM CET, Gary Guo wrote:
>> On Thu Mar 19, 2026 at 9:35 AM GMT, Benno Lossin wrote:
>>> The three let bindings (in the bodies of `cast_init`, `cast_pin_init`
>>> and the `init!` macro) are used to avoid the following compiler error in
>>> Rust 1.78.0, 1.79.0, 1.80.0, 1.80.1, and 1.81.0 (just showing the one
>>> for `cast_init`, the others are similar):
>>> 
>>>     error[E0391]: cycle detected when computing type of opaque `cast_init::{opaque#0}`
>>>         --> src/lib.rs:1160:66
>>>          |
>>>     1160 | pub const unsafe fn cast_init<T, U, E>(init: impl Init<T, E>) -> impl Init<U, E> {
>>>          |                                                                  ^^^^^^^^^^^^^^^
>>>          |
>>>     note: ...which requires borrow-checking `cast_init`...
>>>         --> src/lib.rs:1160:1
>>>          |
>>>     1160 | pub const unsafe fn cast_init<T, U, E>(init: impl Init<T, E>) -> impl Init<U, E> {
>>>          | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>>     note: ...which requires const checking `cast_init`...
>>>         --> src/lib.rs:1160:1
>>>          |
>>>     1160 | pub const unsafe fn cast_init<T, U, E>(init: impl Init<T, E>) -> impl Init<U, E> {
>>>          | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>>          = note: ...which requires computing whether `cast_init::{opaque#0}` is freeze...
>>>          = note: ...which requires evaluating trait selection obligation `cast_init::{opaque#0}: core::marker::Freeze`...
>>>          = note: ...which again requires computing type of opaque `cast_init::{opaque#0}`, completing the cycle
>>>     note: cycle used when computing type of `cast_init::{opaque#0}`
>>>         --> src/lib.rs:1160:66
>>>          |
>>>     1160 | pub const unsafe fn cast_init<T, U, E>(init: impl Init<T, E>) -> impl Init<U, E> {
>>>          |                                                                  ^^^^^^^^^^^^^^^
>>>          = note: see https://rustc-dev-guide.rust-lang.org/overview.html#queries and https://rustc-dev-guide.rust-lang.org/query.html for more information
>>> 
>>> Once we raise the nightly-MSRV above 1.81, we can remove this
>>> workaround.
>>> 
>>> Link: https://github.com/Rust-for-Linux/pin-init/commit/bb3e96f3e9a4f5fca80a22af883c7e5aa90f0893
>>> [ Moved this commit after the previous one to avoid a build failure due
>>>   to unstable features. Changed the cfg to use `USE_RUSTC_FEAUTURES`.
>>>   - Benno ]
>>> Signed-off-by: Benno Lossin <lossin@kernel.org>
>>
>> Reviewed-by: Gary Guo <gary@garyguo.net>
>>
>> Perhaps we should import review approvals on GitHub as R-bs.
>
> Yeah we should. A quick internet search didn't reveal a magic tool to
> me. Do you know of any?

One idea that I have:
* Re-target a PR to a temporary branch and merge it
* Have a GitHub action that walks through PR in staging branch and applies
  tagging before putting it into the main branch.

Fighting with branch protection rule might be needed:
https://github.com/orgs/community/discussions/13836

Best,
Gary


  reply	other threads:[~2026-03-19 15:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260319093542.3756606-1-lossin@kernel.org>
2026-03-19  9:35 ` [PATCH 1/5] rust: pin-init: build: simplify use of nightly features Benno Lossin
2026-03-19  9:35 ` [PATCH 2/5] rust: pin-init: properly document let binding workaround Benno Lossin
2026-03-19 11:04   ` Gary Guo
2026-03-19 14:44     ` Benno Lossin
2026-03-19 15:18       ` Gary Guo [this message]
2026-03-19  9:35 ` [PATCH 3/5] rust: pin-init: doc: de-clutter documentation with fake-variadics Benno Lossin
2026-03-19  9:35 ` [PATCH 4/5] rust: pin-init: implement ZeroableOption for NonZero* integer types Benno Lossin
2026-03-19  9:35 ` [PATCH 5/5] rust: pin-init: replace `addr_of_mut!` with `&raw mut` Benno Lossin
2026-03-19 11:07   ` Gary Guo
2026-03-19 14:46     ` Benno Lossin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DH6UY7A4QHMM.3GI402M0XOZ9A@garyguo.net \
    --to=gary@garyguo.net \
    --cc=a.hindborg@kernel.org \
    --cc=alexanderbabak@proton.me \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=chrisi.schrefl@gmail.com \
    --cc=contact@antoniohickey.com \
    --cc=dakr@kernel.org \
    --cc=j@jannau.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®