From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2A86378D7E for ; Fri, 20 Mar 2026 09:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773999478; cv=none; b=lcWOSU+RCf7wSzGHOR7m84JF0Jt58Ntg5LFG+x9atk3wEqZ7y4NvbG++D4jBFLFurfOqn4G4D3a9aiO2W72f91eKwdBT1WLjmuNKOTUdbTOfwlM4d3pzCVfulEsRL272XrDS5XpTgTLaWNs42AWgL2IQbpx78d4m0Fg0cMr5CDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773999478; c=relaxed/simple; bh=QCtTxC1DbKyAr5MtMoZcedP52FVPEDU3Ip0bOSd3q9g=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=GB6/3J87zmx0MQsyy6CuaNKaPqNCpw4KJoaWebGti0CtE9ggyAzTSfhXQL663xWn+mxzftNwkRy/f1j6Qmu7GhBEMeFRBiLLdg010mZAahKAyVqzSr6Z6GE9LXEjAjngXByUYBS9fL4mek2kDveIZd5R5qAXNFrS2ehnssOaSg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jte2tNT7; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jte2tNT7" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4836abfc742so3087075e9.0 for ; Fri, 20 Mar 2026 02:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773999473; x=1774604273; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=yVl81zt/GsTfMc0Wx3AiwbjEq6jv51tPHXiJVU3KB5k=; b=jte2tNT7i+KpFkSSfERQZSsahb0dgTXvLfhUjUBi/PXlZKWhuAbmWpPmjYgnbpejxQ PkwfR5YISAp5ZtTE8Uv32nAIhwXTS1c7gdOHmfn1W/NPxgZ6F+iaUrQKnaP44rPp/DFY p6iunymnrfAwlAvWin2R8E4JQXVLB5csCsO+AyQ0KLJrDvszhfliUctG9kEhFkJ0Mb3n 0Z/d7YKYfzhm1sP1Z1iRj7Bu1zHuRMsDPwYroyPRNbYis20ichxPj0UG6h+Rol+30c9y sZaXbi0BlZIb+i/VFd4IBfsLkY2nAWhE6SmBeQPKjsCqE+zpoi8O1NG9UZ7p6XV8uplo 5tHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773999473; x=1774604273; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yVl81zt/GsTfMc0Wx3AiwbjEq6jv51tPHXiJVU3KB5k=; b=BRHDkRULXOz62oQBBAnf6EEhTjIQGJUYojh25p3b/fBuUpPBG3kdUPbbVkbxKzouG8 o1B/ExS/WRNpJTOgDunZ/wQ4Ue1en8JVSILUaYQ7ooddNlva24MiDrgRY7bEM0MAVkNg V0pWzAZmP8aNhm2UGKeCebtMP9mAUQJf5dpmvHyjBXB8cen4r8z2NpwcjdUg7p5Tawfx 11CeCY15+kaGOs/nsWtvJDIL9x1437oqYUGKmFHG8NcR0hW7IBhVHtjYEYPEjBfQ03qd DrufNLtGivFbl8IBFT1PAA5YB7iOWJOgI8jpFiqGPmZatMYVQL2EzpDD9OS75VSLdcu5 0g7g== X-Gm-Message-State: AOJu0YwxiWbaSOwQgNcwEyNfJR/nEsGX2ZHgi4Q1A7Su4VQ3Rt2Pxdi8 UQJPdT/foV72k+AvzjnaURBMSw6GzlwP29pIXYJh2PDuvEnOY7+EWiiDxnBtDy/WjSnDeHugq+i 9+6z2we+ZIyS7uw== X-Received: from wmbc24.prod.google.com ([2002:a7b:c018:0:b0:485:6963:6c9c]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:8583:b0:485:3f1c:d8a1 with SMTP id 5b1f17b1804b1-486fedb9631mr28002685e9.9.1773999472816; Fri, 20 Mar 2026 02:37:52 -0700 (PDT) Date: Fri, 20 Mar 2026 09:37:52 +0000 In-Reply-To: <20260319-gfp64-v1-0-2c73b8d42b7f@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260319-gfp64-v1-0-2c73b8d42b7f@google.com> X-Mailer: aerc 0.21.0 Message-ID: Subject: Re: [PATCH 0/5] mm: Switch gfp_t to unsigned long From: Brendan Jackman To: Brendan Jackman , Andrew Morton , Michal Hocko , David Rientjes , Shakeel Butt , Vlastimil Babka , Suren Baghdasaryan , Johannes Weiner , Zi Yan , Harry Yoo , Hao Li , Christoph Lameter , Roman Gushchin , Uladzislau Rezki Cc: , Content-Type: text/plain; charset="UTF-8" Human summary of Sashiko (AI) review [0] [PATCH 2/5] iwlegacy: 3945-mac: Use special gfp_t format specifier Just identifying pre-existing (and low-stakes) issues in the code. I can add a patch to fix them up. Andrew, I think it probably makes sense to merge these cleanup patches regardless of the gfp_t change, as Zi said. Would you take them through mm or would they need to go via the more specific branches? [PATCH 5/5] mm: Change gfp_t to unsigned long - 1 << __GFP_BITS_SHIFT needs to be updated to use 1UL. - Need to update userspace tools like perf. - Says I can't use unsigned long in module_param_unsafe(), which I think is true. I did that to address a build failure, maybe I never actually repeated the build? Other patches got a green tick. [0] https://sashiko.dev/#/patchset/20260319-gfp64-v1-0-2c73b8d42b7f%40google.com