From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f48.google.com (mail-yx1-f48.google.com [74.125.224.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C7D4194C95 for ; Tue, 24 Mar 2026 02:47:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774320465; cv=none; b=HxhMncgxX/VsNyNC+GBLZuKJ8GU4UttgB+v+AL4UsXghRKt85lLCWdsO5L6z/1JlzqtQ10nIsxJ1VX6wfd9DY5gzHwxS7c3Tgns30gp+ZmuK2sd5TXvVbUxe5hDckbLZe3diz2vZlqRupc7e7ST5nNkYQY+r0Xc2cUdvlqX7fxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774320465; c=relaxed/simple; bh=yeeCIoqZ+lYu/DvgKoHsQT9AtGbfF2MWmD4iMNl3Y2k=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=mt9JptiqBNwnxIC8OTKHiMA2dKxX55nGFbCQFNVfNxT7IdyfrPKVHqpxktrMeUgszoACRo5vmLYikThyG++cnvPvMCdr2VP5nCZkp6IqUP+DZr0UAmrlHf2h8lkgdKyo+JaQXQ98qdjKHFtk/IyxQgn/4JfDMN+rJJm40BrB2gw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UXP5Jbfh; arc=none smtp.client-ip=74.125.224.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UXP5Jbfh" Received: by mail-yx1-f48.google.com with SMTP id 956f58d0204a3-64eb7def21dso828468d50.1 for ; Mon, 23 Mar 2026 19:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774320463; x=1774925263; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=M7EiGPUnrspLxPPAsH9F/JNfnic9cFN4hpn5/2DF05k=; b=UXP5JbfhUvXdjrarj33oJSy+PcrbGNYwDFL7pAvDk80+3N3ejEs92hk0PPFdpcGGhD e09ZwIVE92dWShHL+PLB8t9t9w1rgcSLIJEO+F2hRLopvCCwqD5FRgPAxcq8OdmXuM5i hEgXV0pGNHbsZ4OR3QARicoPJjiVj8cDdy9xP9INR2W+RGXWhKVJGnF/Phfho8fzi694 P2UxVvpY8wrXkr64YZ+qhnn3PIu9t7I9wrEKRJIccFNaTwtDxA/YMY/nq4UNFrVzU8s2 rTdd3gG5JPHOnSk2OIyf94lSpDbcaiW8XsyvVsBcIRZT8uJMtogI3bpb8m/4fdAtoTcq sRvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774320463; x=1774925263; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=M7EiGPUnrspLxPPAsH9F/JNfnic9cFN4hpn5/2DF05k=; b=Ph0Ip3UpJK9lSYOGjKtmLHKmjxm8TVnGHmvCep10dQg0ur9YY0Yh3TI89fVJB3kZn/ WZln/yqsQR7l/8WnqpSw/wsiH7TzW7o+HtF1/UWYzzfUOwtBP6Q+F5OyTZOZAHySXQpe 3XaLmYH9k1yp06JNABF/8P+55B6WfvNpZjMhZFuD1o4syPM78GqI2oDntCqtA9KxVZLn gGdJqmkcCFSN780drigY9hzMU63kUfX814f73zu9xp5bHCcNWB9C9FMX9Ias9sseZ4YW uQ1KycE6K60kyYeJwIWfmpnn7fLcmpq8nvKFMvRJm2HEuKzWj6l0IjuZ8qejcEImYB2P Yt/A== X-Forwarded-Encrypted: i=1; AJvYcCUB6YGYhFkkOQayOxt54cEhYB6bGFWM/eDRp+BKtglDBf+9jlobrh/+hnHN4Z1fOhAaHYGEg7cjTonJmKs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1beOppUNx2JlaRmEUSKWWXW53ZtqokbUfv4f4fgiq+xSfkVR1 ZfUUU/Du+O0gDSb+XmpfpGLAXxItGW+GFtBqNPXV47Ici1ncs1b202VD X-Gm-Gg: ATEYQzwBSZZ4JZDUPDQ/4DjmTRg+gwd7Vqee1RRHtuWkmvci28jjKfO1nw7su831q91 rerq81BJxWQntZ/Rinytd6LJWTKd59ayRVhNilQnw94X2BY4GIo2UJSFKtSmewdaMGNon7AtAcw 1Uaf+TBTrWqhsYXoxP3V5px/fNPJNjbhcMOmW6RShivSSIVW4Ae19vj/Sw2TRupSLaf44nXP0Pi APezkcU+VMdteYy2kUnYHRrUPsOOar/iMcwj/MvmK1qSLWTTSC0wTXobdCkX+7zhoGL62Zugflu 8zOqFxAlmhlPK6AvJzXnkq/GCCJx/wUOu5+oLJjAXiEWXHG+cSQelTrvxbLJQW2lig/2Ylr6PMG nLTjkFoAcXKt5OngIioxiHAZ83LmRqDm90mAGwbs97HMogLqYigoew/gjSe7Pjw1fn7PKPlxGCv ik/amUBeciZV0rwbO9Wq13C5g/GaXkIdq8/+uuS8h+HxbcRwIYXr/0yyT9cPnWYGtSdIR//TgDb eEtdoht//2xqzmkQQWD82He13e8D95i X-Received: by 2002:a05:690c:102:b0:79a:7e0a:57fd with SMTP id 00721157ae682-79a90bf7b42mr150149137b3.45.1774320463207; Mon, 23 Mar 2026 19:47:43 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79a903a2bc6sm66847307b3.5.2026.03.23.19.47.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 19:47:42 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 23 Mar 2026 21:47:42 -0500 Message-Id: From: "Ethan Tidmore" To: "sajal90" , , Cc: , , Subject: Re: [PATCH] staging: rtl8723bs: tidy logical continuations in xmit_linux.c X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260323191501.40269-1-sajal2005gupta@gmail.com> In-Reply-To: <20260323191501.40269-1-sajal2005gupta@gmail.com> On Mon Mar 23, 2026 at 2:15 PM CDT, sajal90 wrote: > --- You must have a SOB here above this line with your real name. Also, you must have a patch note. ... > - if (!rtw_mc2u_disable > - && check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true > - && (IP_MCAST_MAC(pkt->data) > - || ICMPV6_MCAST_MAC(pkt->data) > - ) > - && padapter->registrypriv.wifi_spec =3D=3D 0) { > + if (!rtw_mc2u_disable && > + check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true && > + (IP_MCAST_MAC(pkt->data) || > + ICMPV6_MCAST_MAC(pkt->data)) && > + padapter->registrypriv.wifi_spec =3D=3D 0) { > if (pxmitpriv->free_xmitframe_cnt > (NR_XMITFRAME / 4)) { > res =3D rtw_mlcst2unicst(padapter, pkt); > if (res) You fixed the logical continuation problem but the alignment is still wrong. It should be something like: if (!rtw_mc2u_disable && check_fwstate(pmlmepriv, WIFI_AP_STATE) && (IP_MCAST_MAC(pkt->data) ||=20 ICMPV6_MCAST_MAC(pkt->data)) && !padapter->registrypriv.wifi_spec) { As you can see I removed the "=3D=3D true" and the "=3D=3D 0". Since you're editing the line it's best to remove other checkpatch.pl warnings. Mention these are removed in your patch notes aswell. Thanks, ET