From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AB88285066 for ; Wed, 25 Mar 2026 06:35:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774420529; cv=none; b=vC7Rd5smHF2Bkb12HIIDPY2NvFhxO2BGyZuqjXaRCT23PnVN9SZoaRc61LNW/9eHAG1gHzLKgMHu8h3xNNw4sIRpkvJDeb19xCqSR8w3Nk5L6DXXzjZntZkXG6y2hDQsckYgV4uaueuVxysbEvbazsqvsCol0H3xAuG4nNRNNOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774420529; c=relaxed/simple; bh=enRmiZzFY7ZSDKwHVRqjzzPEJ2fLjJuj2O8TfjEEIN0=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=pdpcVCSzj/SP0Fu8eb9hhSjQJoaOh5iB1818F50Is5akVFVPd0xeOy6n4t6oviv2OAMMj6k5dxK2Hyj7xMlig5PloAXCwfxPisDFuYHoFiqty92aun/UQ614bZbR0CAiHQr4MBN9Vc90y0rFD7+iiwXm2+/xdXXm+1vHOcMYGd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=IUcXR7VE; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="IUcXR7VE" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 802A24E427E8; Wed, 25 Mar 2026 06:35:24 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 2E561601A1; Wed, 25 Mar 2026 06:35:24 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6AB151045133A; Wed, 25 Mar 2026 07:35:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774420523; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=enRmiZzFY7ZSDKwHVRqjzzPEJ2fLjJuj2O8TfjEEIN0=; b=IUcXR7VEkEcm7Khc99r2rl8qYegHD8WP0AJ31dIcYkW44hN3J3AhLRoSBN89yleiyFRWgs BHYlXW4JU+mqZz3soF8hw6Khux+XB4Lg1xu9kzBRMzN8tNLHQtxTbx8+Bds1O2R2J29/T8 IbdVlXc59Slydk7ZgA1nvi6sDGAkOjF4VpbqaLh2KmLIWivWQK/+mn1xDrnHDAZ7djMrBw snNbNAEytUpzdGPnN8v8rhSCFLG5u4M6rsBhXsJssLVcyETq0KgsNgiPJZ6LEuv00t3H9G iBwAESRtx9mptz074bN1hZQYKK9g0CEkeJOUNk6uXvOYHUHsiVY/51fWerzvlA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 25 Mar 2026 07:35:12 +0100 Message-Id: Subject: Re: [RESEND v3] drm/bridge: analogix_dp: Reuse &link_train.training_lane[] to set DPCD DP_TRAINING_LANEx_SET Cc: , , , , , , , , , , , , , To: "Damon Ding" , , , From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20251111022103.1350183-1-damon.ding@rock-chips.com> In-Reply-To: <20251111022103.1350183-1-damon.ding@rock-chips.com> X-Last-TLS-Session-Version: TLSv1.3 On Tue Nov 11, 2025 at 3:21 AM CET, Damon Ding wrote: > In analogix_dp_link_start(), &link_train.training_lane[] is used to > set phy PE/VS configurations, and buf[] is initialized with the same > values to set DPCD DP_TRAINING_LANEx_SET. > > It makes sense to reuse &link_train.training_lane[] to set DPCD > DP_TRAINING_LANEx_SET, which can remove the redundant assignments > and make codes more concise. > > Signed-off-by: Damon Ding > Tested-by: Marek Szyprowski > Reviewed-by: Dmitry Baryshkov Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com