From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 094E41FC0FC for ; Wed, 25 Mar 2026 12:20:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774441230; cv=none; b=c86Rk3LRx2/TmPVTf1SKfEejdjrkiWJLZnPJgQwrus2kZmM5yc76gKasn/HJfzVCmgHdiG7RmGAEVgKniv4XpadFVUdE8TjCkZidO38QY3UR6DNdDKoI+NA+h0vPwGAv6dGpky81jQgNwo3VdTW9Uy/0JETZtOOmVbJw6RdmWJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774441230; c=relaxed/simple; bh=jlGPOFbymv9J890AcuBJZQuRoUh9mbqsZ2ucu9fgzu8=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=VHzL2Dus38vg0x/1JlGpB49Exfd5Mifg/FGvQLjC66gDmKcc2dB8hQ8GCsYj4SMBENG8rT8JnLL9G3FbOGJbFgtQBgcXJlRfMqrEneld62elk0wL8D1+yqa7yHM7kttxsESoC1th0VlVNZVrZSztp/v++AoUC/AtYR3JGEr9e8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ZyMuWh95; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ZyMuWh95" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 54A3B1A2F86; Wed, 25 Mar 2026 12:20:25 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 16246601E2; Wed, 25 Mar 2026 12:20:25 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1AE2A10451319; Wed, 25 Mar 2026 13:20:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774441224; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=g+jmFeA6jzlNGtF0WXjqDu9dIuu0/sgxhpz0DmhaSe8=; b=ZyMuWh951X2FL5ShARtCitPlnGr39QwxtrIMp3rTfAS3mIslGWIoD+LUJEPbR24PPjDO7k kRRVNkPDCIf1ckBQuoo4EnjkB5JEKlXnUxIQm/l7XB/q/Vt/1Im6lEXbpoJJk7urEM2g6m HCVWNrBFa9MRifRBIp2UpWJtR6d8kkLM9uJpI7TF/EubnpOMyfbQokPeYh+zSgn4nXBFal STra8cHbHWcE4gcAaMOs/EoUsnLO1K3OG1iKHmx0S6PaFm6WCsV/e4lc9OF1yuyW+GC8q8 EYuWHTHd+OpyY7gi4y/M8bqBlqYNxlGixYLLm6pjcQGde0IdeRzalCaQOCRIJA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 25 Mar 2026 13:20:15 +0100 Message-Id: Subject: Re: [PATCH v3 2/4] drm/bridge: analogix_dp: Apply DP helper API drm_dp_clock_recovery_ok() Cc: , , , , , , , , , , , , , To: "Damon Ding" , , , From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20251110085823.1197472-1-damon.ding@rock-chips.com> <20251110085823.1197472-3-damon.ding@rock-chips.com> In-Reply-To: <20251110085823.1197472-3-damon.ding@rock-chips.com> X-Last-TLS-Session-Version: TLSv1.3 On Mon Nov 10, 2025 at 9:58 AM CET, Damon Ding wrote: > Use existing DP helper API instead of analogix_dp_clock_recovery_ok() > with the same function. > > Signed-off-by: Damon Ding > Tested-by: Marek Szyprowski > Reviewed-by: Dmitry Baryshkov > @@ -398,7 +385,7 @@ static int analogix_dp_process_clock_recovery(struct = analogix_dp_device *dp) > if (retval < 0) > return retval; > > - if (analogix_dp_clock_recovery_ok(link_status, lane_count) =3D=3D 0) { > + if (drm_dp_clock_recovery_ok(link_status, lane_count)) { It took a while to realize that drm_dp_clock_recovery_ok() really does the same thing as analogix_dp_clock_recovery_ok(), but it looks fine. Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com