From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DC9C2F6920 for ; Fri, 27 Mar 2026 15:07:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774624047; cv=none; b=WOpU6usHs/ADB5fc2IsxTHV2iL5Rgr39wLLQ9pFLPTTK53OknqRBhBM2/30GOgCholh9T3lGO64u4oL7tHQXbkm+dBp2G376oBx2BmvPk1Z9LlqYIKyH/VhixKyB/MWLNByTZTdn6rOEyE7UvfIxsOd3vYa29Sxr6e4F3ah59Wc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774624047; c=relaxed/simple; bh=/kUhKxLK/HiVTHt4C8gogYYLUmss6aq6IAKcvjyBAL4=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=YCn+4NFMoZSgJHfmqR6V2E20CpsJqeIoNw7cP8RDiipGdBomN9VIEQSvN6G3mfNBxPUopiANsabkc4xQI5v+aaY65dIB4Ma4L8WlvgGo264e+ePyJjtD7Fysztl//mHGyE2ubK8OPCtcEPG5H9PCEod7fC+e4sob8fYZkce0oIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=Pgd+tgAW; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="Pgd+tgAW" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-66132b22182so3159272a12.2 for ; Fri, 27 Mar 2026 08:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1774624042; x=1775228842; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+CkqBk2g+EWPQvgPZYgq6UuU0Pf+l3NHDnxqGjySmmw=; b=Pgd+tgAWY5Pk54v9PDgG4uwFTWfOTolPA9ulQ+wQKmgJD0oOAyrkssWFF5oroXJRw1 N2KQieJFkZjR9exXtUpXpft/27H6ecefXLGWREVPlpDu2/dm8dMBsFcSA3ZmVEoHkfV9 jyQ1/5enB3VB/iygFkMJClW/uimFxxgDL+5suPesYfuaTMvqe3JkoXAFASKdkt7wIkHX N4wELA5mgR93PZREUtXD8XJ68gp77EWMzcpV6e6S8csrGQTyUZfKilzEC0CIX9zDfikJ NleNsHQ+VXuXF5fulJOAper32NkRlvnHfbFQqYBiSJ6MaUjQw5NR1wONiQ6EW3KwhwLl vvcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774624042; x=1775228842; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+CkqBk2g+EWPQvgPZYgq6UuU0Pf+l3NHDnxqGjySmmw=; b=hFrFpx69EB3yKLqHHZWei5GWxexV6RbkxGzyyWqzc1TagWyOm+npWTkSLBW5jr6Q4R 6Uoli0IXg+8rXCKiuP+T8XgM2E2nzNZ2Ef9KFrOqjfYCEw/N3u/JrmKO3z9RQV4S7xz9 xpm94INpg96cccAc5QXgQ+tAcxREBq6RndzkhdpB97mEc30QBTSn/qxf4mGWlPMYFu4u L1oyA33bSBure/v8kMlZ3aMldQK25/9Br5F+cYwwTRqztuQfpQLRnz8KA50fmugVtwvi UQG0LrKEq9p/9iNzSKdX/kacyU7iqqPSUb8fVc/ydfCBMfxkEO5oVltrVd1OqrRaPLDo tQZw== X-Forwarded-Encrypted: i=1; AJvYcCUBiCf39+zzJwWanxqXwPBJtvxRQrcxpv1eHR2ymuO6dddbWq6XZgG7HGpvhS/ma3SAL6CHkhDZKGRHZrM=@vger.kernel.org X-Gm-Message-State: AOJu0YzdOx7qs7PBaUHv79ajxdV5Dtrsi3v3qXjZ6jcxCYn887mFHcWb T0DN1Xk6Y5SR/mvtK3VH/oCPqxSYJYpXWcPvjxMUpaJpyZg8GQ+UK2moSXRXfHdxGjzR3KWF6aK aM6JuJe4= X-Gm-Gg: ATEYQzyHVhugce89Lvz0NnMgyZcPlp1MQIModuUBmTDalsUFBcht08M5Q1PcGPP/0kJ AuoOHiZah86kDvgXOHU/lgAxCrSCr60Ccwf9qkK9Mws6D7kblN//YJHx/hmOURR99PQtYEcDiL4 uEepnsmboPNcCtY0n9MJiJeSyvJGxhI5yhFEP5xgZhYNWdTlLfrw5Fo8QvdOY0CA3Dr5MGQ+uG0 Zyxh1g9R3Ado4HcGiRPvPH0LdgrsTsqcgqoKLVn3bhlZ2Ii5rEfJSa5jtgxIlDAnAQ1BYFiLFFX wh7ECEfApAQFS45poUI+MA8AVxiX4b80j9UC/GMrhYt8Fzb1i+wngBHqqYfErgNiC8zafNMtXHe fqCBo5RMmohBAHV2z1zNhUY0zN65iq+YU2aRrtfTLs8V3UlFzbMOPNH7MAet+FEdt4UPJsMYrv4 MMOEgzMqI+OnlErIxex8gohxFPy3KTc7KCU4K4zdX5B7Y3D28/DHFY8RRYueFeYPydhkLB X-Received: by 2002:a05:6402:52c7:b0:662:ab67:a560 with SMTP id 4fb4d7f45d1cf-66b28c526dcmr1637141a12.24.1774624042436; Fri, 27 Mar 2026 08:07:22 -0700 (PDT) Received: from localhost (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66ad5e3bb1csm2337411a12.4.2026.03.27.08.07.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 08:07:21 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Mar 2026 16:07:21 +0100 Message-Id: Subject: Re: [PATCH 2/3] arm64: dts: qcom: Add the Lenovo IdeaCentre Mini X From: "Luca Weiss" To: "Bjorn Andersson" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" Cc: , , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260325-ideacentre-v1-0-768b66aaef30@oss.qualcomm.com> <20260325-ideacentre-v1-2-768b66aaef30@oss.qualcomm.com> In-Reply-To: <20260325-ideacentre-v1-2-768b66aaef30@oss.qualcomm.com> Hi Bjorn, On Wed Mar 25, 2026 at 11:34 PM CET, Bjorn Andersson wrote: > The Lenovo IdeaCentre Mini X (Snapdragon) Desktop is a Hamoa-based > ultracompact desktop PC. It provides HDMI, DisplayPort, USB Type-C > display outputs, 5 additional USB ports, Ethernet, dual NVME slots, > headphone jack, WiFi, and Bluetooth. > > Introduce a DeviceTree describing this device. > > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts | 1199 ++++++++++++++= ++++++ > 2 files changed, 1200 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom= /Makefile > index d69e5f3132c4fd3fbf1ac90e83adf6af6b104a93..fbbec696ac161af42c18acc34= 4a228ba461f65a7 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -21,6 +21,7 @@ dtb-$(CONFIG_ARCH_QCOM) +=3D hamoa-iot-evk.dtb > hamoa-iot-evk-el2-dtbs :=3D hamoa-iot-evk.dtb x1-el2.dtbo > =20 > dtb-$(CONFIG_ARCH_QCOM) +=3D hamoa-iot-evk-el2.dtb > +dtb-$(CONFIG_ARCH_QCOM) +=3D hamoa-lenovo-ideacentre-mini-01q8x10.dtb > dtb-$(CONFIG_ARCH_QCOM) +=3D ipq5018-rdp432-c2.dtb > dtb-$(CONFIG_ARCH_QCOM) +=3D ipq5018-tplink-archer-ax55-v1.dtb > dtb-$(CONFIG_ARCH_QCOM) +=3D ipq5332-rdp441.dtb > diff --git a/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x1= 0.dts b/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts > new file mode 100644 > index 0000000000000000000000000000000000000000..cc90cb58a9c17ad166dd641d9= bbc03b7df5686a6 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts > @@ -0,0 +1,1199 @@ > +&remoteproc_cdsp { > + firmware-name =3D "qcom/x1e80100/LENOVO/91B6/qccdsp8380.mbn", > + "qcom/x1e80100/LENOVO/91B6/cdsp_dtbs.elf"; > + > + status =3D "okay"; > +}; > + > +&smb2360_0 { > + status =3D "okay"; > +}; > + > +&smb2360_0 { > + status =3D "okay"; > +}; You have this smb2360_0 node enabled twice. I checked this AI review thingy to see what it's saying , and while most suggestions are probably kinda useless, it did spot that bit, which I thought you may want to fix in v2. https://sashiko.dev/#/patchset/20260325-ideacentre-v1-0-768b66aaef30%40oss.= qualcomm.com?patch=3D10329 > This isn't a bug, but the smb2360_0 node is defined twice. Can the duplic= ate > be removed? Regards Luca