From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DEAE3624A7 for ; Tue, 31 Mar 2026 17:48:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774979314; cv=none; b=WR5/SJwL1noymmaQJCvPwf5ohU3LpFWwu0U/Cy+7MixD6Uzsm7NgTP9/uF9ySGiCT+fV2rugE/OFL8LtZ+dNz5+cUyWIrfJ/z65/YERutRh+kSemOjcmfp9mhVkLPY/baFoLJ/C7VO/vQkWS6yTCW2NX+CnacRQoSLeM7+F3WoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774979314; c=relaxed/simple; bh=yInp3jQ2nfEc1FkUQ7qUyW0p89IAt5AFdaupsLTGINE=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=uijVzSdT+DumkWvOaC28TP0B9pcC/NCcG8ouYb2v10LEBKwpOeiGxLJk8WMBRbYN8/uGU8O/MUXNugu9sgn/XCG4yjquVgtmIrkMuD2rN69fEyrdCd3Yjl+Uxp2944drhqbKK9L+94x5NqVPyGR0+AXv7I7xMK/S7IaHFFaVvs0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IgBJukjV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kKFk9Vin; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IgBJukjV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kKFk9Vin" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62VGdaqG3240141 for ; Tue, 31 Mar 2026 17:48:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9tkluilWSFi/zwAvCgNgh5sc8znVExg6yAujw+zfcHE=; b=IgBJukjVHVlVxAeC uka8zQLMz3Hpa6J1fgfMtCBZI89mTZ68ZtodlMEERZAKZUcKVnWH2l//Tha7AD1f WJiujnb3gxO/PKyKDmp9G/vPf5MR5sA9PDr1GksgOsatL2SsqGph9AArDf6S8z8/ 3LhvgwRX/pBIY9Gef6MJTWA8nwyImw6Wy+Cl8dhw5lLukZhh0KKPCWQgYtFC53bv MESSzTiyrq/ozH2s9JhocgnIsND7Lsq38ZOvTw4BgrCOb+iHWVpOic3FVqhhpmSF sUnufd0QpedVrTnqkCXm7EzO8vDAMTO7aJOwphbYyvy+uqWOaAZ9MrSAlyztHnLn oVnf1g== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8b1ytb1q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 17:48:30 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50b274f94f8so3964161cf.1 for ; Tue, 31 Mar 2026 10:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774979310; x=1775584110; darn=vger.kernel.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9tkluilWSFi/zwAvCgNgh5sc8znVExg6yAujw+zfcHE=; b=kKFk9Vinw0S46ZZzfQdwoSuNHmtWwBjkBNLQ19DVjmh2zaDSEWhtFaAdNbiSr+1TIl PjjCFCNHqNiXMycSLUbdwJPegn1/LLmhrrNS+wuqYeYLKnWzOBIwy+Kdl1Mkqoif0dky eqoHPLMPrcCSF3LLeIkW1L74a+uwlNYfF20csedkmUt4flHpksFK8TJYyHn6KpVwa/jQ yUX0iUyPT6bi7AdYVhxnwK4liqb4rV5wIjlRFXwjkWf5wdH7bfCka75Aozfnl7tRCSId gZtYN7X6R5YdxPlYUBk/fVA6Wqv7Cpv2BzlPq7id2BKZ29tVU36p+qGlz0tpr/3lN55C CA3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774979310; x=1775584110; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9tkluilWSFi/zwAvCgNgh5sc8znVExg6yAujw+zfcHE=; b=QVM9nx+HUYqAs4WqFR6gXztBFc3kwWM9NDfIGHLA+1edD4OQv2Xcs/KbkpiKLDa9QZ OBNWzoGn7CmzSMkiapaLmfBdyTd0gWWOGV+veWUC9Kw89I8AQFxtbZh+FMgcx8/ppevx 8GruUxleJuMUvrsQ7IJFxHTEtrYoG8gjyVPhpVPtN3OwbgDzGEA1AJSBMugTlGOSPeFK KXaUzkV1PeoPBctZDscPnqrvvFO+OyeMAGJDcUo9ztpJIU2wUG8ERGwLqjupaL880C8G +2mkBXBd20TntwBOBd/LBSIvWiPoD3ovhasKLMJfq3j2ainhYOlGE9Kdl7kn4cXH4bMV CFJw== X-Forwarded-Encrypted: i=1; AJvYcCW0pTrD6Y93TYbD3iESN6m8M7iu2jKju4m3j8ojXexySNKHSlsxjilBgPxuRqAi+fc8ERxMTy8RJU8yDX0=@vger.kernel.org X-Gm-Message-State: AOJu0YwpzcuphwedQWENUSG2FTIBABR2ZVgeRXNvActMK6jwP01Vsvp+ z1tQLYCxJO7SCNKDXuFFklB1qyrKHBvc68IDyWdoRLRggi27AxnfLbvUf8y/dPdEbZ5S7G051Yg bx30h0yx/nPZTBKcuZuQZ+PEcPzPhe6uHG2EcKAnj170yPllPDURwMA7elRzUgRDtU/0= X-Gm-Gg: ATEYQzz/gp86/s4jZJV7TrsrlRzO3oCVkV6+pLmfU0gH7qntIGDlYt85ol+k81+v9aW S3Q3dHx677OwB0L9svw2k8W1PFFX1wYgt/UQ0eZ3xBpSgiIHun/Zbe1oA/I5KpRRMUNawB+QogD UrVAxRBiFitoqXqEF/TveQwRJZ8YIQucCAE7SxVvAOAjcfZQyBWVUf+Sc/i1HjS+lNNKaw+qpLm 8MJqeCYbyHTK9J7TjO1HPYPOo1FKxdI4pFPFo9l1NfOgO6v8F8FJvjvkvQAdLDgj/de9Kpv2sqq w3UYhopgaMRWG9uRXH/zgw/ayEs8EzwLTCJY0G/KbsjPiP47DX+pKCJDgv+l8bQf1qp/NGx84jE M0rw6gdU0YOI9dW/85RB5xoVnL6fNUlnkzBNrwOOA81Gq3SpD+BMU9oDxHAFm X-Received: by 2002:a05:622a:a045:b0:509:144a:43bd with SMTP id d75a77b69052e-50d2c5b718bmr43350731cf.3.1774979310200; Tue, 31 Mar 2026 10:48:30 -0700 (PDT) X-Received: by 2002:a05:622a:a045:b0:509:144a:43bd with SMTP id d75a77b69052e-50d2c5b718bmr43350401cf.3.1774979309635; Tue, 31 Mar 2026 10:48:29 -0700 (PDT) Received: from localhost (ip-86-49-249-15.bb.vodafone.cz. [86.49.249.15]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c091331e0sm50383566b.8.2026.03.31.10.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 10:48:28 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 31 Mar 2026 19:48:27 +0200 Message-Id: Subject: Re: [PATCH RFC v2 08/17] RISC-V: QoS: add resctrl interface for CBQRI controllers Cc: "Paul Walmsley" , , , , "linux-riscv" To: "Drew Fustini" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Alexandre Ghiti" , "Samuel Holland" , "Adrien Ricciardi" , "Nicolas Pitre" , =?utf-8?q?Kornel_Dul=C4=99ba?= , "Atish Patra" , "Atish Kumar Patra" , "Vasudevan Srinivasan" , "Ved Shanbhogue" , "yunhui cui" , "Chen Pei" , "Liu Zhiwei" , "Weiwei Li" , , , "Reinette Chatre" , "Tony Luck" , "Babu Moger" , "Peter Newman" , "Fenghua Yu" , "James Morse" , "Ben Horgan" , "Dave Martin" , , , , "Rob Herring" , "Rafael J. Wysocki" , "Len Brown" , "Robert Moore" , "Sunil V L" , "Krzysztof Kozlowski" , "Conor Dooley" From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= References: <20260128-ssqosid-cbqri-v2-0-dca586b091b9@kernel.org> <20260128-ssqosid-cbqri-v2-8-dca586b091b9@kernel.org> In-Reply-To: <20260128-ssqosid-cbqri-v2-8-dca586b091b9@kernel.org> X-Proofpoint-GUID: rbUN2t-yqd03EAtfrKQIBG18FddzwSOg X-Proofpoint-ORIG-GUID: rbUN2t-yqd03EAtfrKQIBG18FddzwSOg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDE2OSBTYWx0ZWRfX2nlh61l35FIH 5R8GekFbMijRmCmHTpMjrAuaV9t2s7WNFNRgVTVD4KflovKl+UU64buVqA35kMTGpnmu8C/Z8NB ZYQl6scixx3hDDlhQ30xHLpoVNShS9OYlO2FDU6ner9ueY2kw8vDSaEgczzhtB6Db2r7uRxaEo7 PXjaDnufNo9VnluFhWtlQNE5HBEyTiAbd9MRT/XFrF8rnuqVMxoOz2NLC37Lhp67QLzs54qZzB2 Esja4ezNyLfEmpWtKNmd0JLPnjfjf3HE3rfT1dJxh2I2jGRAz56eE6InVvcinYO7AodwHft8oEW XAxpkcABqVCYSJJ43eAbYoQjhmCmPIrCcNOIm5ztj/v1RNtr7eQYPE1INssH84P4Ed2ICOYFjxT FOUy0vKKgSRhKu5oLnLzKhgrKZAydpBxm77rdqsdunSiebTfMK90U/0DihIPh/X26euyslwbM6/ pjWF1q6QAwXrKJo5l8A== X-Authority-Analysis: v=2.4 cv=aJT9aL9m c=1 sm=1 tr=0 ts=69cc08ee cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=fuErIE+P63Icv3tqjtEZBw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=IpJZQVW2AAAA:8 a=1RoDV13bKi5nvpdD3ZQA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_04,2026-03-31_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1011 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310169 2026-01-28T12:27:29-08:00, Drew Fustini : > Add interface for CBQRI controller drivers to make use of the resctrl > filesystem. > > Co-developed-by: Adrien Ricciardi > Signed-off-by: Adrien Ricciardi > Signed-off-by: Drew Fustini > --- Hi Drew, I have just a few minor comments as I noticed that you plan to send a new version soon, so I'll try for a review then... > diff --git a/arch/riscv/kernel/qos/qos_resctrl.c b/arch/riscv/kernel/qos/= qos_resctrl.c > +static int cbqri_probe_controller(struct cbqri_controller_info *ctrl_inf= o, > + struct cbqri_controller *ctrl) > +{ > + int err =3D 0, status; > + u64 reg; [...] > + ctrl->base =3D ioremap(ctrl_info->addr, ctrl_info->size); > + if (!ctrl->base) { > + pr_warn("%s(): goto err_release_mem_region", __func__); Missing "err =3D -E...". > + goto err_release_mem_region; > + } [...] > + ctrl->ver_minor =3D reg & CBQRI_CC_CAPABILITIES_VER_MINOR_MASK; > + ctrl->ver_major =3D reg & CBQRI_CC_CAPABILITIES_VER_MAJOR_MASK; Major version is shifted. > + > + ctrl->cc.supports_alloc_op_flush_rcid =3D (reg >> CBQRI_CC_CAPABILITIE= S_FRCID_SHIFT) > + & CBQRI_CC_CAPABILITIES_FRCID_MASK; FIELD_GET() could be used to make the mask+shift pattern nicer when defined by GENMASK(). Thanks.