From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f47.google.com (mail-yx1-f47.google.com [74.125.224.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73B5F1E7C03 for ; Wed, 1 Apr 2026 01:40:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775007607; cv=none; b=gAuWVFCfic8Gn4YwiojAO429vwRk7D8lM36QfxzLbFMsegIKeT/ut+DgeeMdo+9v+sd+00mFJzpEF3cSH2w6XnOVFfd0+ey4R6ybgvsX5ZfhChw93698EUF5bxFMMJyyGbj2ueZCujYE218stgSe25PKqAKM3W4QXgumhdHrlU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775007607; c=relaxed/simple; bh=pqz3o/rxy9WJ3YvbziOVUyh/gkw2NGu+IJUHKl3dvqc=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=E6HiGAc11ZQab69t8vEApMuooOQe7U3QYtbFUqrMzUD2yhspbytqpvo7S9i+2DnbOgxQaSIXEPQJLYD+IuYyBuPCZatEalDrOJLY4cnkz8kJbgAALMIcuhZLsDChru9F0Df5Dv5G1KR2aunPFIJpBFYFTwG6RiT/fAeiYm72tmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J2Tk4c8c; arc=none smtp.client-ip=74.125.224.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J2Tk4c8c" Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-65015facf32so6245334d50.1 for ; Tue, 31 Mar 2026 18:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775007605; x=1775612405; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RXQNpeQf/PiTzVseX/tskZUf+TiWiKy17t16d9yvbT8=; b=J2Tk4c8cKl1QejqGKiBGfM1CdN30kzTHki+cXNm0x4m/mjhlrU/vZDp37IStRtSye0 O2XhBlVsfE/iewl6eFMfocugudyKlDjk1qj6okstj6NxnCEbANBKjAqUBnCDxeGjY8qQ 6vtLJbCutPLIy/Zp/wAyQzpPIUbTsJLw1gff77hZWeU00LXwK96Z3OcbHcYsnwLYqXJz ExflLfTw2ZxMYMoHZEUnC6oJldj8bhokYPl7EwmJe+MFRNk5nlK7yaGL+ZsHYwF6XNYQ mgQuwbZ2XEtBR+CyMq6i+OEA7/Ci72XLTseP7UIrvxLyGs2XFmUcou8EjyECWqUyWWgT qLFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775007605; x=1775612405; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RXQNpeQf/PiTzVseX/tskZUf+TiWiKy17t16d9yvbT8=; b=Ipaqj/lTXb/Qumf6wmhr7QwWseUO89Qcr/DucBpdXYQky4OZV6ICm/5DzX/Ov9IBMv q5bX+d7sSKhQR8aWDCmytI2k4mIesKP3pwQES9q7uCBvrVDAwnzETy7YmkOxzcfWK4gR Rpmfy70rdHe/rDGj9oiazVD+q76J1Us7Y9tKQHrv7DR65LWHCpSnAvV7QNGAooLFlpbu ry/X9aHud+HG0R+32/v8L8+McoHgugO9ds74hoC5r681x2Z7MYVfUxylUhDNsasTv3n6 BPLFsME6/CWlZ/XzoBW8dM7vnYH7+Zr3n6AllojM4Dt7bg+H3m4zbDbwryJtmzROlzK9 WgcQ== X-Forwarded-Encrypted: i=1; AJvYcCX+yHWHiDNpMy7ZuNcLjqEao5IuAGeV6e4Sq6DnPCkK1oZ3rX9Ol5h0pXuZBbbgOtywA4fGDM1+R1KGo6g=@vger.kernel.org X-Gm-Message-State: AOJu0YwFm7Ws85Q5DsAyh512Nod2LAe8tSjBD+/3Ha5sFLMBq9WIXgRw gAkfOOOn6EmHPvIP1dhs2Ec5ZO1usSHVr7JzLeXZBrIBNYvkKMIsdxJM X-Gm-Gg: ATEYQzyByDx0UR5WPEPA6fjLnGuG/tDjep75GlrqtxSrF+3s64GzOrh6GnJNoTvzyA7 JrgP1qpYed+IVbwrrUJ80KbXSLi7e/hsS3L7/xVvNgW4lKpvRTVcCKI04DcnY5e491lzxGsTU/E /UDXuxc1DLR0dycOywo+Gmg0PbxIZiHusF1iJv83DISRZWZkziW3ioMpERKpTNeDLQQeOLAD1P4 z1BzyXmq90qCPFsyYu8eWuCYtBYcJKjDJKnOLGN4BxCunlBPAIJRpKYSw996YJv0edsChKTa5Eh 4UTDavYZIW/ZN9aXj55jF9dxsRorxCE6ZFfF2QQRcf07w2LcpRmGFA/2VXMeWmhw0aMNbZ1QyJQ 5Uzv4Hh66YiYdu+V0/6tUW36Xt+hT86ERYcFwvLmfAyTLwN5CbTIT3Ou9/bgYoQNA3zxUs5dUqg 2E4IE/ScUY+Je+5nqIu+EbOtM07rgBvlpMrvPh+ZSsWwsptFH99deaIhTGn0hWK6Hh4R/JXdMXL gO3n9ZqdLF0DMR4ZcyR3Ng8pYHxgZiu X-Received: by 2002:a05:690c:e3c4:b0:7a1:6e8:d8fb with SMTP id 00721157ae682-7a2104a4956mr20607237b3.3.1775007603936; Tue, 31 Mar 2026 18:40:03 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79cba0778acsm56922757b3.33.2026.03.31.18.40.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 18:40:03 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 31 Mar 2026 20:39:54 -0500 Message-Id: Subject: Re: [PATCH 0/5] rtw_sdio_if1_init cleanup and small logic tweak From: "Ethan Tidmore" To: "Omer El Idrissi" , Cc: , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260331153255.22764-1-omer.e.idrissi@gmail.com> In-Reply-To: <20260331153255.22764-1-omer.e.idrissi@gmail.com> On Tue Mar 31, 2026 at 10:32 AM CDT, Omer El Idrissi wrote: > This patch series does some general cleanup for rtw_sdio_if1_init. Among > the changes are: using direct returns, removing the use of > vendor-defined macros, adding a separate label for freeing and > unregistering padapter->rtw_wdev. > > Signed-off-by: Omer El Idrissi > > Omer El Idrissi (5): > staging: rtl8723bs: use direct returns in rtw_sdio_if1_init > staging: rtl8723bs: remove useless line in rtw_sdio_if1_init > staging: rtl8723bs: remove use of vendor-defined status macros > staging: rtl8723bs: replace function with error handling alternative > staging: rtl8723bs: add separate label for freeing rtw_wdev > > drivers/staging/rtl8723bs/include/sdio_hal.h | 1 - > drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 56 ++++++++------------ > 2 files changed, 22 insertions(+), 35 deletions(-) Please add "staging: rtl8723bs" to your cover letter header. I have a filter for rtl8723bs and not getting your cover letter was very confusing. You don't have to resend the series for this reason however. Thanks,=20 ET