From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C827D2FFDDE for ; Wed, 1 Apr 2026 15:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775056725; cv=none; b=eKgquSdU++sEsXAB3sep+H5WT6+pFtOziWCGrrKLICRbunqsD/2fm/EllmWXZDztdxKKSrf0YvE1wYXjvUbXNjDyWGdLoJB1tzU5GTX433/dkU56r5zVQTz4fQKwfsl+AMtVEkQmgnGEXf1AEG8FV2DD33TLHGprpKuU3vU2qIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775056725; c=relaxed/simple; bh=D79QeV+P1IC6CZVi6L3w5ml2fBqA6QN1hGJBuW3fgQY=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=BVmQduumdNfJ83hxufQZI0eJ29f4z97QNewDnpQc4zsFmOqFt5K2uhavjfedk498N7Tvlv5gmlJAOkym+879CRxFqdYIAE/LxkgfWsMHSOXHp8ccfDvvI9i7684Gef2XkWpbieXKlNGBzBQz3d08atuoe3ONto3GoppHhGin0rc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=H+CZ3lDe; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="H+CZ3lDe" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 598D54E42898; Wed, 1 Apr 2026 15:18:42 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 2F1B7602BF; Wed, 1 Apr 2026 15:18:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B801610450290; Wed, 1 Apr 2026 17:18:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1775056721; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=0Sd1TJerguP3PV7KbCxrgIxPOI1utwr2NknnAOVyldk=; b=H+CZ3lDenPJydpTatgA8YPMkzJKRcSzXPX39jdxjDIrcoOlux2PXXdGz13D4P8JFAEjOHI UkzBSIx4b76G9oVrQZ7uU9RdC85wMVh0HxBP5sfIboLvvEKwwnvZX3hOZpqXosdOlRWdxm ATjgepiQezZDv7amOVyugi5nhoFXZrAIlFmwP3umjZQjx4nmony50uJIG6CTzf4qJTTC7R Vju8yg1H2M4DQyvvYevI4OTISDJ8gekSlxSEhUszvjwXz/auZmL3RBxh3ZQHryyfuDsTvO 9eQkl7UbYv201hHrG1DEibu+zwS5FbW0zHtKOtnr9xrsjkXENwta9h5zZvXpug== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 01 Apr 2026 17:18:39 +0200 Message-Id: Subject: Re: [RFC PATCH 13/15] libfdt: Introduce fdt_ptr_offset_ Cc: "Ayush Singh" , "Geert Uytterhoeven" , , , , , "Hui Pu" , "Ian Ray" , "Thomas Petazzoni" To: "Herve Codina" , "David Gibson" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260210173349.636766-1-herve.codina@bootlin.com> <20260210173349.636766-14-herve.codina@bootlin.com> In-Reply-To: <20260210173349.636766-14-herve.codina@bootlin.com> X-Last-TLS-Session-Version: TLSv1.3 On Tue Feb 10, 2026 at 6:33 PM CET, Herve Codina wrote: > libfdt provides internal used helpers to convert an offset to a pointer ^^^^^^^^^^^^^^^^^^^^^ Just "internal helpers" > but nothing to do the reverse operation. > > Fill this lack and introduce the fdt_ptr_offset_() internal helper to "Fill this gap"? Or just "Introduce the..." would be enough. With those fixed: Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com