From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35C6B1DED40 for ; Fri, 3 Apr 2026 21:39:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775252361; cv=none; b=Xl63/cLpXF91BykcfUZcn+4dHEWuP8z1nZYNqja8lRBB3Lh/S9bQIDYXyjprERw+173yn6gIw56cZQuW6Ot4ez21Ot6DoFB0PId/e8os2J/nvPZFmhU2rFufIsc4UDKLAAThgJbVv4eOCR/JIZbNs0wgmHOZtW9yiSP1NpW0oSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775252361; c=relaxed/simple; bh=XUv2zHffbIMnVNQiZJFK/zDbrK2aZC4otKGAMtxQNMo=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=lhjglkG2ZAlOvzXw0pPu9gzo1PxyFbGr2XoSfwToqP9mkp9AgDeelDTghAxeEH22mMsPSnoSk0Rs9HlsIiQGTSeuP9xvy6By7ylSUqTbgyRZN26BjgWx4j7XgOOOEy9AQOlS5dQeFVPF4iznvs8jMK0SIwBcyhShveVJxAtql2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ozJdKUtq; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ozJdKUtq" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-7a17bc5745eso20992357b3.1 for ; Fri, 03 Apr 2026 14:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775252359; x=1775857159; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pJrsXqouJBs+QJo4U/h4iVs3B1LQcjTgx6CW78TnpbE=; b=ozJdKUtqiWitPqlyIVcD1MpXVYd+k8FsyZ+cTyvR4p1bvVTvEAqRN3/IY5rStqyXef tBZ8eDN9XcmHzQFBbw2KpTUzZUKD48yawWj6qgWqAFzDtGAtYgVjtMN+6cELRz3KC6Hu TvlwfXwdAoDdmO+wWH6ExJ8FD/xIRHsn76dVffESXUn55wvSrmSx5mpk+HnfMeWbS2de 9mZ5fQRx6oBZKf9Dm5edxBVHv9mM+G8CxORA6FGiok38ZjGJw3z7qxXJYMQ9lkVO/pYw m3Iq2kUfVlVKXXwltCInFSZ9b6AteLKrx/bPMiFPcsVET2Iq/sSuXaGOnoFcSXrUD2NB ndHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775252359; x=1775857159; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pJrsXqouJBs+QJo4U/h4iVs3B1LQcjTgx6CW78TnpbE=; b=IMe9y+I/20fYRShp5Flo4u572YoAuCPOE2qu1nFO3hm3SyJG8WoxZgcjjr/Ppe/b/4 TI7S6nHaimVtIef0gnd5UfgFltuVy/l724bHzNfAJxc1Ed+uk+BZ/J6CwA8hO8s7nwzU 4j/VwvVuc3JFk68pe/OGIV53XzpSOERUcBh8dKl+K2qh1RNt/zPH4DvMMtoTK613Zjcy gmcdDpGLii2YeXpnBePaG7f6HrND2cNPhrvXwtwn9WCRO26SwhtNyuKtnjcd1jL1Aj5o z1xax+TVFc5Aiqwy1exlpA0aTvxFqEkY9pKyctHLrCufqTvkGPFGrJrP9rXSQZaIsAsU Ff3A== X-Forwarded-Encrypted: i=1; AJvYcCXEtbqHxaUXcIv8QBUN9c3UUA93Dxi1QnlBim3PiGYGsRbKf7biv8Zv4RDsPNFBUIktPYD8qySxGMy+/eM=@vger.kernel.org X-Gm-Message-State: AOJu0YxdtynSTohUPvVev2eUS037GRhmFXrPXpOAOVKSx75SLU5bHp3y 0qQVpYZHAJaMOi8o5psas9JOdnv49E5QzOYWDwNE8rJoBqVD2m2gsTHf X-Gm-Gg: AeBDietPhQ1eQfsR9dtM+xdpesqPM00k5qWJDFes3J/heawDEj6sACdiCgSfxxuEB+8 cEUxtnrafPxmdzrIAEaZXWb0wjhgtgorNivSUEaDLOjcLEbFtybPU1fb9AjPKTOkcjEoYDrzQgZ fU31IGPWS9xO7VF3HMX9XLL6ou8mBfAiUfvj8ehQtEChy7z6MU87wxEu205K/9i5DzITQi3k5gI BZXC+hWSOQhA9Z0WCCN4VdzzY7sxJBxybPZawFvATm59m3A9b/HAhUGLqGZTUQrCBvjphwrqhpX Sm6wAQ4KsRoHypv//oEPgvK4hZvDzkQUamePm4Ft1Zh4T6ekVfdZ81TIDwHuINUghk7XSsZlh6r E4lhWxGi3N+0tD8ou4wgiVU/98UK7nTwHNCQolDEMp8J5piCQit6NTeyGW5cLlH9xC+yDeEhZyW hP/oG3t4F+AtYX3QM0D0k7cjLd3/Zv1MxEjmFHS7zEXfdWRubwIRB2eqkyzJ6m70AqnvhFuLnho N5rxtW9yX7yFfXFKF5RaLn254XUwLGg X-Received: by 2002:a05:690c:4426:b0:79a:40fb:9339 with SMTP id 00721157ae682-7a4d60557f2mr33676767b3.47.1775252359144; Fri, 03 Apr 2026 14:39:19 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a370df19f3sm26801157b3.39.2026.04.03.14.39.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2026 14:39:18 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 03 Apr 2026 16:39:16 -0500 Message-Id: Cc: , Subject: Re: [PATCH v5 3/7] staging: rtl8723bs: rename EFUSE_Read1Byte() to rtw_efuse_read_1_byte() From: "Ethan Tidmore" To: "Linus Probert" , "Greg Kroah-Hartman" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260402054215.271981-1-linus.probert@gmail.com> <20260402054215.271981-4-linus.probert@gmail.com> In-Reply-To: <20260402054215.271981-4-linus.probert@gmail.com> On Thu Apr 2, 2026 at 12:42 AM CDT, Linus Probert wrote: > Renames EFUSE_Read1Byte to rtw_efuse_read_1_byte in order to conform to > kernel code styl. I missed that you misspelt style in my last review. Sorry about that. Also, its generally wanted that you include the change logs in the actual patches themselves. Thanks, ET > > Discovered using checkpatch.pl tool. > > Signed-off-by: Linus Probert > --- > v5: No change > > drivers/staging/rtl8723bs/core/rtw_efuse.c | 6 +++--- > drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 ++- > drivers/staging/rtl8723bs/include/rtw_efuse.h | 2 +- > 3 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging= /rtl8723bs/core/rtw_efuse.c > index a7b120cc70a3..d6212b3b0b1d 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c > +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c > @@ -26,7 +26,7 @@ rtw_efuse_calculate_word_counts(u8 word_en) > } > =20 > /*----------------------------------------------------------------------= ------- > - * Function: EFUSE_Read1Byte > + * Function: rtw_efuse_read_1_byte > * > * Overview: Copy from WMAC fot EFUSE read 1 byte. > * > @@ -42,7 +42,7 @@ rtw_efuse_calculate_word_counts(u8 word_en) > * > */ > u8 > -EFUSE_Read1Byte( > +rtw_efuse_read_1_byte( > struct adapter *Adapter, > u16 Address) > { > @@ -79,7 +79,7 @@ u16 Address) > } else > return 0xFF; > =20 > -} /* EFUSE_Read1Byte */ > +} /* rtw_efuse_read_1_byte */ > =20 > /* 11/16/2008 MH Read one byte from real Efuse. */ > u8 > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/= staging/rtl8723bs/hal/rtl8723b_hal_init.c > index 355167883f08..941c2ebef9e2 100644 > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c > @@ -1559,7 +1559,8 @@ void Hal_ReadRFGainOffset( > =20 > if (!AutoloadFail) { > Adapter->eeprompriv.EEPROMRFGainOffset =3D PROMContent[EEPROM_RF_GAIN_= OFFSET]; > - Adapter->eeprompriv.EEPROMRFGainVal =3D EFUSE_Read1Byte(Adapter, EEPRO= M_RF_GAIN_VAL); > + Adapter->eeprompriv.EEPROMRFGainVal =3D rtw_efuse_read_1_byte(Adapter, > + EEPROM_RF_GAIN_VAL); > } else { > Adapter->eeprompriv.EEPROMRFGainOffset =3D 0; > Adapter->eeprompriv.EEPROMRFGainVal =3D 0xFF; > diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/stag= ing/rtl8723bs/include/rtw_efuse.h > index b8cd9e694f56..7b78fd5e583b 100644 > --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h > +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h > @@ -71,7 +71,7 @@ struct efuse_hal { > u8 rtw_efuse_calculate_word_counts(u8 word_en); > u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)= ; > =20 > -u8 EFUSE_Read1Byte(struct adapter *padapter, u16 Address); > +u8 rtw_efuse_read_1_byte(struct adapter *padapter, u16 Address); > void EFUSE_ShadowMapUpdate(struct adapter *padapter, u8 efuseType); > void EFUSE_ShadowRead(struct adapter *padapter, u8 Type, u16 Offset, u32= *Value); > void Rtw_Hal_ReadMACAddrFromFile(struct adapter *padapter);