From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A71BF275AF5 for ; Sat, 4 Apr 2026 22:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775342156; cv=none; b=DjWYsWKglR90inN3bJDE3MolC1oMK9n+ur3M+VrGVCZOKrYAnqYP63LIM0mK1CLKa1twyhzg2QPSE8CRk7/uwG3UWg1vYETqpMFRG4RJBMpPBnjx/7WWoxtjb5zSiz8DjGPUz2U2GHDn1gobYn7VEajpEKiNgSV6yWdW9outq6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775342156; c=relaxed/simple; bh=h841FlrWQtyCcCDB0AwdUvRd4ePYxm9XKfz6UzfHuhc=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=O5iTvLeYnVFYMGpuwWBbgfukmjqU1IGuw/OTcXwGZ+HOFAOXmQNS40bpqftN6C50BVC1Rq/CGa+gwz3EcIViUSv34+22xZbd0zWBaHZMaLJp6iQAdJv5XdVeFk8h4XWIATgffj1KJIEaVES294vcHnhlchYgQe7qkBKaJWs6zk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IkLtzX3x; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IkLtzX3x" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-65015facf32so2785346d50.1 for ; Sat, 04 Apr 2026 15:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775342155; x=1775946955; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xnRaSARCLJgoTehmC6uQnak4zkOMqeFhXU3Mfv6P5cI=; b=IkLtzX3x6jO17CjwlYqk25+xj1a99O5P5HdoA9bxBI04tpCWjNcAAEKZrVpNYKSksh c9Zkg+WtfYUUahu8lUrSriVdSv9m4plj3fGOKfms4ztrqEllTWedmxpc/SsiLw/fZe4K gezQJDSuFoOaQiJuk0UfozqQKNPp8DNxicGlWA2O2mOg+F8wcvohKIdTo5XlVK4o5lfr dD9dBKHcV3SVSLKtOs8jEZNZPhqa38+pzcy+cTj7OjG9MyGqt7CSzkAREaJNQw59463s pc/l0Mh5PrPzsKTNtxq0YqHgu1gKNzS7ltGJeD0OIMRdpjuU/C5EqNkOv2Q4fT25u+Yo Y6iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775342155; x=1775946955; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xnRaSARCLJgoTehmC6uQnak4zkOMqeFhXU3Mfv6P5cI=; b=i9P/X7X5p7gigmU+jHlbiCO4vkZlx/0p57Eh2yUoxO87JrmV84YCNXlb7m+ZO+e540 IaBRAbh7kb++k/V37G21UWrLkNM7BEE7jXhesKqQsYy0ie5jp13YvOtDsu/tSEGtvmAv asfxC3xM6tpIfU+F1FXtGIgpbJDH75fAt+7Cu+MF5DUZbBQMZNi55i6XHwS/PMg6oBFq bBUTfXWm/dAUQXUah1bqXYj5/qtkORF9+GJQKA4/Xj1L0W1K1y7bDHFVVtOoH4ULpFbL 4cKTJ1xi+OaTiJiHh82trP397bJj05pXSp3IuVoLgWBI3c0cmZ21yk0wfo8E0AgXnVzf +VjA== X-Forwarded-Encrypted: i=1; AJvYcCXhv88ASLyOkdO4ryzFpgIJi6yS3mPB7DcHtBcCIzESCi11qAg9aCDmcDmYU/Iwz1cyqBb4oGQUvY04xqE=@vger.kernel.org X-Gm-Message-State: AOJu0YwZEFgwTCzUvAJHSNiyHzgjAekKZmZsMryo4yZJFOKtl5ihRggU sa7QgCbEj/ImVNG7TA/fSL8OhKmUkIa0ulCCzDpB6cAka52roEdSfFoY X-Gm-Gg: AeBDieuY8qg2qfLSQbNfG1v49T22ORJyXzrNfmmnIDrO2SSF/lSkj9cpDxhdjJ9/Mjy jyyeAmQD1ekHLqPIB0a+0UDTYm/TTjLfwLPLdjsUu+RDezCn7yvmGytVE6dLISOrXK0KsP3hduv Ddca1TrtOFKLUKoFSfqk+SunxOTHsFMODbWiPPsUCO8pkkaTLYjoH5xKTJBcTvKvlj6qtiWBjbj sH7xSIUKqDaWxpBevn1kSQ6zf7B6USijpg2DrNLB/pO4ucDjpnW+vA57RkclZwznzv5Lw6FVha5 Ni+v2TkWYgMuZRuWI154u2GK0QPaT156vXzBiTBlAIMP877DDwRuzWVYURNr+0HOahIfvjqeZeU O/SE9qgPIf7egaX68ffG8vb4duSS0Sh4p0HiLGkKHJ/cbOwhzME3QgfMtXZCMB9ywUNuRr67HN3 29fuwre/hhljZg97vTvJwePL8V5Ro/8tFiT7Jqk87qxltuxGRY2g2p+LEY0pUJKqNnDRhPWwvTO 0bf1rSuivz8FYeOC72GR8MRL0ZHR3Oo X-Received: by 2002:a05:690c:6:b0:79a:c659:6756 with SMTP id 00721157ae682-7a4d3ec9348mr79360077b3.21.1775342154630; Sat, 04 Apr 2026 15:35:54 -0700 (PDT) Received: from localhost ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a370905c45sm36825087b3.24.2026.04.04.15.35.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Apr 2026 15:35:54 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 04 Apr 2026 17:35:52 -0500 Message-Id: Cc: , Subject: Re: [PATCH] staging: rtl8723bs: remove redundant assignments to res From: "Ethan Tidmore" To: "Hungyu Lin" , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260404100933.7911-1-dennylin0707@gmail.com> In-Reply-To: <20260404100933.7911-1-dennylin0707@gmail.com> On Sat Apr 4, 2026 at 5:09 AM CDT, Hungyu Lin wrote: > The variable res is already equal to _FAIL when the condition > (res =3D=3D _FAIL) is true. The assignments inside the if blocks are > redundant and can be removed. > > No functional change. > > Signed-off-by: Hungyu Lin > --- > drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/= rtl8723bs/core/rtw_xmit.c > index 7b18be8912e6..ea1923023caa 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c > +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c > @@ -209,10 +209,8 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv,= struct adapter *padapter) > pxmitbuf->buf_tag =3D XMITBUF_MGNT; > =20 > res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_XMIT_EXTBUF= _SZ + XMITBUF_ALIGN_SZ, true); > - if (res =3D=3D _FAIL) { > - res =3D _FAIL; > + if (res =3D=3D _FAIL) > goto exit; > - } Thanks, but it'd be much more useful if these "_SUCCESS" and "_FAIL" macros where entirely removed instead of trying to clean up this bad style. Thanks, ET