From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1B1839D6EB for ; Wed, 8 Apr 2026 08:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775635886; cv=none; b=KPgfq4Ei/V11e3ETzBta9wTItmhLazUCXv3/y25Nx9pcWjgvxaXsY+UlIUKmukXJiiFbbvKZb/+2wBYOgFtFO4hc57g6ozgZYw3D9JJotL5QOkikrdhzBXCAGX6ZNnZab98IgXKMUDAkrI64fGhqvlh8nYDwKem9y1/glqp9Cg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775635886; c=relaxed/simple; bh=qK0XOhdUp8ewL5EwkKLZy+s840v+LEgMIWvVBSzPG1Q=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=dlEvHCjPBmic/KPihdHAHsOqfZ6w366PH9cz+yo7Ofk6P3cmN89UAUGUsdOxUTYBu/K+Y6DwX6NacXQcKYrEXF8xLSgv+arUz+pz2nwu9dOCAlpWGgLJvtDt9/rd8ZuQgYCl25VS+0757St0TJikT5QUC2zpltWOcoT5w2BOUJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=IFV1Uasy; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="IFV1Uasy" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-66bf15430ecso10963026a12.3 for ; Wed, 08 Apr 2026 01:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1775635883; x=1776240683; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XS7jjiupqdwNkh5OVoHcVKRKm0KpURxAwvyTzn+V6qk=; b=IFV1Uasyu5dKvZ/kbi3oSrrcuNBV6c44rIuZRFJHMQkeu3DzNZYMlWd1tHOJeD9Y2n oWmvlk+kJVL803bJIcsYduQI/QIgfPM4U+AcfrIMdI/35hufJeVF79Il5OnPQqDVzWrC vt6gQTn7rM5T9Ev0DDbS9m/dI8Hkol+OEt46FFQ8S4WpUDEQ/XSbS8Swg3fdes9KMLfz 0g7tq57LWUbmk21doLWlDjGd0IKr/RmgzY8/NcpQwoRrOy6Pe00I3bzdC9A/Fjc1v9VD 3xhL5b4EDtx3CeUBDTF6gMkcaDxHDTseL4Ch6Ab9Xfsk0668G7yvin1SimYIsFu2BSmW BS1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775635883; x=1776240683; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XS7jjiupqdwNkh5OVoHcVKRKm0KpURxAwvyTzn+V6qk=; b=j5JTAK7xQDCXqYceQQREOFHJisUXWwkKuzKmzrwHqktm+pX0aYNx4wcNQkx/N+bIdZ irRqdwoQZO17Cbrh6Y5vcfSo/6UwjoR8f0JpFv2CJOKC7MlGOuAqgQeFJ9m3BJ4QoIDh EYd4E5hHT2bwHOpWGjHIRMEAhfocbfjRVez8nLW+Cm6YBMz0mg1nlXpRgPTTXsi/k78u X7jr3UqzpnrpS9uRjiECUO5CuWsyWUQrwfGPkEdfaxoGo2h9qafvkwryMfqWMLReyEdX fhSDrrxxiQbgyT+xkXFXZoQH5ieJsjKtwVIXHE8gh8gpOo0MOoeZetx/KfTgZTxkihlQ Lkkg== X-Forwarded-Encrypted: i=1; AJvYcCUxDErM0QEavYgdn7w3EVAjtiv5OZ10IvQt7AeYKU51urGjH9dr20KRbje4enX8bwCMPrpPQ+DNKQO9Ga8=@vger.kernel.org X-Gm-Message-State: AOJu0YzZPlGXJpDpvMOPnjRud6B6WniozyP5qKxjPPzp9njROr5pYzDF eesAuqTfxh+nYxYPs7uwkkRtv7u2GEEGI7Qo5ZpuI1pZpuA8O6UpMZRh4xYbPJp8ZW4= X-Gm-Gg: AeBDievIcijTBtP8NCNf6y3YuIFVkLfP/bhn/kkk2j+yCyNKbMLt5Wsy7KMJPz3pg8+ WwiyHHIZB5tG6yRDQ2j7dSoSi379mOWYoLO5uF6xA0WuymYoS4EWHYjwDWie4W/KGFG6CNJ5AhD mjwkTXO/ji/B++2TSa4PgJ4jkyeqQR851tprv8hIgPp36D2NratGpOf0uTqVkJ/3axbovLdCli6 xYsCiY+PO4Jft6Zg+HLpIakB9i1ugDvDTlyFoNULVzgcmA+G+vjiluhzms+MB2X1WiFybAlMxda AhX/FF02WAmZbfA++l4Po+aEAbuCh1sPJ1KkzWTm4scpKufrcbyRfvUriETI93pk0asAPPhUmyV rdyRpiYtaSVNLe0WhOTKuQs8dTk400i0YIE+YhEm80MOHtN0qO3HA72unt8vQhjP7zmuJHeo72v Y79Ja2kK3D/PwpmkxE8skqmIilEUPajKUUtyTOnL8qBM9JibqRIEARO5us9LGBA9w8330E X-Received: by 2002:a17:907:9302:b0:b9d:14e9:8416 with SMTP id a640c23a62f3a-b9d14e99155mr231127466b.37.1775635883060; Wed, 08 Apr 2026 01:11:23 -0700 (PDT) Received: from localhost (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3c574041sm634897066b.0.2026.04.08.01.11.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 01:11:22 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 08 Apr 2026 10:11:22 +0200 Message-Id: From: "Luca Weiss" To: "Krzysztof Kozlowski" , "Luca Weiss" Cc: "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Bjorn Andersson" , "Konrad Dybcio" , <~postmarketos/upstreaming@lists.sr.ht>, , , , Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: milos: Add IMEM node X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260407-milos-imem-v2-0-5084a490340c@fairphone.com> <20260407-milos-imem-v2-2-5084a490340c@fairphone.com> <20260408-adamant-hairy-galago-61deed@quoll> In-Reply-To: <20260408-adamant-hairy-galago-61deed@quoll> Hi Krzysztof, On Wed Apr 8, 2026 at 9:34 AM CEST, Krzysztof Kozlowski wrote: > On Tue, Apr 07, 2026 at 05:11:11PM +0200, Luca Weiss wrote: >> Add a node for the IMEM found on Milos, which contains pil-reloc-info >> and the modem tables for IPA, among others. >>=20 >> Signed-off-by: Luca Weiss >> --- >> Not happy about the names of the subnodes. pil-reloc-sram is not allowed >> it seems. Glymur calls it "pil-sram@94c", not sure this is wanted? >>=20 >> Please advice. >> --- >> arch/arm64/boot/dts/qcom/milos.dtsi | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >>=20 >> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/q= com/milos.dtsi >> index 4a64a98a434b..0c69d5810f5e 100644 >> --- a/arch/arm64/boot/dts/qcom/milos.dtsi >> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi >> @@ -2289,6 +2289,26 @@ scl-pins { >> }; >> }; >> =20 >> + sram@14680000 { >> + compatible =3D "qcom,milos-imem", "mmio-sram"; >> + reg =3D <0x0 0x14680000 0x0 0x2c000>; >> + ranges =3D <0 0 0x14680000 0x2c000>; > > Use hex here as well. Will do: ranges =3D <0x0 0x0 0x14680000 0x2c000>; Do you also have a comment around the name of the subnodes? Do you think they're okay as-is, or should they be changed? Regards Luca