From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7443E1E9919 for ; Tue, 14 Apr 2026 07:28:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776151710; cv=none; b=W7hNLciLXaoq9CXikazXZkIm29XNgK8jDHdSE9+B3aKe3EJsjEsy+MCiHN2FUqAZuNTM7KaK+C+aiMDb3ERl4cFaEdrhl7jL70KLPEa69mi+B559hfxwN0Mym6TFSaoD/CHb3uPqXmyrcqfnIsdZnwqXx86AO/7j1iP7seUe1Z4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776151710; c=relaxed/simple; bh=Wdgd8SkFMZXsCoGpgOUm6mjEYAN6GIZV4sDMzq3/Iyw=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:To:From: References:In-Reply-To; b=LGeeiZvghi/stF6BzFhhKhf6kMnFceGEn+3y/VtIUR+6D5Iin1NBP9O2DDs534YT+1uqrRcIMWUG9YNVHwQ49WyMALKDsavONYVwP6+cwOcu/09vk02gXMGfl76O+1bSGJlydi38oyh2lv0Ello/0YhXuk2torjg3LKVrgVPjL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Roj+tOiW; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Roj+tOiW" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 0F0EAC5AA96; Tue, 14 Apr 2026 07:29:05 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 1DCB65FFBB; Tue, 14 Apr 2026 07:28:28 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id AA77210450D00; Tue, 14 Apr 2026 09:28:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1776151707; h=from:subject:date:message-id:to:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=ne2J5sJS+jQrbMgGTwn3xAIEeusKwHsxc1BQLCxTHB4=; b=Roj+tOiWwpFQfh5dv/aqO7ejIqwfUdSTnJz5sEEPegqa8inbSYGCSxHGgghp5/MPNQoMof rrs159Hu2gQDPJqAteQqN/OG3ZB26MaNIQDr1wPFRyyM9lQUz9mU5bM9fPJd2IHicUXrtP +Q3Kpypr1uKgqWxrcb9AXsGcGUnvDFn9r7o7R+iD80C2/kw94Aif+eV2HwAgJCjeFRE8Qd FAuJ3nhsQ2KbbuauyxtUa6XQiqE4NfSjcUeN9RtjftxiVKwyCjdRmLG65VBzxdbYHESfbc BMy/zAVDcDieuMEwntndTlN8VGd2gCG3ihF46h3SCUuN5Y6Q36BltGG1IXF+kA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 14 Apr 2026 09:28:23 +0200 Message-Id: Subject: Re: [PATCH] drm/bridge: chipone-icn6211: remove bridge when chipone_dsi_host_attach fails To: "Osama Abdelkader" , "Jagan Teki" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , , From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260410195537.295119-1-osama.abdelkader@gmail.com> In-Reply-To: <20260410195537.295119-1-osama.abdelkader@gmail.com> X-Last-TLS-Session-Version: TLSv1.3 On Fri Apr 10, 2026 at 9:55 PM CEST, Osama Abdelkader wrote: > when chipone_dsi_host_attach fails in chipone_i2c_probe remove drm > bridge before return > > Signed-off-by: Osama Abdelkader > --- > drivers/gpu/drm/bridge/chipone-icn6211.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/b= ridge/chipone-icn6211.c > index 814713c5bea9..5bee10c64265 100644 > --- a/drivers/gpu/drm/bridge/chipone-icn6211.c > +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c > @@ -760,7 +760,10 @@ static int chipone_i2c_probe(struct i2c_client *clie= nt) > > drm_bridge_add(&icn->bridge); > > - return chipone_dsi_host_attach(icn); > + ret =3D chipone_dsi_host_attach(icn); > + if (ret) > + drm_bridge_remove(&icn->bridge); > + return ret; > } You can simply switch to devm_drm_bridge_add(). Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com