From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9ADAA39658D for ; Tue, 14 Apr 2026 10:18:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776161922; cv=none; b=HVJa8Iv0zxex9cBvlVZ9khZQJJqom2pZYK9vMqQVR1ejGb8hS8IYLxW7MHkuFXX9dzgydtwa+lQAnDhUnAspdE2rk0jRapebEJYkc7FBT7cdCryrCMpGXJyQEYCuhXtaw2UJk96gBxPH8leBcwczLwgLmvdFzcICOmJEKa5nukQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776161922; c=relaxed/simple; bh=RiOWPVhGKUcK0PyE7pCAWWaPj9qliEjgqwM+GweWDg8=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=u9PIkmow9WCTwgeXs+dsbYg3i0IzJZ34uDsyyzhAhLMo7/09Hk5jBdCcKzqb3RoJPGO0R2jP/+CTXVtZlLvPJkUWmmu6FbVfLER7LHmyg0EqTMn9Lsq53nODE6AJv8dIz8XRneF0AunCGqLwCHbxUkkEkgr0JREV0tKefLdtf4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=3nExj+/Z; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="3nExj+/Z" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-671c24f23b1so1909463a12.0 for ; Tue, 14 Apr 2026 03:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1776161918; x=1776766718; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YKsGUuq/AWrW0/a76gvihKykHQHBCYzLpfiJNxSSm1Y=; b=3nExj+/Z1GVHcoN0n2TPG1rq7XiuwGlE7rco0HAMIQFZkXT9/Y+V7nek0OAT2vjSQ6 TDYzukiCExDoHtGEWxPT895Njh4CR6adby/yOia1k9WYghAJuYbWgmpdc1duQ7M8g5Li FUznIEIvTwF2UAEfNocduNcUQEJHNebCDdfx4LG+DWKZnUJALTyoO7L6zqBtmlHoG1Ve gM5N7PAI/PYgXY7QOLwIUQ3uYy9PLZEHhtvAhpksR6Dxk0UontoFiMNlMn+ikqA3i0LG HGMgRG4rZ6UpAKcejsmehQswS33VeMs1XFcqXWSBIGJIOSewWtgN2ny0ZPuNknm6zWQC QDAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776161918; x=1776766718; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YKsGUuq/AWrW0/a76gvihKykHQHBCYzLpfiJNxSSm1Y=; b=A+uDTHAHS5hNmx8hHOcisni1qiROKd5L9Q3Nvwit3S7BFUU2k5B+pbt/zPQuNloMPn vbkOysElUQABl2Pp2rZ3dkNcLdDAlCnBuRtckjIGjFwcJyReRZJo+T5zOMGMX4T8znDY pcHXfdo3oIXqgb1bDpWeUnaLTSOdL31YHNuM2ZEwzSPbi+VI79QxQhDNID3Ds4Xd9QTF AS5ceoAxoEx6CCrtdtyMZ6Iu3GuwB7RFg4JAPPgxCYuuJ7d+PNlTFsdBDjihgI+eX1o7 +jpj505lqC++i3zwtCMpK8Qt1xS9cQLvV/4GA9E0JJm0ZBGvI49T+03fTqp8II827B7n M9fg== X-Forwarded-Encrypted: i=1; AFNElJ+yloHrGzgoLuHwO81DLGBrMCRbdbcHDFFf/SQd8uUT8Vx54lZpvj6xJ9y1MeY0HYWWCBy8nxiVnLuPQho=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3sId8MVq0QYJlhbq59yfaK7tcgxvgODLvBYY3a6kd2CNbPxK7 In95QY46YhURNWR90MIoLDe7j1+MnDxEidoxutjijXv1ZJ0kNRTslfjhDJe0e9b7jSM= X-Gm-Gg: AeBDiet5OVEbKRCc+TuThfvtwr4h9Jer813id0WPJin9AqZL75Q8fOk//o2K1V0Yzq/ DGQcojCKi52t4QoVvhj6jjjDtb7QNcg2hlTgEDJw0L1XzXW/UK4c0ExOK7q+JAXm6Q2pWFm0igq 33EGiopGzapPvevgcakW34oImO14HRKFIW9rTp0RPe1+4jt7E5OGo7LuJ15HSRlS1lPgd4abA32 hiqq5YVR1UexlgQJJGaSiXCHrwlVDYyyg9NshQhXCpqV+Ygga88ZMo+auBIq9xpVHZ1R1EseuVX XGKNpEDd468z1nQ0Qn2LT7KdBTC61QMn5TJrw1yT41KDs8Ja7xcgJhZ/7WaibCWiTz50UF7Z01F Ysocz+CYH2aXmEuiwnNDTaLyD3GvPZ+6VgNXfOUGDvOXjP9OotDYx4JQ7OZlo7LGNuyDEhZIfT2 OZZnSk8nHQhCXiDyLaw05x1gwSvS0Q3bJ0AqULQoqIV34faK6ce3WuiAlLvLfnlAyPkKkc X-Received: by 2002:a17:907:981:b0:b9c:9dcb:36e8 with SMTP id a640c23a62f3a-b9d7294f263mr933612066b.53.1776161917740; Tue, 14 Apr 2026 03:18:37 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6dfd77dfsm387242166b.18.2026.04.14.03.18.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 03:18:37 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 14 Apr 2026 12:18:36 +0200 Message-Id: Cc: "Xilin Wu" , "Abhinav Kumar" , "David Airlie" , "Dmitry Baryshkov" , "Maarten Lankhorst" , "Mark Brown" , "Maxime Ripard" , "Simona Vetter" , "Thomas Zimmermann" , , Subject: Re: [PATCH v2] drm/display: add hw_params callback function to drm_connector_hdmi_audio_ops From: "Luca Weiss" To: "Luca Weiss" , "Jianfeng Liu" , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20250925040530.20731-1-liujianfeng1994@gmail.com> In-Reply-To: Hi all, On Fri Oct 3, 2025 at 4:42 PM CEST, Luca Weiss wrote: > Hi Jianfeng Liu, > > On Thu Sep 25, 2025 at 6:05 AM CEST, Jianfeng Liu wrote: >> After reusing drm_hdmi_audio_* helpers and drm_bridge_connector >> integration in drm/msm/dp, we have dropped msm_dp_audio_hw_params and >> use msm_dp_audio_prepare instead. While userspace is still calling >> hw_params to do audio initialization, and we get the following errors: >> >> q6apm-lpass-dais 3700000.remoteproc:glink-edge:gpr:service@1:bedais: q6a= pm_lpass_dai_prepare() started >> q6apm-lpass-dais 3700000.remoteproc:glink-edge:gpr:service@1:bedais: q6a= pm_lpass_dai_prepare() started >> q6apm-lpass-dais 3700000.remoteproc:glink-edge:gpr:service@1:bedais: q6a= pm_lpass_dai_prepare() started >> hdmi-audio-codec hdmi-audio-codec.0.auto: hdmi_codec_hw_params() started >> q6apm-lpass-dais 3700000.remoteproc:glink-edge:gpr:service@1:bedais: q6a= pm_lpass_dai_prepare() started >> qcom-apm gprsvc:service:2:1: Error (1) Processing 0x01001002 cmd >> qcom-apm gprsvc:service:2:1: DSP returned error[1001002] 1 >> q6apm-lpass-dais 3700000.remoteproc:glink-edge:gpr:service@1:bedais: Fai= led to start APM port 104 >> q6apm-lpass-dais 3700000.remoteproc:glink-edge:gpr:service@1:bedais: ASo= C error (-22): at snd_soc_dai_prepare() on DISPLAY_PORT_RX_0 >> MultiMedia2 Playback: ASoC error (-22): at dpcm_run_update_startup() on = MultiMedia2 Playback >> >> msm_dp_audio_prepare is not called because hdmi-codec driver only checks >> and runs hw_params before q6apm_lpass_dai_prepare(). This commit will >> add hw_params callback same as drm_connector_hdmi_audio_prepare, so that >> hdmi-codec driver can work with userspace alsa. > > This also fixes DP audio regression on qcm6490-fairphone-fp5 (using > Elite audio architecture) > > [ 133.986865] qcom-q6afe aprsvc:service:4:4: AFE enable for port 0x6020 = failed -110 > [ 133.986878] q6afe-dai 3700000.remoteproc:glink-edge:apr:service@4:dais= : fail to start AFE port 68 > [ 133.986881] q6afe-dai 3700000.remoteproc:glink-edge:apr:service@4:dais= : ASoC error (-110): at snd_soc_dai_prepare() on DISPLAY_PORT_RX_0 > [ 134.045112] qcom-q6afe aprsvc:service:4:4: cmd =3D 0x100e5 returned er= ror =3D 0x9 > [ 134.045192] qcom-q6afe aprsvc:service:4:4: DSP returned error[9] > [ 134.045214] qcom-q6afe aprsvc:service:4:4: AFE enable for port 0x6020 = failed -22 > [ 134.045231] q6afe-dai 3700000.remoteproc:glink-edge:apr:service@4:dais= : fail to start AFE port 68 > [ 134.045243] q6afe-dai 3700000.remoteproc:glink-edge:apr:service@4:dais= : ASoC error (-22): at snd_soc_dai_prepare() on DISPLAY_PORT_RX_0 > > Tested-by: Luca Weiss # qcm6490-fairphone-fp5 > > And I guess, even though I reported it after this patch was sent: > > Closes: https://lore.kernel.org/linux-arm-msm/DD8PK8AI24P7.YK0OGVYC0QFM@f= airphone.com/ Is there any progress on resolving this issue? I'm still carrying this patch in my tree. Shall I send a revert of "drm/msm/dp: reuse generic HDMI codec implementation" to at least temporarily get this working again until a more proper fix can be made? Regards Luca