From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BCE4346FC0 for ; Wed, 15 Apr 2026 11:06:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776251217; cv=none; b=VQy2Mgjvt1vTti9p3VBQkNQIrBoTOmagspRnUVDAyT9PhlQl7VF2VS4LYlxzjhdYAxDrJmiaQA3dcwMmQAg3sJkFq5Zi1Ab3p7fhMPG8nvbcdvyRakkxIZxG6EVrlthu/Hyd9sKXZMkuvtgXYmjn2cFgntKB+JGWMlMzHXjcQcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776251217; c=relaxed/simple; bh=LDI3mtUhr2Rd5w5ikgiCoRnemB42IOlavCohdIScs2s=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=mKqslkq99HyLNsF0l4yLSCxeyBFTzOHWPhHpcTF9/cTKxQzvgjUnk03UaUEtvWpTQArBrPNrq7bCZ1evhjk11rr1zKbEoGDL8ULE5C+2bvEJeajr/YJPJHl8xoswlyDKX61Wh+XhlRjeDObxBFr49jnKwng3d9nPMOBWqkubqMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FC1dNizW; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FC1dNizW" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43d6fbd0954so2813130f8f.1 for ; Wed, 15 Apr 2026 04:06:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776251215; x=1776856015; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Rw116FfYB2wR32SWs/TCFerpwP/9uG3dqe/oInwd9Xs=; b=FC1dNizWonp4QpzI2N3Rq2W2xJ4iMmgVfWaMZPlRlepTj+O46bHcZeMyOvzm+f4p5B 0uL6aFM3ptRN6stlO+7R8SL3cN4C1leb1oZKGUZqvWTFFrL+9ofe30xrw7dS1bEepTjQ J0ADmXh+JsoVhe2SX/nQRIjjwzpx/zqWnrwl+GJAsYiUS0ZzXbnZwadHVOurA4W8rzRO 9qm1UgBqRSE9VOZzXNUgmlPQxITuvHMnnuGTsAUeT7wZ700vKzw0QCgtOVH2VY4mS9Kr klEEn4HbmUjn44Ac0GBJAeenFRV01M79S3CFRgUHuQKuQYuVeYJmzUFydARFzyqUq7GD Uihw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776251215; x=1776856015; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Rw116FfYB2wR32SWs/TCFerpwP/9uG3dqe/oInwd9Xs=; b=GxBKYlLw7Ud1Lc4dli3nJ/wRTBzC8xsS1FN9v7FOj6TwbmCHZUDNJYpYmqG67wvHlh btI2aurGyEpnCFDPqBx6hs711ZgiOFZHv7Q6P57IIUQbiKqFW0lkWFkL/JIrU9QqUH3S 0uSGCAKOcm5vHZrDtOMTW39QizgxeZVU4zObGs6Gg7PSBlW8gjklz1rwHWSkTVySmhIO xQQe99h240m7OLrFRJa3s+pmcryVc7y4ECDzXgx6YsiXNsWtv34RxQvknaA9XdXkuHNf VGz2oeDB6lF++E3XHnsqZcU4WtYpd9u2i4e/Z8GJe2ynd7wvD9ZofaF/+C7WfJ2/yaMs mrEQ== X-Forwarded-Encrypted: i=1; AFNElJ+5G4eNZypHLT4OcIlev8QGWbommN0Frm74EYuQtoIOYr88Xbeof17GOgIx2U1KJgA2EPSzjNJjb+AOfGU=@vger.kernel.org X-Gm-Message-State: AOJu0YxLniXX8rMEnA4gdeEoMe5UMSl6c90EXxNV1or/gdggGOgfMh/j CjTgpjdD0/ND+k4R0NiTQRVN7hhmRRK+taLe/P2wdMdLIctEKl1ewk4D4SmCgZ7+2fM= X-Gm-Gg: AeBDietUQ3e54gvhulkktnQn9xheFbn2hr/jNPuGveuz1VLt6C/6E+tn41AfFqICSbF 79PfqG+SNEbK7ZD9xBUcDF3B++6XcGTgrpMx25J9Kn2Ttk+frRl/9xlwTEqDf9X8U89c87PlPk/ QxqztYuHxj2D7u1JWBXOWd8c/BXJg7kkF+kj5RH5tuzaFQHFiLLZfSWstwPrn/Ck7B+vRdbNXZI 4NZ988CqHETgt2igSTAfZXa/AplujGkMsNHaaWqpVpRYvztI+BDuqXbfikX1a7M6UGhlQYfGCOW HJgIVbKNXVQGdB2sO5ojoE7qgPjYNTge32Jx+K6uxatMdsuQ328PhxL2indkJ6a6jybLbhTCZMu kKgbYLTU4JldacB4m35coiGYaMSw1jPzMhhrNlDyG9iyif2+g7mxYz8RK0JEJAnRwMk10T7V9EG lfLxUktjJaiVWUa3ERICRPK53GXcH51wxxjjLqU8CNuVA74/P8lcVprn5eC55AZhxRwg0VxmB/7 L7q7SyY0BY9KIrXBg== X-Received: by 2002:a05:6000:184e:b0:43e:aa88:f1a6 with SMTP id ffacd0b85a97d-43eaa88f2cemr4326833f8f.45.1776251214558; Wed, 15 Apr 2026 04:06:54 -0700 (PDT) Received: from localhost ([212.187.182.164]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead3e0091sm3867007f8f.25.2026.04.15.04.06.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2026 04:06:53 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 15 Apr 2026 12:06:53 +0100 Message-Id: To: "Kumar Anurag" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Srinivas Kandagatla" , "Liam Girdwood" , "Mark Brown" , "Jaroslav Kysela" , "Takashi Iwai" Cc: , , , Subject: Re: [PATCH v1 4/4] ASoC: qcom: sc8280xp: don't force S16_LE in hw_params fixup From: "Alexey Klimov" X-Mailer: aerc 0.21.0 References: <20260413091937.134469-1-kumar.singh@oss.qualcomm.com> <20260413091937.134469-5-kumar.singh@oss.qualcomm.com> In-Reply-To: <20260413091937.134469-5-kumar.singh@oss.qualcomm.com> On Mon Apr 13, 2026 at 10:19 AM BST, Kumar Anurag wrote: > The machine driver was unconditionally forcing S16_LE in > sc8280xp_be_hw_params_fixup(), which prevents links (e.g. HDMI bridges) > that require 32-bit formats from working. Drop the format override and > keep only the fixed rate/channels constraints. Why the format override is no longer needed? Please add it in the description. > Signed-off-by: Kumar Anurag > --- > sound/soc/qcom/sc8280xp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c > index 7925aa3f63ba..c00eabf200b7 100644 > --- a/sound/soc/qcom/sc8280xp.c > +++ b/sound/soc/qcom/sc8280xp.c > @@ -75,10 +75,8 @@ static int sc8280xp_be_hw_params_fixup(struct snd_soc_= pcm_runtime *rtd, > SNDRV_PCM_HW_PARAM_RATE); > struct snd_interval *channels =3D hw_param_interval(params, > SNDRV_PCM_HW_PARAM_CHANNELS); > - struct snd_mask *fmt =3D hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMA= T); > =20 > rate->min =3D rate->max =3D 48000; > - snd_mask_set_format(fmt, SNDRV_PCM_FORMAT_S16_LE); Does compressed playback work after this change? How did you test it? Will it be possible with this series to have compressed playback via HDMI (with 32-bit format, right?)? You might need to add some functionality for this in topology. Thanks, Alexey