From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A534E3750BC for ; Mon, 20 Apr 2026 11:14:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776683669; cv=none; b=tywvUduL6YBXAQ52HixXAgxjAUu6z+7aw/AqDkUNoj1stax0x2i4JvnRIORNx70Bgfcpn0mm/wsEe8GXii8TSV2y59qT2LmwvjKwcTFPVeU/eEQvzT0AbaE7kFKaMcoVlYQ0rux649ErD2Tzli616soVxe8aUQGbl56P3R7pFzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776683669; c=relaxed/simple; bh=oo6sD9eeKJmgF8y+Mv9/ziuyg8LqE/RcnPFXODHSQBc=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=BZpySO/qF3ClOrov74OUWKqdyvpJCeVl6NitR6Gq8M1M3caXewKTNwVUR/RUXnm6jw1ZSb5H+3pvC+JBcaTgQYleIYDumccXMgLNZZ7GDbb18AN79Lb+tqG8aozuMfQEP0E3xZMMHOtV2oKhwSda5P4afVmpo980SJt85aFerJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=IBn20ZWW; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="IBn20ZWW" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4890d945eb4so7781195e9.0 for ; Mon, 20 Apr 2026 04:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1776683664; x=1777288464; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dympeeiEyneZdFEwmKLL4dnrMWqI+ctP12odqcxsjA4=; b=IBn20ZWWmHujVbwaKsnlG6/fA6O6Z2q5Etxdiy0Rpua1Flfio5iuvHphA6Htwq45Ru s3mMLDbJzJitCNYGwhR3cCaaAbvB/WQVHdTXYCLx9Ml+1bXMjxqtxGNQ5GUGgh2cPEOt xWbSHmOvSqUrozSX3EIfXn1/Kjql5WN+xOBy+pyku4K/+NQjwg1Q+P5EfcFZYHDnpRgP 093Q9FGcg5Ieo1vfOMYe13KsQZ+l+748XCsqGjAh7oX71k0klpCXcJNDTRHAcj6xVpKo JSTzSSLYe5WGW3+LEp0U6l0aG7rirexfpwixmMKCzWA4FtFNnMJOFXXYXH4foGTAh1DV JKmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776683664; x=1777288464; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dympeeiEyneZdFEwmKLL4dnrMWqI+ctP12odqcxsjA4=; b=Afux3IbSMGvkvoJHrK3a4rYVy1l1lKyyOJw4Hv6kGtN6Bt7TEBO21N1/vC+GdicZv4 M2b6lFBptiV6KVAt7q4xwpet4xOUnhFLQTc95q48bDBtNFXhMrF+mJF2iLKpWtTbUFb8 9D0hAehTT3fJ5TuM787l6g/h7gEXZj93Y2gGEKC2Dt36FXn225gRXL3H1KvyZHBPCMPC fItxmo2NrIBu0YNnZa6c6kZ2s3t7+ZTGceILR7sMbcha/gFtpE8t0mr/I/m5SbI4+Ahl 5j0xPuQWUxRiCA8QBWr/l3OSkCexM9K1vLfhKT5qa5v3gz2n0mXSmq6j9JHwH2TsFOzy ZNeQ== X-Forwarded-Encrypted: i=1; AFNElJ/ZC0PFfoa1SLlMlBpegZBNBGihIoaeFqYL6Rh5Z7sqDZnECOjswOrrr0CbcTcy4akg5EcgEyA6PZwBIvI=@vger.kernel.org X-Gm-Message-State: AOJu0YwmbC2QZLlpeJt4+HqF6FJXnwje+9QZeryb4Q2x/22mEA+WiSkj cY01iBvcIIHrnYW/SHmdxj5n4aijZJ8sdHPPr9TEorTuYjK75j8LKlNsoH4jX7gEJac= X-Gm-Gg: AeBDietev2RbtlIHK+qja3ONz7L3Ni2C8Br12dr6CrGDa6Y1Pm+gkFa4sHBBtbuLW+H 3WmenT7jJhZfr1Onw9yyY6upsp8Hev5zszE9lLzkmyavXuywdn6aKkY3KP89wwa9Tg1EfR0hMDd XxRv3Hs901aF6M1pesq7M9kEqsKkHPm6dTy1FSTYTVbNtkCptsJhnkURqSZCdQqXs22KSKbSFAP 030Ozgj5Zfl8RLS8d7gQo0dWnNHnSKsGkpjecwlBNpBy7tB3LPoi6fZ3wWOnjxFNDm/+dhzAbC7 l02jDr8Gb63lfdc2cyKszczN8x0QFha9aZwWxXJXkWqrw2s78RYUj6FiIGCXhXj+h2RhYdk3rPp uT75JOkcJdAAlKeIaMQUXJMFdkD0OJ8NkSp9Xt9BMoQ9d1IW6uMGs7lspiRDx6gJ4bRR6BizLEX eYGPIiFkw930/vJhesItpl8/bNINs+5ZNsPK2ZysfqHIVwZ+CQaynqFYlBqRm3zoojch/RZWzwP mlN0AIeiTOkH7H3rj0= X-Received: by 2002:a05:600c:34ca:b0:48a:761:5816 with SMTP id 5b1f17b1804b1-48a07615b87mr18212465e9.8.1776683663648; Mon, 20 Apr 2026 04:14:23 -0700 (PDT) Received: from localhost (84-115-213-130.cable.dynamic.surfer.at. [84.115.213.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-489393ddd69sm10775525e9.10.2026.04.20.04.14.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 04:14:09 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 20 Apr 2026 13:14:01 +0200 Message-Id: From: "Luca Weiss" To: "Dmitry Baryshkov" , "Luca Weiss" Cc: "Liam Girdwood" , "Mark Brown" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Bartosz Golaszewski" , "Marcel Holtmann" , "Luiz Augusto von Dentz" , "Jeff Johnson" , "Bjorn Andersson" , "Konrad Dybcio" , "Manivannan Sadhasivam" , "Vinod Koul" , "Balakrishna Godavarthi" , "Matthias Kaehlcke" , , , , , , , , "Krzysztof Kozlowski" , "Bartosz Golaszewski" Subject: Re: [PATCH v3 3/8] wifi: ath10k: snoc: support powering on the device via pwrseq X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260119-wcn3990-pwrctl-v3-0-948df19f5ec2@oss.qualcomm.com> <20260119-wcn3990-pwrctl-v3-3-948df19f5ec2@oss.qualcomm.com> In-Reply-To: On Sat Apr 18, 2026 at 9:38 PM CEST, Dmitry Baryshkov wrote: > On Thu, Apr 16, 2026 at 12:06:09PM +0200, Luca Weiss wrote: >> Hi Dmitry, >>=20 >> On Mon Jan 19, 2026 at 6:07 PM CET, Dmitry Baryshkov wrote: >> > The WCN39xx family of WiFi/BT chips incorporates a simple PMU, spreadi= ng >> > voltages over internal rails. Implement support for using powersequenc= er >> > for this family of ATH10k devices in addition to using regulators. >> > >> > Reviewed-by: Bartosz Golaszewski >> > Signed-off-by: Dmitry Baryshkov >> > --- >> > drivers/net/wireless/ath/ath10k/snoc.c | 53 +++++++++++++++++++++++++= +++++++-- >> > drivers/net/wireless/ath/ath10k/snoc.h | 3 ++ >> > 2 files changed, 53 insertions(+), 3 deletions(-) >> > >> > + ar_snoc->pwrseq =3D devm_pwrseq_get(&pdev->dev, "wlan"); >> > + if (IS_ERR(ar_snoc->pwrseq)) { >> > + ret =3D PTR_ERR(ar_snoc->pwrseq); >> > + ar_snoc->pwrseq =3D NULL; >> > + if (ret !=3D -EPROBE_DEFER) >> > + goto err_free_irq; >>=20 >> I'm fairly sure this is now broken with CONFIG_POWER_SEQUENCING=3Dn sinc= e >> then pwrseq_get() is returning ERR_PTR(-ENOSYS) which is not handled >> here. >>=20 >> I'm observing my ath10k_snoc is now failing to probe "with error -38" >> which definitely seems to be related, but I haven't debugged it further >> yet. > > Posted https://patch.msgid.link/20260418-ath10k-snoc-pwrseq-v1-1-832594ba= 3294@oss.qualcomm.com Thanks Dmitry!