From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75394208D0 for ; Mon, 18 May 2026 06:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779085487; cv=none; b=uVxstdpckpVrMrTVzJISe5yMvGKU8qgl8Wq1yY3L+ZsP6TdTUisnlhHDq6qjr8rbZOI2kOtueJSpA9Soo4gjnPK17ohzbwghYWVNTzQNI0xmKzuiN8smGxmY80+vJfE17V0ergfNIVGQIGubL4kEnXt+U4eYpq6d94FCVUc0ETY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779085487; c=relaxed/simple; bh=TNwJr1jchWZc67pG29qjhg66q50p8XG7WgD9vWPGSnU=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=gE+CU1g66WNRXGFhTdMzSeDq9WtZ7n0HddUT6RUOZKGONgfIrddfK8zTmYjE2bz/ASfOFjXMKlIkURgRgxC4vvM7ROyx5i4a5fqi168uJ2dcQXiitwknPA/jEV1x2OiSGkHiWxwXqI4JjImRzzBRmdM6aVm9tuqN8Z9QuG7iHWw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qfeOIIp1; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qfeOIIp1" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c7980c060cfso713772a12.2 for ; Sun, 17 May 2026 23:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779085484; x=1779690284; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Z6rttZNdlncllwagKtpxOSQR52e6wAArMQpo2L8w5Pg=; b=qfeOIIp1xSXdXf+8Y5wjCVboqWseIkCHKWgi3qQjR3RzAIwt5eVDNdCxpbib1kERXv iSoG1TJajuWEuEDYNWriKaBI4DJ5YpQbfmmP3UC4wI5ii/VOjII1hNNCaSgFK4iBaUaX fFWHV6E0yMl9s3cSNGVk1zbkTGAypXcbDKzj65ylHqgH41zwlydiXsxSJYui3GcPHqYs pqb8F35vHUn3ZBvQ/BT8rMcCAakjJ9W4gd++se/fVJaMKjCX2//u+rBCbe39Rlvo/kpQ dpqz1OvhVg6eubVKOj0qJjr5pSczwzgsdLwhpUSGdfSUSIsSoT/GzrqbvZlSK3dGU6CM LvHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779085484; x=1779690284; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Z6rttZNdlncllwagKtpxOSQR52e6wAArMQpo2L8w5Pg=; b=pM+rRxzNruLXfe1U02/pUdYuFmkgiai7sqZKeQ6kzxYscKyrB6HggXYDGwJpouBrLU umlnBgqJUO0Ujs8CV6bD54W9Z3os8kcnlXR6VZigMumgREKXq6utP8kZKt307OT42vky gnr3a+TFZ6x6368cmG5e4pLCny64wVqhs9yOESo4gk11R7L0RdbxNtq4D1ahq5wcvK6f rQx6DXL5ac/TkbQWOz/eWl6Snmkwx3GBOj3PBRFpUCdqLTaobVTiUk6gveyurBsUSEmz gGI0Jh5gr8zmTG5KplctI22sULW5xdp/neybaiQnBeYX1TZlTPXbvxyftW5Oz7v1UeUg OFJQ== X-Forwarded-Encrypted: i=1; AFNElJ+1TjANXYFjhNUpmIPKOF9xI/HfUFQFIUuj7jXwNHg33oDoOWB2sHO5I89Vb96geiDLQIMQvy8550hkauU=@vger.kernel.org X-Gm-Message-State: AOJu0YweiQy8e7NhZ/mWjEBr36v7qBA2HS74NCWlIP9jB45LyHOmgjG4 CWALAPpQntLXNJM9eSNzk4QOVJPVMnTamWqqR1bM64a+r3BNn9n/qn7c X-Gm-Gg: Acq92OFHbz7cw3zMy5Tioyrx7tddjlr6lCE0jE5Sldct0jc34m7Rb81f6Auvz4YL66W h2p8x5wL7Wt7d7pmeF4VvAs8snA4dk7JVnfBIJiXy4vN0xuWXP4EMDfPA3NL0bKZioUaRded+dt 2/d8hSTGCi752V7vLTEytueryOCYe6mVb9qXNsViHWTJw6brSXmqyblsULQeFdwEuVGYyh9ga0L 04DyIffS4MdDowZhd34zdoxht2N8Wt8V5n43T2LuJYkmdJqxezH4NGvHBpkeDF5KEfNslNwpuj3 ZM5HRdvouSI4RFfd/rzO72WRPP/NFP3j/WlN+J2lumqI3nlUypA/DNgrB0LDluhUvnaaw9GoDNp b4IJGDudxigE6F8EQsE+vp2da3xCq3IvJgxFb3gT+pUyQ3lDNHPeWmJBi+6PdlBvZwka0xTMm91 K+FQB5sPbO9jPyzBR8R/eo54zTJsZMxtVFLFZnP0DFH7ikp+wAj7T9i9vzcKlsWJeCsX5SmIl4s q7OCYaLYduVzKJWIv6A6e58rRxaS3WsshpjCgUMykFtIMoUCpU= X-Received: by 2002:a17:903:1b4c:b0:2ba:7610:3f21 with SMTP id d9443c01a7336-2bd7e802964mr144520365ad.5.1779085483840; Sun, 17 May 2026 23:24:43 -0700 (PDT) Received: from localhost ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d235e04sm140491375ad.80.2026.05.17.23.24.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 May 2026 23:24:43 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 17 May 2026 23:24:42 -0700 Message-Id: Cc: , "Aaro Koskinen" , "Kevin Hilman" , "Roger Quadros" , "Tony Lindgren" , "Lee Jones" , "open list" Subject: Re: [PATCH] mfd: twl6030-irq: Use of_device_get_match_data() From: "Rosen Penev" To: "Andreas Kemnade" , "Rosen Penev" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260518041558.765958-1-rosenp@gmail.com> <20260518074631.532e25dd@kemnade.info> In-Reply-To: <20260518074631.532e25dd@kemnade.info> On Sun May 17, 2026 at 10:46 PM PDT, Andreas Kemnade wrote: > On Sun, 17 May 2026 21:15:58 -0700 > Rosen Penev wrote: > >> Use of_device_get_match_data() to fetch the IRQ mapping table directly i= nstead of open-coding an of_match_device() lookup. >> >> This also lets the driver drop the of_device.h include. >> >> Assisted-by: Codex:GPT-5.5 >> Signed-off-by: Rosen Penev >> --- >> drivers/mfd/twl6030-irq.c | 10 ++++------ >> 1 file changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c >> index 0ca00f618d4d..8831c81a1f90 100644 >> --- a/drivers/mfd/twl6030-irq.c >> +++ b/drivers/mfd/twl6030-irq.c >> @@ -27,7 +27,6 @@ >> #include >> #include >> #include >> -#include >> >> #include "twl-core.h" >> >> @@ -293,10 +292,10 @@ int twl6030_init_irq(struct device *dev, int irq_n= um) >> int nr_irqs; >> int status; >> u8 mask[3]; >> - const struct of_device_id *of_id; >> + const int *irq_mapping_tbl; >> >> - of_id =3D of_match_device(twl6030_of_match, dev); > > twl6030_of_match is used only here. > >> - if (!of_id || !of_id->data) { >> + irq_mapping_tbl =3D of_device_get_match_data(dev); > > so how should of_device_get_match_data() know about it? Ah looks like this is wrong. > > Regards, > Andreas