From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Sebastian Reichel" <sre@kernel.org>
Cc: "Michael Hennerich" <Michael.Hennerich@analog.com>,
"Pali Rohár" <pali@kernel.org>,
"Tobias Schrammm" <t.schramm@manjaro.org>,
"Iskren Chernev" <me@iskren.info>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Matheus Castello" <matheus@castello.eng.br>,
"Hans de Goede" <hansg@kernel.org>,
"Sebastian Krzyszkowiak" <sebastian.krzyszkowiak@puri.sm>,
"Purism Kernel Team" <kernel@puri.sm>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Hardevsinh Palaniya" <hardevsinh.palaniya@siliconsignals.io>,
"Bhavin Sharma" <bhavin.sharma@siliconsignals.io>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: Use named initializers for arrays of i2c_device_data
Date: Tue, 19 May 2026 13:17:58 +0200 [thread overview]
Message-ID: <DIMM16UB9JEN.31INBXKSQ2WFB@bootlin.com> (raw)
In-Reply-To: <20260515101629.4132270-2-u.kleine-koenig@baylibre.com>
On Fri May 15, 2026 at 12:16 PM CEST, Uwe Kleine-König (The Capable Hub) wrote:
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> i2c_device_id that replaces .driver_data by an anonymous union.
>
> While touching all these arrays, unify usage of whitespace and commas.
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits. The former was confirmed with x86 and arm64
> builds.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # max77976_charger.c
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-05-19 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 10:16 Uwe Kleine-König (The Capable Hub)
2026-05-19 11:17 ` Luca Ceresoli [this message]
2026-06-03 21:14 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIMM16UB9JEN.31INBXKSQ2WFB@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=Michael.Hennerich@analog.com \
--cc=bhavin.sharma@siliconsignals.io \
--cc=hansg@kernel.org \
--cc=hardevsinh.palaniya@siliconsignals.io \
--cc=kernel@puri.sm \
--cc=konradybcio@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matheus@castello.eng.br \
--cc=me@iskren.info \
--cc=pali@kernel.org \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=sre@kernel.org \
--cc=t.schramm@manjaro.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®