From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24BB324293C for ; Wed, 20 May 2026 12:14:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779279301; cv=none; b=UE8E/T6uFbVzMIHcDsBlYT4lyWpHCwBtCnHKHoe/qp57vFzRxALdubBDalNkuowLPsB6AXlWM1MLCk/oykdeKJG7UT9ZfPZDG2YMsdc741Sg1Ejf17BRDa6YT23c5hFaR1jzGV2M1eOjohmu86lJFIEGyrfvqL3WKlYdhqBI3CI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779279301; c=relaxed/simple; bh=c20waQ3ciaPhuvDx9sD7rBsAnnmu0YP6ZK66HfND+vk=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=H0N+bmTUs/E6+eOl5n40X1zUkgF1QB69chUbsXsN91YAriiOOxOp4Ser70xC8X31Sy7fNokrSkto0xdHtly/ev3vG8KeG2NM+CDHKTxZQO6XoQ/rQrUfBLhurSaQCfRmb4HARkUFsr2SsvLH6VVbXH+HwNE7eno+eSGIfTcjkBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=2c8DS+6e; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="2c8DS+6e" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-bd4f8260e4eso969445866b.1 for ; Wed, 20 May 2026 05:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1779279297; x=1779884097; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3XpYHzlqjA32IUkHlT71NisujrYawqJ/BOyAN5JmGyM=; b=2c8DS+6e6Uj7GZlhNIJ66CaRAg3WVVmSv6Dbmyi9IklK3iZexA++PhMKUkRkSxceXW LVpBAu7D8hCNhrW9jd749Hym4Yal58iX0Svea3miw9AZC3XYnJS83XjTdbLGebU8gz2J C8ZuiK7pX9a6iMp95Ue849K6Ejq0lpA50cupQIsshZ5KOKmR7i7NnGK+Nz1wRl5IZ/tB qei7gQiJjpMzKjrleGNopbm9v/Sy2WUiwBXDOjzHAwmpv+uEqax0/vb1/E5rQ7Xl4nV7 UtKc4TD+U2HhoqpTDgkQZFS7TQ2eqCY7BYJgTwgY0ttA1wMuORtmzndVQQumGIozE/OU +qvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779279297; x=1779884097; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3XpYHzlqjA32IUkHlT71NisujrYawqJ/BOyAN5JmGyM=; b=DKVTylcBH4fHN6ySOsSNwUZhMn0Y5il6PbATZzwfzm/xABse0E2wiICn1z16qhubCa re4eA+5ACn0aFEo5BUQ+7Vr31eRtG9kH1HomEmBNcReAzbB/EeRaVaFDS5dPXSGn6RdV CGSKd+6jqx6KcmwRIdNVNI5ryixZftryZ3L9EPkg4fgvhBbqU9cr3A/ZOhFzmXvGJaD8 A6X617+Q2jRyumd4LyLgP2TUHbW92CZYt6tohFNqIP4Ng1nB1/l+xXjBDRllATfaZMqh Ba//TRrVSHybEAGG95f6c7UoSxlGVnSKFYyWmcU4r5YbYm/Qtn9oSB7ofLmbCFErgKi/ R+aA== X-Forwarded-Encrypted: i=1; AFNElJ/UeD/TrgzwLlvRthQefgmxOES+N8kLcwsn/2YiWtHOIhT+bCtDpGwdG3PlYRzxQIjRo7Lk+XomztUO5yE=@vger.kernel.org X-Gm-Message-State: AOJu0YzeWw1KCIN1N7+2fm9TFcntAoGeqeOKJ0lwJhliX3Qj3B3KIB4y 0bPumEn+zqtShZsxEpGU5IJQWFFGMcW7Ca/etWo1CCZtp3ffd/qEbxYsynQU++v76/I= X-Gm-Gg: Acq92OFGMLov/s/VhdOs4oCODtCA0eGabR8YwqJARZdI+xxodFISAzoQgXwuj1IvWIJ BX0dNkuBTzLz0pNcItX0jNf8/mmmBr0vRZeALPtnP/NJgbvTMZfe0+4aQXV2tGLAWzubVgYZNR4 WDrmL1qtSSXeJkZvxEoshcCkpIYtX151t87UEv2SWDPhbBDuweZFwpsYEKDOozJAqvJK5NkPKi7 8SBBsGQeniaEEldlB5lFpOjlicDqWWSzMXrM1Nr9G1/s4nrKvl+ifM+pwWEploCEVdBzrTaR+vk kKaTzYxDI1YwXeN/Op53Ls/jQiSw1yiFWWvH9F15EQ5kUxFSQz0p9dE7PhAb9aS2k2Hleqq8nrN ddLqGTXFZ5uFUtZSNJarU7M+e0rw1c0tK+EfIw36qRyP7o7TCIEsxqGn9Kj7yAXLEbL5JHZ9Jun 8PyL03kS7BI3yECmDhSRWi57p3M37w2d5rqU/yT4RyqZePSi7iENJkSlf9PXIAc2TsgCBY X-Received: by 2002:a17:907:9607:b0:bda:17d0:cf02 with SMTP id a640c23a62f3a-bda17d0cf22mr285739166b.19.1779279297448; Wed, 20 May 2026 05:14:57 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4e604e6sm840883366b.52.2026.05.20.05.14.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 05:14:57 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 20 May 2026 14:14:56 +0200 Message-Id: From: "Luca Weiss" To: "Himanshu Bhavani" , Cc: "Hardevsinh Palaniya" , "Mauro Carvalho Chehab" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Bjorn Andersson" , "Konrad Dybcio" , "Hans Verkuil" , "Hans de Goede" , "Vladimir Zapolskiy" , "Elgin Perumbilly" , "Laurent Pinchart" , "Walter Werner Schneider" , "Kate Hsuan" , "Svyatoslav Ryhel" , , , , Subject: Re: [PATCH 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Add Sony IMX576 front camera support X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260520115641.11729-1-himanshu.bhavani@siliconsignals.io> <20260520115641.11729-4-himanshu.bhavani@siliconsignals.io> In-Reply-To: <20260520115641.11729-4-himanshu.bhavani@siliconsignals.io> Hi Himanshu, On Wed May 20, 2026 at 1:56 PM CEST, Himanshu Bhavani wrote: > From: Hardevsinh Palaniya > > Add device tree support for the Sony IMX576 front camera > sensor and connect it to CAMSS via CSIPHY3. > > Signed-off-by: Hardevsinh Palaniya Your Signed-off-by is missing here as well > --- > .../boot/dts/qcom/sm7225-fairphone-fp4.dts | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm= 64/boot/dts/qcom/sm7225-fairphone-fp4.dts > index 3964aae47fd4..5fb0f3eddf66 100644 > --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts > +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -547,6 +548,24 @@ vreg_bob: bob { > }; > }; > > +&camss { > + random extra newline > + vdd-csiphy3-0p9-supply =3D <&vreg_l18a>; > + vdd-csiphy3-1p25-supply =3D <&vreg_l22a>; If you're already enabling that, please also add the supplies for the other CSIPHYs (0-3). But also, since camss for sm6350 hasn't been merged upstream yet, this patchset depends on https://lore.kernel.org/linux-arm-msm/20260216-sm6350-camss-v4-0-b9df35f87e= db@fairphone.com/ You need to declare that in the cover letter! > + > + status =3D "okay"; > + > + ports { > + port@3 { > + csiphy3_ep: endpoint { > + data-lanes =3D <0 1 2 3>; > + bus-type =3D ; > + remote-endpoint =3D <&camera_imx576_ep>; > + }; > + }; > + }; > +}; > + > &cci0 { > status =3D "okay"; > }; > @@ -582,6 +601,34 @@ &cci1 { > > &cci1_i2c0 { > /* Front cam (Sony IMX576) @ 0x10 */ Remove the comment now since you're adding the node. > + camera@10 { > + compatible =3D "sony,imx576"; > + reg =3D <0x10>; > + > + avdd-supply =3D <&vreg_l3p>; > + dovdd-supply =3D <&vreg_32m_cam_dvdd_1p05>; > + dvdd-supply =3D <&vreg_l6p>; > + > + clocks =3D <&camcc CAMCC_MCLK1_CLK>; > + assigned-clocks =3D <&camcc CAMCC_MCLK1_CLK>; > + assigned-clock-rates =3D <24000000>; > + > + reset-gpios =3D <&tlmm 35 GPIO_ACTIVE_LOW>; > + pinctrl-0 =3D <&cam_mclk1_default>; > + pinctrl-names =3D "default"; > + > + orientation =3D <0>; I personally like adding a comment to make clear what '0' is: orientation =3D <0>; /* Front facing */ > + rotation =3D <90>; > + > + port { > + camera_imx576_ep: endpoint { > + data-lanes =3D <1 2 3 4>; > + bus-type =3D ; > + link-frequencies =3D /bits/ 64 <600000000>; > + remote-endpoint =3D <&csiphy3_ep>; > + }; > + }; > + }; > > eeprom@50 { > compatible =3D "giantec,gt24p64a", "atmel,24c64"; > @@ -1115,6 +1162,13 @@ platform { > &tlmm { > gpio-reserved-ranges =3D <13 4>, <56 2>; > > + cam_mclk1_default: cam-mclk1-default-state { > + pins =3D "gpio30"; > + function =3D "cam_mclk1"; > + drive-strength =3D <2>; > + bias-disable; > + }; I think I was told before that this can go into the SoC .dtsi Regards Luca > + > qup_uart1_sleep_cts: qup-uart1-sleep-cts-state { > pins =3D "gpio61"; > function =3D "gpio"; > -- > 2.34.1