From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5B0B191 for ; Thu, 28 May 2026 01:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779930941; cv=none; b=i3wfr4Bi2Ap4mZb8BJFwwGBGhOWbpza8ynRlNZRhVe7X6bIACKxcZd+VHurlIfrrZKgW5hi/09Duwipuin0e5hWdneC3yeJMdseQYL5qG22aNLTXY7z0KtTPwY8Ysv4xBnwqc9yFLNcg2lOKLMwevbMi5VxstjjgL5Y8mXIAm7I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779930941; c=relaxed/simple; bh=Mixj6xn5WoSIC0DQEG8/VLc5An/g4Q7amPQhck0k3PM=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To: References:In-Reply-To; b=Y3PlcufsP8f4xsQXMA4k/OgVSGjG66dB3IAebshV8uK+5zxC9LVonmrU6ZObIzb7x8QxuRydxw0eEBoUQ8ZDRhWylM4OIoJe7mnJezXNocdZDRLClpaIjLgI3IyK+9/uFQTDh0WISPc80VnMT63s4ctrAmx2RqAaPENX46mCRtU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dB+RfVY5; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dB+RfVY5" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-48a563e4ef7so88490795e9.0 for ; Wed, 27 May 2026 18:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779930937; x=1780535737; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2voxwMi0ctbkvCbmI9saWaf7WWfi0CrEFmlwsKP+cUo=; b=dB+RfVY5y32ag0tWLdQvBoFWnu7NJhD0WcpxmcxId5a63kpghDLC/BKakwi1hk6QfH U+/Mbi/3AYfrDqrfwLQFFHM4DMFLxY1nlFvqLhd/+/KBmRTwCLcCffx+NYKkpnynMO6e L2vQceIvu0TirlOPxjXew4U8HAIvlyPAlM0r/9eybulnKjqhfMY9+92e+U5EpLg0WDod erF4eSVfMzKv82V65FV007qUShHnyNluw0HYvyoO+06dcNbSO+EDfELvoJj1tldIFQkc v/naN5ITCzxtB7cePDO+Nqcka45NSByCMdwwUaljhLqiSGmdKLTwO2OgvmdVqRdfI32t yLig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779930937; x=1780535737; h=in-reply-to:references:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2voxwMi0ctbkvCbmI9saWaf7WWfi0CrEFmlwsKP+cUo=; b=ntQV1HMhl0h9VuwzDF0CkcTEzp5S7BV4Ki7II9mFuIhYuQs85ImizcCzSb89emCDNq 8N4a01Pp0WhaCC7HuO4O7Czwf0Oa3JStNxpZbsTamGIAkOXlWpQHFfLRAVzTj7azzuyR mkyOTEcULE6cHI8H/1KeUZflfST67oMYxkAM4XZSWWP+E4eoc/tg2PkGwDL/AI8c3sCb L0RM4ngmn9ye9dPbOI+jVbg8XSQw2yVfYFK0fDTYZIqzdczqO54E7o+cLEFbAHNS0krk vCo3Hpb4MD7Z8W1zYsMNKcP4nqRC5OWe3FH+Pv9ll/PtrQrLNbd03UVwt7tdWgvuAXuw hyHA== X-Forwarded-Encrypted: i=1; AFNElJ8fcexZ11VfU2Cw7Zh+/MSZ+pbJEIVKiSx9mYcZfh8U2T1xjgm69hn0wQsV8beRupR+Bp9DgeO0B2bCFaY=@vger.kernel.org X-Gm-Message-State: AOJu0YxUkAXstOdLBGzcBFfxa/rHtiyeTAyUO2smCdndAvpXVz2LYuSR 0ZuwKrQjFTjaJ8T4YEkPfKZ7O9lejryqrTKC5VY251PhfRAS9OrYhvtzR7IvE7Zn0Ws= X-Gm-Gg: Acq92OHYhf8koQDq/KbaLGt8Di98P8OCekb4EyzfAHxvsXoYs8PF9KWWwo0nZ7TXyvg kWda3M4h0wQIXfCJcea6AbjsyAq3bweANUrWh6DS7lREi4UOLllGocpgVTc9xWF07OHwutqmU8f vJ2S5wfErcWCn65pver3ccpuE2wzsvyQxTIWy9gLlaWQs7LtEINEPp1xOBxxfQCvvXB2cUc6Rxk UHv1QMCIEn9XOMH7kfFaKwlWn4qumR+AnrItyVC7jCb7Qel8cdLq3eFqtT06Y7983/UtQ1JPjVh O/49pHmX8iYUZfoOX36Urm3+WNjvQSHymakAuS37cU46aWvfbbe7in2LhpxIGpBMF1OiHeNC89K K9n7dD06Im75lCD8sE+amJw33bgh4ACGr/W4pD1/ngT+IzKz7ZAo18UiNx6ty74pf5upIqCenu6 LuIQHw5zmURMG+/xEHep1pBhAuYvbCOzeu1wAFa9hU6Giwq8WYxNo3G6lXjlMfdowwCH/mY/CTc qvPZZJfzVCQaHve27rksEfWU0UIQoY6vKM= X-Received: by 2002:a05:600c:3d96:b0:490:5429:1513 with SMTP id 5b1f17b1804b1-49054291bbamr369303675e9.6.1779930936735; Wed, 27 May 2026 18:15:36 -0700 (PDT) Received: from localhost ([94.4.195.193]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45edb5c44e4sm9654900f8f.36.2026.05.27.18.15.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2026 18:15:35 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 28 May 2026 02:15:33 +0100 Message-Id: Subject: Re: [PATCH] clk: samsung: exynos5410: fix refcount leak From: "Alexey Klimov" To: "Alexander A. Klimov" , "Krzysztof Kozlowski" , "Sylwester Nawrocki" , "Chanwoo Choi" , "Alim Akhtar" , "Michael Turquette" , "Stephen Boyd" , "Brian Masney" , "open list:SAMSUNG SOC CLOCK DRIVERS" , "open list:COMMON CLK FRAMEWORK" , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list" X-Mailer: aerc 0.21.0 References: <20260526061321.6123-1-grandmaster@al2klimov.de> In-Reply-To: <20260526061321.6123-1-grandmaster@al2klimov.de> On Tue May 26, 2026 at 7:13 AM BST, Alexander A. Klimov wrote: > Every value returned from of_clk_get() is supposed to be cleaned up > via clk_put() once not needed anymore. > > Fixes: be95d2c7d918 ("clk: samsung: Add support for EPLL on exynos5410") > Signed-off-by: Alexander A. Klimov Reviewed-by: Alexey Klimov > --- > drivers/clk/samsung/clk-exynos5410.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5410.c b/drivers/clk/samsung/c= lk-exynos5410.c > index baa9988c7bb7..0cd9b0392cf5 100644 > --- a/drivers/clk/samsung/clk-exynos5410.c > +++ b/drivers/clk/samsung/clk-exynos5410.c > @@ -269,8 +269,12 @@ static void __init exynos5410_clk_init(struct device= _node *np) > { > struct clk *xxti =3D of_clk_get(np, 0); > =20 > - if (!IS_ERR(xxti) && clk_get_rate(xxti) =3D=3D 24 * MHZ) > - exynos5410_plls[epll].rate_table =3D exynos5410_pll2550x_24mhz_tbl; > + if (!IS_ERR(xxti)) { > + if (clk_get_rate(xxti) =3D=3D 24 * MHZ) > + exynos5410_plls[epll].rate_table =3D > + exynos5410_pll2550x_24mhz_tbl; > + clk_put(xxti); > + } > =20 > samsung_cmu_register_one(np, &cmu); Best regards, Alexey Klimov